Skip to contentSkip to conversation

uapi elf: delete unused macros

PATCH In review mudongliang 2 participants 2 messages Nov 6, 2015 – Apr 11, 2016

Subsystems (3)
PowerPC exec and binfmt ABI/API
lore
Share & tools
lore

mudongliang

author
#0 lore raw

PATCH 1/1 uapi elf: delete unused macros

Quoted 1 line

From 13f516acc709d88d3162e92bc891c8e39cc9fc1a Mon Sep 17 00:00:00 2001

From: mudongliang <[email protected]>
Date: Fri, 6 Nov 2015 14:35:19 +0800
Subject: [PATCH] unify the comment form and delete unused macros

Signed-off-by mudongliang <[email protected]>
---
 arch/powerpc/boot/elf.h  | 6 ++----
 include/uapi/linux/elf.h | 6 ++----
 2 files changed, 4 insertions(+), 8 deletions(-)
arch/powerpc/boot/elf.h +2 -4
index 1941bc5..e6e00ed 100644
@@ -133,15 +133,13 @@ typedef struct elf64_phdr {
 #define	ELFCLASSNONE	0	/* EI_CLASS */
 #define	ELFCLASS32	1
 #define	ELFCLASS64	2
-#define	ELFCLASSNUM	3
 
-#define ELFDATANONE	0	/* e_ident[EI_DATA] */
+#define ELFDATANONE	0	/* EI_DATA */
 #define ELFDATA2LSB	1
 #define ELFDATA2MSB	2
 
-#define EV_NONE		0	/* e_version, EI_VERSION */
+#define EV_NONE		0	/* EI_VERSION */
 #define EV_CURRENT	1
-#define EV_NUM		2
 
 #define ELFOSABI_NONE	0
 #define ELFOSABI_LINUX	3
include/uapi/linux/elf.h +2 -4
index 71e1d0e..ff81b20 100644
@@ -342,15 +342,13 @@ typedef struct elf64_shdr {
 #define	ELFCLASSNONE	0		/* EI_CLASS */
 #define	ELFCLASS32	1
 #define	ELFCLASS64	2
-#define	ELFCLASSNUM	3
 
-#define ELFDATANONE	0		/* e_ident[EI_DATA] */
+#define ELFDATANONE	0		/* EI_DATA */
 #define ELFDATA2LSB	1
 #define ELFDATA2MSB	2
 
-#define EV_NONE		0		/* e_version, EI_VERSION */
+#define EV_NONE		0		/* EI_VERSION */
 #define EV_CURRENT	1
-#define EV_NUM		2
 
 #define ELFOSABI_NONE	0
 #define ELFOSABI_LINUX	3
Signature · 8 lines
2.1.4


-- 
My best regards to you.

     No System Is Safe!
     mudongliang
reviewer
#1 lore raw
Quoted 14 lines · On Fri, 2015-06-11 at 14:45:47 UTC, =?utf-8?b?5oWV5Yas5Lqu?= wrote:
Quoted 1 line

From 13f516acc709d88d3162e92bc891c8e39cc9fc1a Mon Sep 17 00:00:00 2001

From: mudongliang <[email protected]>
Date: Fri, 6 Nov 2015 14:35:19 +0800
Subject: [PATCH] unify the comment form and delete unused macros

include/uapi/linux/elf.h +0 -1
index 71e1d0e..ff81b20 100644
@@ -342,15 +342,13 @@ typedef struct elf64_shdr {
 #define	ELFCLASSNONE	0		/* EI_CLASS */
 #define	ELFCLASS32	1
 #define	ELFCLASS64	2
-#define	ELFCLASSNUM	3

include/uapi/linux/elf.h typedef struct elf64_shdr { · line 353

Quoted 10 lines
include/uapi/linux/elf.h +2 -3
 
-#define ELFDATANONE	0		/* e_ident[EI_DATA] */
+#define ELFDATANONE	0		/* EI_DATA */
 #define ELFDATA2LSB	1
 #define ELFDATA2MSB	2
 
-#define EV_NONE		0		/* e_version, EI_VERSION */
+#define EV_NONE		0		/* EI_VERSION */
 #define EV_CURRENT	1
-#define EV_NUM		2

How do you know there isn't a userspace program somewhere that's using this definition?

cheers