serial: serial_x86: add ns16550a compatible ids
PATCH 1/1 serial: serial_x86: add ns16550a compatible ids
Add ns16550a compatible ids, so that other arch may use this standard driver.
--- drivers/serial/serial_x86.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/serial/serial_x86.c +2 -0
@@ -14,6 +14,8 @@ DECLARE_GLOBAL_DATA_PTR;static const struct udevice_id x86_serial_ids[] = { { .compatible ="x86-uart" }, + { .compatible ="ns16550a" }, + { .compatible ="ns16550" }, { } };
Signature · 1 line
2.5.0
PATCH 1/1 serial: serial_x86: add ns16550a compatible ids
Hi Simon,
Quoted 13 lines · Thomas Chou
Add ns16550a compatible ids, so that other arch may use this standard driver.
Signed-off-by Thomas Chou <[email protected]>--- drivers/serial/serial_x86.c | 2 ++ 1 file changed, 2 insertions(+)drivers/serial/serial_x86.c +0
-0
drivers/serial/serial_x86.c DECLARE_GLOBAL_DATA_PTR; · line 20
Quoted 7 lines
drivers/serial/serial_x86.c +2
-0@@ -14,6 +14,8 @@ DECLARE_GLOBAL_DATA_PTR;static const struct udevice_id x86_serial_ids[] = { { .compatible ="x86-uart" }, + { .compatible ="ns16550a" }, + { .compatible ="ns16550" }, { } };
I want to use serial_x86.c for nios2. I think there is no need to duplicate another one for altera/nios2. Is there a proper way to change Kconfig/Makefile?
Best regards,
Thomas
PATCH 1/1 serial: serial_x86: add ns16550a compatible ids
Hi Thomas,
Quoted 18 lines · Thomas Chou
Hi Simon,
Quoted 15 lines · Thomas Chou
Add ns16550a compatible ids, so that other arch may use this standard driver.
Signed-off-by Thomas Chou <[email protected]>--- drivers/serial/serial_x86.c | 2 ++ 1 file changed, 2 insertions(+)drivers/serial/serial_x86.c +0
-0@@ -14,6 +14,8 @@ DECLARE_GLOBAL_DATA_PTR;
Quoted 12 lines
drivers/serial/serial_x86.c DECLARE_GLOBAL_DATA_PTR; · line 20
Quoted 6 lines
drivers/serial/serial_x86.c +2
-0static const struct udevice_id x86_serial_ids[] = { { .compatible ="x86-uart" }, + { .compatible ="ns16550a" }, + { .compatible ="ns16550" }, { } };I want to use
serial_x86.cfor nios2. I think there is no need to duplicate another one for altera/nios2. Is there a proper way to change Kconfig/Makefile?
Please check my previous proposal on serial driver clean up.
http://lists.denx.de/pipermail/u-boot/2015-August/223758.html
Regards,
Bin
PATCH 1/1 serial: serial_x86: add ns16550a compatible ids
Hi Bin,
Quoted 8 lines · Bin Meng
Quoted 4 lines
I want to use
serial_x86.cfor nios2. I think there is no need to duplicate another one for altera/nios2. Is there a proper way to change Kconfig/Makefile?Please check my previous proposal on serial driver clean up.
http://lists.denx.de/pipermail/u-boot/2015-August/223758.html
Thanks a lot for the pointer.
I think your suggestion is more practical. We can add clock-frequency to those have fixed clock. Then merge them to one driver.
For those need dynamic clock like tegra, we may ether leave them along. Or we can use the .data of compatible ids to fetch the clock.
We will need this soon.
Best regards,
Thomas
PATCH 1/1 serial: serial_x86: add ns16550a compatible ids
+Tom, Stephen
Hi,
Quoted 12 lines · Thomas Chou
Hi Bin,
Quoted 9 lines · Bin Meng
Quoted 6 lines
I want to use
serial_x86.cfor nios2. I think there is no need to duplicate
another one for altera/nios2. Is there a proper way to change Kconfig/Makefile?Please check my previous proposal on serial driver clean up.
Quoted 8 lines
Thanks a lot for the pointer.
I think your suggestion is more practical. We can add clock-frequency to those have fixed clock. Then merge them to one driver.
Sounds good.
Quoted 2 lines
For those need dynamic clock like tegra, we may ether leave them along. Or we can use the .data of compatible ids to fetch the clock.
Yes I think we should just add the property. It's silly to expect SPL to parse the entire clock logic in the DT. We can leave Tegra on its own for now.
Quoted 2 lines
We will need this soon.
Regards.
Simon