Skip to contentSkip to conversation

net: dsa: mv88e6060: cleanup and fix setup

PATCH In review Neil Armstrong 3 participants 4 messages Nov 10, 2015 – Nov 15, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover net: dsa: mv88e6060: cleanup and fix setup

This patchset introduces some fixes and a registers addressing cleanup for the mv88e6060 DSA driver.

The first patch removes the poll_link as mv88e6xxx.
The 3 following patches fixes the setup in regards of the datasheet. The 2 last patches introduces a clean header and replaces all magic values.

v2: cleanup InitReady patch, add missing Acked-by and fix header copyright notice

Neil Armstrong (6):
net: dsa: mv88e6060: remove poll_link callback
net: dsa: mv88e6060: use the correct InitReady bit
net: dsa: mv88e6060: use the correct MaxFrameSize bit
net: dsa: mv88e6060: use the correct bit shift for mac0
net: dsa: mv88e6060: add register defines header file
net: dsa: mv88e6060: replace magic values with register defines

 drivers/net/dsa/mv88e6060.c | 114 +++++++++++++++-----------------------------
 drivers/net/dsa/mv88e6060.h | 111 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 149 insertions(+), 76 deletions(-)
 create mode 100644 drivers/net/dsa/mv88e6060.h
Signature · 1 line
1.9.1
#1 lore raw
Quoted 2 lines · Neil Armstrong

This patchset introduces some fixes and a registers addressing cleanup for the mv88e6060 DSA driver.

Hi Neil

It is normal for netdev to put into the email subject of patches which tree these patches are for. "net" would be the latest -rcX and is for fixes only. "net-next" would be for new work aimed at the next merge window.

So long as Dave does not complain, leave them as they are now. But please try to follow this for your next patches.

Thanks
Andrew

#2 lore raw
Quoted 11 lines · Andrew Lunn
Quoted 2 lines · Neil Armstrong

This patchset introduces some fixes and a registers addressing cleanup for the mv88e6060 DSA driver.

Hi Neil

It is normal for netdev to put into the email subject of patches which tree these patches are for. "net" would be the latest -rcX and is for fixes only. "net-next" would be for new work aimed at the next merge window.

Quoted 6 lines

So long as Dave does not complain, leave them as they are now. But please try to follow this for your next patches.

Thanks
Andrew

Andrew,

Understood, I'll be careful for the next submissions.

Thanks,
Neil

maintainer
#3 lore raw
In reply to Neil Armstrong

From: Neil Armstrong <[email protected]>
Date: Tue, 10 Nov 2015 16:51:09 +0100

Quoted 8 lines

This patchset introduces some fixes and a registers addressing cleanup for the mv88e6060 DSA driver.

The first patch removes the poll_link as mv88e6xxx.
The 3 following patches fixes the setup in regards of the datasheet. The 2 last patches introduces a clean header and replaces all magic values.

v2: cleanup InitReady patch, add missing Acked-by and fix header copyright notice

Series applied, thanks.