Skip to contentSkip to conversation

omap3: cm-t3517: add board specific get_board_rev()

PATCH Superseded Dmitry Lifshitz 3 participants 5 messages Oct 8, 2015 – Nov 18, 2015

lore
Share & tools
lore

Dmitry Lifshitz

author
#0 lore raw

PATCH 1/1 omap3: cm-t3517: add board specific get_board_rev()

CM-T3517 has several HW revisions.
Add board specific get_board_rev() callback to retrieve revision number.

Signed-off-by Dmitry Lifshitz <[email protected]>
---
 board/compulab/cm_t3517/cm_t3517.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
board/compulab/cm_t3517/cm_t3517.c +9 -0
index 03b2bad..bf7dec2 100644
@@ -98,6 +98,15 @@ int board_init(void)
 	return 0;
 }
 
+/*
+ * Routine: get_board_rev
+ * Description: read system revision
+ */
+u32 get_board_rev(void)
+{
+	return cl_eeprom_get_board_rev();
+};
+
 int misc_init_r(void)
 {
 	cl_print_pcb_info();
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 omap3: cm-t3517: add board specific get_board_rev()

Hi Dima,

Quoted 13 lines · Dmitry Lifshitz

CM-T3517 has several HW revisions.
Add board specific get_board_rev() callback to retrieve revision number.

Signed-off-by Dmitry Lifshitz <[email protected]>
---
 board/compulab/cm_t3517/cm_t3517.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
board/compulab/cm_t3517/cm_t3517.c +0 -0
index 03b2bad..bf7dec2 100644

board/compulab/cm_t3517/cm_t3517.c int board_init(void) · line 107

Quoted 10 lines
board/compulab/cm_t3517/cm_t3517.c +7 -0
@@ -98,6 +98,15 @@ int board_init(void)
 	return 0;
 }
 
+/*
+ * Routine: get_board_rev
+ * Description: read system revision
+ */
+u32 get_board_rev(void)
+{
+	return cl_eeprom_get_board_rev();

will this compile on the recent U-Boot?

Quoted 6 lines
board/compulab/cm_t3517/cm_t3517.c +2 -0
+};
+
 int misc_init_r(void)
 {
 	cl_print_pcb_info();
Signature · 2 lines
Regards,
Igor.
author
#2 lore raw

PATCH v2 1/1 omap3: cm-t3517: add board specific get_board_rev()

CM-T3517 has several HW revisions.
Add board specific get_board_rev() callback to retrieve revision number.

Signed-off-by Dmitry Lifshitz <[email protected]>

---

Igor, Tom

I forgot to add a mailing list address in send-email. Resending the patch.

v2: Make proper use of cl_eeprom_get_board_rev() parameter.

 board/compulab/cm_t3517/cm_t3517.c | 9 +++++++++
 1 file changed, 9 insertions(+)
board/compulab/cm_t3517/cm_t3517.c +9 -0
index d1c74db..8aae248 100644
@@ -98,6 +98,15 @@ int board_init(void)
 	return 0;
 }
 
+/*
+ * Routine: get_board_rev
+ * Description: read system revision
+ */
+u32 get_board_rev(void)
+{
+	return cl_eeprom_get_board_rev(CONFIG_SYS_I2C_EEPROM_BUS);
+};
+
 int misc_init_r(void)
 {
 	cl_print_pcb_info();
Signature · 1 line
1.9.1
#3 lore raw

PATCH v2 1/1 omap3: cm-t3517: add board specific get_board_rev()

Quoted 4 lines · Dmitry Lifshitz

CM-T3517 has several HW revisions.
Add board specific get_board_rev() callback to retrieve revision number.

Signed-off-by Dmitry Lifshitz <[email protected]>
Reviewed-by Igor Grinberg <[email protected]>
Quoted 6 lines

---

Igor, Tom

I forgot to add a mailing list address in send-email. Resending the patch.

you may want to use aliases to simplify the stuff, check out doc/git-mailrc.

Quoted 27 lines

v2: Make proper use of cl_eeprom_get_board_rev() parameter.

 board/compulab/cm_t3517/cm_t3517.c | 9 +++++++++
 1 file changed, 9 insertions(+)
board/compulab/cm_t3517/cm_t3517.c +9 -0
index d1c74db..8aae248 100644
@@ -98,6 +98,15 @@ int board_init(void)
 	return 0;
 }
 
+/*
+ * Routine: get_board_rev
+ * Description: read system revision
+ */
+u32 get_board_rev(void)
+{
+	return cl_eeprom_get_board_rev(CONFIG_SYS_I2C_EEPROM_BUS);
+};
+
 int misc_init_r(void)
 {
 	cl_print_pcb_info();
Signature · 2 lines
Regards,
Igor.
#4 lore raw

PATCH v2 1/1 omap3: cm-t3517: add board specific get_board_rev()

In reply to Dmitry Lifshitz
Quoted 5 lines · Dmitry Lifshitz

CM-T3517 has several HW revisions.
Add board specific get_board_rev() callback to retrieve revision number.

Signed-off-by Dmitry Lifshitz <[email protected]>
Reviewed-by Igor Grinberg <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151118/c3d3397b/attachment.sig>