spi: bcm63xx: use correct format string for printing a resource
Subsystems (2)
PATCH 1/1 spi: bcm63xx: use correct format string for printing a resource
With a 64-bit resource_size_t, we get a build warning on bcm63xx_spi_probe:
drivers/spi/spi-bcm63xx.c:565:16: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
As we are printing a resource, we can just use the %pr format specifier that pretty-prints the address and avoids the warning.
---
Found on arm multi_v7_defconfig with LPAE
drivers/spi/spi-bcm63xx.c +2 -2
@@ -562,8 +562,8 @@ static int bcm63xx_spi_probe(struct platform_device *pdev) goto out_clk_disable; } -dev_info (dev,"at 0x%08x (irq %d, FIFOs size %d)\n" , - r->start, irq, bs->fifo_size); +dev_info (dev,"at %pr (irq %d, FIFOs size %d)\n" , + r, irq, bs->fifo_size);return 0 ;
Quoted 8 lines · Arnd Bergmann
With a 64-bit
resource_size_t, we get a build warning onbcm63xx_spi_probe:
drivers/spi/spi-bcm63xx.c:565:16: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t{aka long long unsigned int}' [-Wformat=]As we are printing a resource, we can just use the %pr format specifier that pretty-prints the address and avoids the warning.
Signed-off-by Arnd Bergmann <[email protected]>
Thanks
Quoted 25 lines
---
Found on armmulti_v7_defconfigwith LPAEdrivers/spi/spi-bcm63xx.c +2
-2@@ -562,8 +562,8 @@ static int bcm63xx_spi_probe(struct platform_device *pdev) goto out_clk_disable; } -dev_info (dev,"at 0x%08x (irq %d, FIFOs size %d)\n" , - r->start, irq, bs->fifo_size); +dev_info (dev,"at %pr (irq %d, FIFOs size %d)\n" , + r, irq, bs->fifo_size);return 0 ;_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Applied "spi: bcm63xx: use correct format string for printing a resource" to the spi tree
In reply to Arnd BergmannThe patch
spi: bcm63xx: use correct format string for printing a resource
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
0ba2cf70d23437161199e6b627f6948b47be9db4Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <[email protected]>
Date: Thu, 12 Nov 2015 17:44:34 +0100
Subject: [PATCH] spi: bcm63xx: use correct format string for printing a
resource
With a 64-bit resource_size_t, we get a build warning on bcm63xx_spi_probe:
drivers/spi/spi-bcm63xx.c:565:16: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
As we are printing a resource, we can just use the %pr format specifier that pretty-prints the address and avoids the warning.
--- drivers/spi/spi-bcm63xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/spi/spi-bcm63xx.c +2 -2
@@ -562,8 +562,8 @@ static int bcm63xx_spi_probe(struct platform_device *pdev) goto out_clk_disable; } -dev_info (dev,"at 0x%08x (irq %d, FIFOs size %d)\n" , - r->start, irq, bs->fifo_size); +dev_info (dev,"at %pr (irq %d, FIFOs size %d)\n" , + r, irq, bs->fifo_size);return 0 ;
Signature · 6 lines
2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html