Skip to contentSkip to conversation

rockchip: Turn on CONFIG_DEBUG_LL for firefly

PATCH New Ariel D'Alessandro 2 participants 3 messages Nov 12, 2015 – Nov 13, 2015

lore
Share & tools
lore

Ariel D'Alessandro

author
#0 lore raw

PATCH 1/1 rockchip: Turn on CONFIG_DEBUG_LL for firefly

CONFIG_DEBUG_UART is enabled in defconfig, but there's no Low-level debugging functions implemented, so build fails because of undefined references to `printch' in common/console.c.
In order to fix this, enable CONFIG_DEBUG_LL.

Signed-off-by Ariel D'Alessandro <[email protected]>
---
 configs/firefly-rk3288_defconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
configs/firefly-rk3288_defconfig +3 -1
index edb2db2..446ade9 100644
@@ -3,9 +3,11 @@ CONFIG_ARCH_ROCKCHIP=y
 CONFIG_SYS_MALLOC_F_LEN=0x2000
 CONFIG_ROCKCHIP_RK3288=y
 CONFIG_TARGET_FIREFLY_RK3288=y
+CONFIG_SPL_STACK_R_ADDR=0x80000
+CONFIG_DEBUG_LL=y
+CONFIG_DEBUG_UART_PHYS=0xff690000
 CONFIG_DEFAULT_DEVICE_TREE="rk3288-firefly"
 CONFIG_SPL_STACK_R=y
-CONFIG_SPL_STACK_R_ADDR=0x80000
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_PMIC=y
Signature · 1 line
2.6.2
#1 lore raw

PATCH 1/1 rockchip: Turn on CONFIG_DEBUG_LL for firefly

Quoted 5 lines · Ariel D'Alessandro

CONFIG_DEBUG_UART is enabled in defconfig, but there's no Low-level debugging functions implemented, so build fails because of undefined references to `printch' in common/console.c.
In order to fix this, enable CONFIG_DEBUG_LL.

I think you are fixing this the wrong way. This patch solves the problem as well, and I think it's the right way:

[patch format is probably wasted]
@@ -34,6 +34,7 @@ CONFIG_REGULATOR_ACT8846=y
CONFIG_RAM=y
CONFIG_SPL_RAM=y
CONFIG_DEBUG_UART=y
+CONFIG_DEBUG_UART_NS16550=y
CONFIG_DEBUG_UART_BASE=0xff690000
CONFIG_DEBUG_UART_CLOCK=24000000
CONFIG_DEBUG_UART_SHIFT=2

Without this fix, Altera JTAG UART is selected instead of NS16550. I expect other defconfigs (e.g. chromebook_jerry_defconfig) to suffer from this as well.

That said, I still haven't looked at the differences between DEBUG_LL and DEBUG_UART.

Signature · 2 lines
Ezequiel Garc?a, VanguardiaSur
www.vanguardiasur.com.ar
author
#2 lore raw

PATCH 1/1 rockchip: Turn on CONFIG_DEBUG_LL for firefly

Eze,

El 12/11/15 a las 19:11, Ezequiel Garcia escribi?:

Quoted 21 lines
Quoted 5 lines · Ariel D'Alessandro

CONFIG_DEBUG_UART is enabled in defconfig, but there's no Low-level debugging functions implemented, so build fails because of undefined references to `printch' in common/console.c.
In order to fix this, enable CONFIG_DEBUG_LL.

I think you are fixing this the wrong way. This patch solves the problem as well, and I think it's the right way:

[patch format is probably wasted]

(quoted diff) +1 -0
@@ -34,6 +34,7 @@ CONFIG_REGULATOR_ACT8846=y
 CONFIG_RAM=y
 CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART=y
+CONFIG_DEBUG_UART_NS16550=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
Quoted 1 line

Without this fix, Altera JTAG UART is selected instead of NS16550.

You're right. No UART driver is specified in defconfig, thus DEBUG_UART_ALTERA_JTAGUART is incorrectly selected by default. In fact, firefly-rk3288_defconfig got broken after the following commit was applied:

commit 220e8021af96741bd7149ca9895e1f0c8a38d0bb
Author: Thomas Chou <[email protected]>

nios2: convert altera_jtag_uart to driver model

Quoted 2 lines

I expect other defconfigs (e.g. chromebook_jerry_defconfig) to suffer from this as well.

Yes, chromebook_jerry_defconfig has exactly the same problem.

Quoted 4 lines

That said, I still haven't looked at the differences between DEBUG_LL and DEBUG_UART.

Signature · 2 lines
Ariel D'Alessandro, VanguardiaSur
www.vanguardiasur.com.ar