Skip to contentSkip to conversation

MMC/SDIO: enable SDIO device to suspend/resume asynchronously

PATCH Superseded Fu, Zhonghui 2 participants 3 messages Sep 21, 2015 – Nov 15, 2015 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 MMC/SDIO: enable SDIO device to suspend/resume asynchronously

Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition timing dependency between devices. This patch enables SDIO card and function devices to suspend/resume asynchronously. This will take advantage of multicore and improve system suspend/resume speed.

---
Changes in v2:
- Amend commit message.

 drivers/mmc/core/sdio.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/mmc/core/sdio.c +4 -0
index b91abed..6719b77 100644
@@ -1106,6 +1106,8 @@ int mmc_attach_sdio(struct mmc_host *host)
 		pm_runtime_enable(&card->dev);
 	}
 
+	device_enable_async_suspend(&card->dev);
+
 	/*
 	 * The number of functions on the card is encoded inside
 	 * the ocr.
@@ -1126,6 +1128,8 @@ int mmc_attach_sdio(struct mmc_host *host)
 		 */
 		if (host->caps & MMC_CAP_POWER_OFF_CARD)
 			pm_runtime_enable(&card->sdio_func[i]->dev);
+
+		device_enable_async_suspend(&card->sdio_func[i]->dev);
 	}
 
 	/*

-- 1.7.1

#1 lore raw
Quoted 30 lines · Zhonghui

Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition timing dependency between devices. This patch enables SDIO card and function devices to suspend/resume asynchronously. This will take advantage of multicore and improve system suspend/resume speed.

---
Changes in v2:
- Amend commit message.

 drivers/mmc/core/sdio.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/mmc/core/sdio.c +2 -0
index b91abed..6719b77 100644
@@ -1106,6 +1106,8 @@ int mmc_attach_sdio(struct mmc_host *host)
                pm_runtime_enable(&card->dev);
        }
 
+       device_enable_async_suspend(&card->dev);
+
        /*
         * The number of functions on the card is encoded inside
         * the ocr.

drivers/mmc/core/sdio.c int mmc_attach_sdio(struct mmc_host *host)

Quoted 9 lines
drivers/mmc/core/sdio.c +2 -1
@@ -1126,6 +1128,8 @@ int mmc_attach_sdio(struct mmc_host *host)
                 */
                if (host->caps & MMC_CAP_POWER_OFF_CARD)
                        pm_runtime_enable(&card->sdio_func[i]->dev);
+
+               device_enable_async_suspend(&card->sdio_func[i]->dev);
        }
 
        /*
-- 1.7.1

I wonder how you guarantee that the mmc host device will be suspended *after* the SDIO card device and the SDIO func device? Currently that is controlled via device registration/probe order, without any device hierarchy configured.

Kind regards
Uffe

#2 lore raw
In reply to Fu, Zhonghui

Please see the latest version: "[PATCH v3] MMC/SDIO: enable SDIO device to suspend/resume asynchronously".

Thanks,
Zhonghui

Quoted 40 lines · Zhonghui

Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition timing dependency between devices. This patch enables SDIO card and function devices to suspend/resume asynchronously. This will take advantage of multicore and improve system suspend/resume speed.

---
Changes in v2:
- Amend commit message.

 drivers/mmc/core/sdio.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/mmc/core/sdio.c +4 -1
index b91abed..6719b77 100644
@@ -1106,6 +1106,8 @@ int mmc_attach_sdio(struct mmc_host *host)
 		pm_runtime_enable(&card->dev);
 	}
 
+	device_enable_async_suspend(&card->dev);
+
 	/*
 	 * The number of functions on the card is encoded inside
 	 * the ocr.
@@ -1126,6 +1128,8 @@ int mmc_attach_sdio(struct mmc_host *host)
 		 */
 		if (host->caps & MMC_CAP_POWER_OFF_CARD)
 			pm_runtime_enable(&card->sdio_func[i]->dev);
+
+		device_enable_async_suspend(&card->sdio_func[i]->dev);
 	}
 
 	/*
-- 1.7.1