Skip to contentSkip to conversation

mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously

PATCH Superseded Fu, Zhonghui 2 participants 4 messages Sep 21, 2015 – Nov 16, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously

Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition timing dependency between devices. This patch enables sdhci-acpi device to suspend/resume asynchronously. This will take advantage of multicore and improve system suspend/resume speed.

---
Changes in v2:
- Amend commit message.

 drivers/mmc/host/sdhci-acpi.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/mmc/host/sdhci-acpi.c +2 -0
index 22d929f..67e6263 100644
@@ -379,6 +379,8 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
 		pm_runtime_enable(dev);
 	}
 
+	device_enable_async_suspend(dev);
+
 	return 0;
 
 err_free:

-- 1.7.1

#1 lore raw
Quoted 8 lines · Zhonghui

Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition timing dependency between devices. This patch enables sdhci-acpi device to suspend/resume asynchronously. This will take advantage of multicore and improve system suspend/resume speed.

It would be nice I think to put here statistics you collected as well.

Quoted 25 lines

---
Changes in v2:
- Amend commit message.

 drivers/mmc/host/sdhci-acpi.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/mmc/host/sdhci renamed from drivers/mmc/host/sdhci-acpi.c +0 -1
-acpi.c

index 22d929f..67e6263 100644

drivers/mmc/host/sdhci-acpi.c +2 -0
@@ -379,6 +379,8 @@ static int sdhci_acpi_probe(struct 
 platform_device *pdev)
 		pm_runtime_enable(dev);
 	}
 
+	device_enable_async_suspend(dev);
+
 	return 0;
 

err_free:
-- 1.7.1

Signature · 2 lines
Andy Shevchenko <[email protected]>
Intel Finland Oy
#2 lore raw
Quoted 10 lines · Andy Shevchenko
Quoted 8 lines · Zhonghui

Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition timing dependency between devices. This patch enables sdhci-acpi device to suspend/resume asynchronously. This will take advantage of multicore and improve system suspend/resume speed.

It would be nice I think to put here statistics you collected as well.

Sorry for replying this mail after long leave.

I have added the test result into commit message and sent the latest version of this patch:"[PATCH v3] mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously".

Thanks,
Zhonghui

Quoted 26 lines
Quoted 26 lines

---
Changes in v2:
- Amend commit message.

 drivers/mmc/host/sdhci-acpi.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/mmc/host/sdhci renamed from drivers/mmc/host/sdhci-acpi.c +0 -1
-acpi.c

index 22d929f..67e6263 100644

drivers/mmc/host/sdhci-acpi.c +2 -0
@@ -379,6 +379,8 @@ static int sdhci_acpi_probe(struct 
 platform_device *pdev)
 		pm_runtime_enable(dev);
 	}
 
+	device_enable_async_suspend(dev);
+
 	return 0;
 

err_free:
-- 1.7.1

#3 lore raw
In reply to Fu, Zhonghui

Please review the latest version: "[PATCH v3] mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously"

Thanks,
Zhonghui

Quoted 31 lines · Zhonghui

Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition timing dependency between devices. This patch enables sdhci-acpi device to suspend/resume asynchronously. This will take advantage of multicore and improve system suspend/resume speed.

---
Changes in v2:
- Amend commit message.

 drivers/mmc/host/sdhci-acpi.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/mmc/host/sdhci-acpi.c +2 -1
index 22d929f..67e6263 100644
@@ -379,6 +379,8 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
 		pm_runtime_enable(dev);
 	}
 
+	device_enable_async_suspend(dev);
+
 	return 0;
 
 err_free:
-- 1.7.1