Skip to contentSkip to conversation

package/gauche: fix getcontext not solved error on link

PATCH New Hiroshi Kawashima 3 participants 5 messages Nov 13, 2015 – Nov 16, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/gauche: fix getcontext not solved error on link

This patch is ported from bdwgc package. Gauche use internal boehm gc so it has same problem.

I touch configure directly instead of configure.ac because autoreconf failed by version mismatch of autotools.

Will fix:
http://autobuild.buildroot.org/results/8c6/8c6ce526735a36b8c8b4c6047e3c69039c4527cb//
http://autobuild.buildroot.org/results/894/89460829a737a4dab19103f7a46905636420b0a8//

---
 ...ac-add-check-for-NO_GETCONTEXT-definition.patch |   61 ++++++++++++++++++++
 1 files changed, 61 insertions(+), 0 deletions(-)
 create mode 100644 package/gauche/0002-gc-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch
package/gauche/0002-gc-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch new file +61 -0
new file mode 100644
index 0000000..8940574
@@ -0,0 +1,61 @@
+gc/configure.ac: add check for NO_GETCONTEXT definition
+
+This patch is ported from bdwgc package.
+Gauche use internal boehm gc so it has same problem.
+
+I touch configure directly instead of configure.ac because autoreconf
+failed by version mismatch of autotools.
+
+Signed-off-by: Hiroshi Kawashima <[email protected]>
+
+Original credits of patch in bdwgc package:
+Signed-off-by: Samuel Martin <[email protected]>
+[yann.morin.1998 at free.fr: add a comment, change variable name, use
+ AS_IF, remove debug traces, use AC_CHECK_FUNCS (as suggested by
+ Thomas)]
+Signed-off-by: "Yann E. MORIN" <[email protected]>
+Cc: Thomas Petazzoni <[email protected]>
+
+diff -ur a/gc/configure b/gc/configure
+--- a/gc/configure	2015-11-12 21:41:02.394822056 +0900
++++ b/gc/configure	2015-11-12 22:04:14.655157423 +0900
+@@ -16153,6 +16153,23 @@
+ $as_echo "$ac_cv_fno_strict_aliasing" >&6; }
+ fi
+ 
++# Check for getcontext (uClibc can be configured without it, for example)
++for ac_func in getcontext
++do :
++  ac_fn_c_check_func "$LINENO" "getcontext" "ac_cv_func_getcontext"
++if test "x$ac_cv_func_getcontext" = xyes; then :
++  cat >>confdefs.h <<_ACEOF
++#define HAVE_GETCONTEXT 1
++_ACEOF
++
++fi
++done
++
++if test "$ac_cv_func_getcontext" = "no"; then :
++  CFLAGS="$CFLAGS -DNO_GETCONTEXT"
++   CPPFLAGS="$CPPFLAGS -DNO_GETCONTEXT"
++fi
++
+ case "$host" in
+ # While IRIX 6 has libdl for the O32 and N32 ABIs, it's missing for N64
+ # and unnecessary everywhere.
+diff -ur a/gc/configure.ac b/gc/configure.ac
+--- a/gc/configure.ac	2015-11-12 22:31:44.851510997 +0900
++++ b/gc/configure.ac	2015-11-12 22:33:39.292191227 +0900
+@@ -459,6 +459,12 @@
+   AC_MSG_RESULT($ac_cv_fno_strict_aliasing)
+ fi
+ 
++# Check for getcontext (uClibc can be configured without it, for example)
++AC_CHECK_FUNCS([getcontext])
++AS_IF([test "$ac_cv_func_getcontext" = "no"],
++  [CFLAGS="$CFLAGS -DNO_GETCONTEXT"
++   CPPFLAGS="$CPPFLAGS -DNO_GETCONTEXT"])
++
+ case "$host" in
+ # While IRIX 6 has libdl for the O32 and N32 ABIs, it's missing for N64
+ # and unnecessary everywhere.
Signature · 4 lines
1.7.1

============================================================
    Hiroshi Kawashima
#1 lore raw

PATCH 1/1 package/gauche: fix getcontext not solved error on link

Quoted 11 lines · Hiroshi Kawashima

This patch is ported from bdwgc package. Gauche use internal boehm gc so it has same problem.

I touch configure directly instead of configure.ac because autoreconf failed by version mismatch of autotools.

Will fix:
http://autobuild.buildroot.org/results/8c6/8c6ce526735a36b8c8b4c6047e3c69039c4527cb//
http://autobuild.buildroot.org/results/894/89460829a737a4dab19103f7a46905636420b0a8//

However, ideally you should patch both configure.ac and configure, and also
send the patch upstream of course.

Regards,
Arnout

Quoted 73 lines
---
 ...ac-add-check-for-NO_GETCONTEXT-definition.patch |   61 ++++++++++++++++++++
 1 files changed, 61 insertions(+), 0 deletions(-)
 create mode 100644 package/gauche/0002-gc-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch
package/gauche/0002-gc-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch new file +61 -0
new file mode 100644
index 0000000..8940574
@@ -0,0 +1,61 @@
+gc/configure.ac: add check for NO_GETCONTEXT definition
+
+This patch is ported from bdwgc package.
+Gauche use internal boehm gc so it has same problem.
+
+I touch configure directly instead of configure.ac because autoreconf
+failed by version mismatch of autotools.
+
+Signed-off-by: Hiroshi Kawashima <[email protected]>
+
+Original credits of patch in bdwgc package:
+Signed-off-by: Samuel Martin <[email protected]>
+[yann.morin.1998 at free.fr: add a comment, change variable name, use
+ AS_IF, remove debug traces, use AC_CHECK_FUNCS (as suggested by
+ Thomas)]
+Signed-off-by: "Yann E. MORIN" <[email protected]>
+Cc: Thomas Petazzoni <[email protected]>
+
+diff -ur a/gc/configure b/gc/configure
+--- a/gc/configure	2015-11-12 21:41:02.394822056 +0900
++++ b/gc/configure	2015-11-12 22:04:14.655157423 +0900
+@@ -16153,6 +16153,23 @@
+ $as_echo "$ac_cv_fno_strict_aliasing" >&6; }
+ fi
+ 
++# Check for getcontext (uClibc can be configured without it, for example)
++for ac_func in getcontext
++do :
++  ac_fn_c_check_func "$LINENO" "getcontext" "ac_cv_func_getcontext"
++if test "x$ac_cv_func_getcontext" = xyes; then :
++  cat >>confdefs.h <<_ACEOF
++#define HAVE_GETCONTEXT 1
++_ACEOF
++
++fi
++done
++
++if test "$ac_cv_func_getcontext" = "no"; then :
++  CFLAGS="$CFLAGS -DNO_GETCONTEXT"
++   CPPFLAGS="$CPPFLAGS -DNO_GETCONTEXT"
++fi
++
+ case "$host" in
+ # While IRIX 6 has libdl for the O32 and N32 ABIs, it's missing for N64
+ # and unnecessary everywhere.
+diff -ur a/gc/configure.ac b/gc/configure.ac
+--- a/gc/configure.ac	2015-11-12 22:31:44.851510997 +0900
++++ b/gc/configure.ac	2015-11-12 22:33:39.292191227 +0900
+@@ -459,6 +459,12 @@
+   AC_MSG_RESULT($ac_cv_fno_strict_aliasing)
+ fi
+ 
++# Check for getcontext (uClibc can be configured without it, for example)
++AC_CHECK_FUNCS([getcontext])
++AS_IF([test "$ac_cv_func_getcontext" = "no"],
++  [CFLAGS="$CFLAGS -DNO_GETCONTEXT"
++   CPPFLAGS="$CPPFLAGS -DNO_GETCONTEXT"])
++
+ case "$host" in
+ # While IRIX 6 has libdl for the O32 and N32 ABIs, it's missing for N64
+ # and unnecessary everywhere.
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#2 lore raw

PATCH 1/1 package/gauche: fix getcontext not solved error on link

Dear Arnout.
Thank you for your comment.

Both of patch to configure and configure.ac are already included.

I will send patch to upstream.

Regards,
Kawashima

Quoted 109 lines

2015/11/16 16:00?Arnout Vandecappelle <[email protected]> ?????

Quoted 11 lines · Hiroshi Kawashima

This patch is ported from bdwgc package. Gauche use internal boehm gc so it has same problem.

I touch configure directly instead of configure.ac because autoreconf failed by version mismatch of autotools.

Will fix:
http://autobuild.buildroot.org/results/8c6/8c6ce526735a36b8c8b4c6047e3c69039c4527cb//
http://autobuild.buildroot.org/results/894/89460829a737a4dab19103f7a46905636420b0a8//

However, ideally you should patch both configure.ac and configure, and also send the patch upstream of course.

Regards,
Arnout

Quoted 73 lines

---
...ac-add-check-for-NO_GETCONTEXT-definition.patch | 61 ++++++++++++++++++++

1 files changed, 61 insertions(+), 0 deletions(-)

create mode 100644 package/gauche/0002-gc-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch

package/gauche/0002-gc-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch new file +61 -0
new file mode 100644
index 0000000..8940574
@@ -0,0 +1,61 @@
+gc/configure.ac: add check for NO_GETCONTEXT definition
+
+This patch is ported from bdwgc package.
+Gauche use internal boehm gc so it has same problem.
+
+I touch configure directly instead of configure.ac because autoreconf
+failed by version mismatch of autotools.
+
+Signed-off-by: Hiroshi Kawashima <[email protected]>
+
+Original credits of patch in bdwgc package:
+Signed-off-by: Samuel Martin <[email protected]>
+[yann.morin.1998 at free.fr: add a comment, change variable name, use
+ AS_IF, remove debug traces, use AC_CHECK_FUNCS (as suggested by
+ Thomas)]
+Signed-off-by: "Yann E. MORIN" <[email protected]>
+Cc: Thomas Petazzoni <[email protected]>
+
+diff -ur a/gc/configure b/gc/configure
+--- a/gc/configure	2015-11-12 21:41:02.394822056 +0900
++++ b/gc/configure	2015-11-12 22:04:14.655157423 +0900
+@@ -16153,6 +16153,23 @@
+ $as_echo "$ac_cv_fno_strict_aliasing" >&6; }
+ fi
+ 
++# Check for getcontext (uClibc can be configured without it, for example)
++for ac_func in getcontext
++do :
++  ac_fn_c_check_func "$LINENO" "getcontext" "ac_cv_func_getcontext"
++if test "x$ac_cv_func_getcontext" = xyes; then :
++  cat >>confdefs.h <<_ACEOF
++#define HAVE_GETCONTEXT 1
++_ACEOF
++
++fi
++done
++
++if test "$ac_cv_func_getcontext" = "no"; then :
++  CFLAGS="$CFLAGS -DNO_GETCONTEXT"
++   CPPFLAGS="$CPPFLAGS -DNO_GETCONTEXT"
++fi
++
+ case "$host" in
+ # While IRIX 6 has libdl for the O32 and N32 ABIs, it's missing for N64
+ # and unnecessary everywhere.
+diff -ur a/gc/configure.ac b/gc/configure.ac
+--- a/gc/configure.ac	2015-11-12 22:31:44.851510997 +0900
++++ b/gc/configure.ac	2015-11-12 22:33:39.292191227 +0900
+@@ -459,6 +459,12 @@
+   AC_MSG_RESULT($ac_cv_fno_strict_aliasing)
+ fi
+ 
++# Check for getcontext (uClibc can be configured without it, for example)
++AC_CHECK_FUNCS([getcontext])
++AS_IF([test "$ac_cv_func_getcontext" = "no"],
++  [CFLAGS="$CFLAGS -DNO_GETCONTEXT"
++   CPPFLAGS="$CPPFLAGS -DNO_GETCONTEXT"])
++
+ case "$host" in
+ # While IRIX 6 has libdl for the O32 and N32 ABIs, it's missing for N64
+ # and unnecessary everywhere.
Signature · 10 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
#3 lore raw

PATCH 1/1 package/gauche: fix getcontext not solved error on link

Quoted 4 lines · Hiroshi Kawashima

Dear Arnout.
Thank you for your comment.

Both of patch to configure and configure.ac are already included.

Ah sorry, the patch doesn't contain a diffstat that's why I missed it.

Also in your commit log you say "instead of", that should have been "in
addition to".

I already gave my Reviewed-by so that stands.

Regards,
Arnout

Quoted 2 lines

I will send patch to upstream.

[snip]

Signature · 6 lines
Arnout Vandecappelle      arnout dot vandecappelle at essensium dot com
Senior Embedded Software Architect . . . . . . +32-478-010353 (mobile)
Essensium, Mind division . . . . . . . . . . . . . . http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium . . . . . BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#4 lore raw

PATCH 1/1 package/gauche: fix getcontext not solved error on link

In reply to Hiroshi Kawashima

Hiroshi,

Quoted 10 lines · Hiroshi Kawashima

This patch is ported from bdwgc package. Gauche use internal boehm gc so it has same problem.

I touch configure directly instead of configure.ac because autoreconf failed by version mismatch of autotools.

Will fix:
http://autobuild.buildroot.org/results/8c6/8c6ce526735a36b8c8b4c6047e3c69039c4527cb//
http://autobuild.buildroot.org/results/894/89460829a737a4dab19103f7a46905636420b0a8//

Quoted 5 lines
---
 ...ac-add-check-for-NO_GETCONTEXT-definition.patch |   61 ++++++++++++++++++++
 1 files changed, 61 insertions(+), 0 deletions(-)
 create mode 100644 package/gauche/0002-gc-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch

Applied to master after tweaking the commit log and patch description, thanks.

Also, please report to upstream that their configure.ac doesn't work with modern version of the autotools, they should fix that up.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com