Skip to contentSkip to conversation

net: switchdev: fix return code of fdb_dump stub

PATCH Applied Dragos Tatulea 3 participants 3 messages Nov 16, 2015

Subsystems (3)
Networking Network drivers Switchdev
lore
Share & tools
lore

Dragos Tatulea

author
#0 lore raw

PATCH 1/1 net: switchdev: fix return code of fdb_dump stub

rtnl_fdb_dump always expects an index to be returned by the ndo_fdb_dump op, but when CONFIG_NET_SWITCHDEV is off, it returns an error.

Fix that by returning the given unmodified idx.

A similar fix was 0890cf6cb6ab ("switchdev: fix return value of switchdev_port_fdb_dump in case of error") but for the CONFIG_NET_SWITCHDEV=y case.

Fixes 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.")
Signed-off-by Dragos Tatulea <[email protected]>
---
 include/net/switchdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/net/switchdev.h +1 -1
index bc865e2..bc5765a 100644
@@ -323,7 +323,7 @@ static inline int switchdev_port_fdb_dump(struct sk_buff *skb,
                                          struct net_device *filter_dev,
                                          int idx)
 {
-       return -EOPNOTSUPP;
+       return idx;
 }
 
 static inline void switchdev_port_fwd_mark_set(struct net_device *dev,
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Mon, Nov 16, 2015 at 10:52:48AM CET, [email protected] wrote:

rtnl_fdb_dump always expects an index to be returned by the ndo_fdb_dump op, but when CONFIG_NET_SWITCHDEV is off, it returns an error.

Fix that by returning the given unmodified idx.

A similar fix was 0890cf6cb6ab ("switchdev: fix return value of switchdev_port_fdb_dump in case of error") but for the CONFIG_NET_SWITCHDEV=y case.

Fixes 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.")
Signed-off-by Dragos Tatulea <[email protected]>
Acked-by Jiri Pirko <[email protected]>
maintainer Applied
#2 lore raw
In reply to Dragos Tatulea

From: Dragos Tatulea <[email protected]>
Date: Mon, 16 Nov 2015 10:52:48 +0100

Quoted 11 lines

rtnl_fdb_dump always expects an index to be returned by the ndo_fdb_dump op, but when CONFIG_NET_SWITCHDEV is off, it returns an error.

Fix that by returning the given unmodified idx.

A similar fix was 0890cf6cb6ab ("switchdev: fix return value of switchdev_port_fdb_dump in case of error") but for the CONFIG_NET_SWITCHDEV=y case.

Fixes 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.")
Signed-off-by Dragos Tatulea <[email protected]>

Applied, thanks.