Skip to contentSkip to conversation

Add ACPI support for arm64 on Xen

PATCH In review shannon.zhao at linaro.org 10 participants 352 messages Nov 17, 2015 – Jan 8, 2016 Arm Samsung Exynos Page 3 of 3

lore
Share & tools
lore
#338 lore raw

PATCH v3 62/62 xen/arm64: Add ACPI support

In reply to shannon.zhao at linaro.org
Quoted 29 lines · shannon.zhao at linaro.org

From: Naresh Bhat <[email protected]>

Add ACPI support on arm64 xen hypervisor. Enable EFI support on ARM.

Signed-off-by Naresh Bhat <[email protected]>
Signed-off-by Shannon Zhao <[email protected]>
---
 config/arm64.mk              | 1 +
 xen/common/efi/runtime.c     | 2 +-
 xen/include/asm-arm/config.h | 5 +++++
 3 files changed, 7 insertions(+), 1 deletion(-)
config/arm64.mk +1 -0
index c5deb4e..c6a040b 100644
@@ -11,6 +11,7 @@ HAS_CADENCE_UART := y
 HAS_NS16550 := y
 HAS_MEM_ACCESS := y
 HAS_GICV3 := y
+HAS_ACPI := y
 
 # Use only if calling $(LD) directly.
 LDFLAGS_DIRECT += -EL
xen/common/efi/runtime.c +0 -0
index ae87557..7748056 100644

xen/common/efi/runtime.c DEFINE_XEN_GUEST_HANDLE(CHAR16); · line 14

Quoted 5 lines
xen/common/efi/runtime.c +1 -1
@@ -11,7 +11,7 @@ DEFINE_XEN_GUEST_HANDLE(CHAR16);
 #ifndef COMPAT
 
 #ifdef CONFIG_ARM  /* Disabled until runtime services implemented */
-const bool_t efi_enabled = 0;
+const bool_t efi_enabled = 1;

Don't we want to remove the comment at least?
We should also document under docs/ what is the supported interface to access runtime services.

Quoted 28 lines
xen/common/efi/runtime.c +0 -0
 #else
 # include <asm/i387.h>
 # include <asm/xstate.h>
xen/include/asm-arm/config.h +5 -0
index 817c216..e87fd27 100644
@@ -33,6 +33,11 @@
 
 #define CONFIG_ARM_L1_CACHE_SHIFT 7 /* XXX */
 
+#if defined(CONFIG_ARM_64)
+#define CONFIG_ACPI 1
+#define CONFIG_ACPI_BOOT 1
+#endif
+
 #define CONFIG_SMP 1
 
 #define CONFIG_VIDEO 1
Signature · 7 lines
2.1.0


_______________________________________________
Xen-devel mailing list
Xen-devel at lists.xen.org
http://lists.xen.org/xen-devel
#339 lore raw

PATCH v3 62/62 xen/arm64: Add ACPI support

In reply to shannon.zhao at linaro.org

Hi Shannon,

Quoted 29 lines · shannon.zhao at linaro.org

From: Naresh Bhat <[email protected]>

Add ACPI support on arm64 xen hypervisor. Enable EFI support on ARM.

Signed-off-by Naresh Bhat <[email protected]>
Signed-off-by Shannon Zhao <[email protected]>
---
 config/arm64.mk              | 1 +
 xen/common/efi/runtime.c     | 2 +-
 xen/include/asm-arm/config.h | 5 +++++
 3 files changed, 7 insertions(+), 1 deletion(-)
config/arm64.mk +1 -0
index c5deb4e..c6a040b 100644
@@ -11,6 +11,7 @@ HAS_CADENCE_UART := y
 HAS_NS16550 := y
 HAS_MEM_ACCESS := y
 HAS_GICV3 := y
+HAS_ACPI := y
 
 # Use only if calling $(LD) directly.
 LDFLAGS_DIRECT += -EL
xen/common/efi/runtime.c +0 -0
index ae87557..7748056 100644

xen/common/efi/runtime.c DEFINE_XEN_GUEST_HANDLE(CHAR16); · line 14

Quoted 5 lines
xen/common/efi/runtime.c +1 -1
@@ -11,7 +11,7 @@ DEFINE_XEN_GUEST_HANDLE(CHAR16);
 #ifndef COMPAT
 
 #ifdef CONFIG_ARM  /* Disabled until runtime services implemented */
-const bool_t efi_enabled = 0;
+const bool_t efi_enabled = 1;

Can you explained why efi_enabled is set unconditionally? Xen may have boot without EFI.

Regards,

Signature · 1 line
Julien Grall
#340 lore raw

Re: [PATCH v3 62/62] xen/arm64: Add ACPI support

In reply to shannon.zhao at linaro.org

Hi Shannon,

Quoted 29 lines · On 17/11/15 09:41, [email protected] wrote:

From: Naresh Bhat <[email protected]>

Add ACPI support on arm64 xen hypervisor. Enable EFI support on ARM.

Signed-off-by Naresh Bhat <[email protected]>
Signed-off-by Shannon Zhao <[email protected]>
---
 config/arm64.mk              | 1 +
 xen/common/efi/runtime.c     | 2 +-
 xen/include/asm-arm/config.h | 5 +++++
 3 files changed, 7 insertions(+), 1 deletion(-)
config/arm64.mk +1 -0
index c5deb4e..c6a040b 100644
@@ -11,6 +11,7 @@ HAS_CADENCE_UART := y
 HAS_NS16550 := y
 HAS_MEM_ACCESS := y
 HAS_GICV3 := y
+HAS_ACPI := y
 
 # Use only if calling $(LD) directly.
 LDFLAGS_DIRECT += -EL
xen/common/efi/runtime.c +0 -0
index ae87557..7748056 100644

xen/common/efi/runtime.c DEFINE_XEN_GUEST_HANDLE(CHAR16); · line 14

Quoted 5 lines
xen/common/efi/runtime.c +1 -1
@@ -11,7 +11,7 @@ DEFINE_XEN_GUEST_HANDLE(CHAR16);
 #ifndef COMPAT
 
 #ifdef CONFIG_ARM  /* Disabled until runtime services implemented */
-const bool_t efi_enabled = 0;
+const bool_t efi_enabled = 1;

Can you explained why efi_enabled is set unconditionally? Xen may have boot without EFI.

Regards,

Signature · 1 line
Julien Grall
#341 lore raw

v3 cover Add ACPI support for arm64 on Xen

In reply to shannon.zhao at linaro.org
Quoted 5 lines
Quoted 1 line
Quoted 1 line · On 17.11.15 at 10:39, <[email protected]> wrote:

From: Shannon Zhao <[email protected]>

This patch set adds ACPI support for arm64 on Xen. The design document could be found from [1].

Thank you very much for sending a 62-patch series to a set of people without tailoring the distribution list for the individual patches. I'm pretty sure I mentioned this to you before - please be mindful of the workload you impose on other people by sending out patches. I'll make limited effort of identifying the patches I actually need to look at, but the risk of patches getting discarded is going to be there.

Jan

#342 lore raw

v3 cover Add ACPI support for arm64 on Xen

Quoted 6 lines · Jan Beulich
Quoted 5 lines
Quoted 1 line
Quoted 1 line · On 17.11.15 at 10:39, <[email protected]> wrote:

From: Shannon Zhao <[email protected]>

This patch set adds ACPI support for arm64 on Xen. The design document could be found from [1].

Quoted 6 lines

Thank you very much for sending a 62-patch series to a set of people without tailoring the distribution list for the individual patches. I'm pretty sure I mentioned this to you before - please be mindful of the workload you impose on other people by sending out patches. I'll make limited effort of identifying the patches I actually need to look at, but the risk of patches getting discarded is going to be there.

Yes, I skimmed the subjects and it doesn't look like I'm the maintainer for any of the patches.

Please don't Cc me in the future.

David

#343 lore raw

v3 cover Add ACPI support for arm64 on Xen

Quoted 14 lines · David Vrabel
Quoted 6 lines · Jan Beulich
Quoted 5 lines
Quoted 1 line
Quoted 1 line · On 17.11.15 at 10:39, <[email protected]> wrote:

From: Shannon Zhao <[email protected]>

This patch set adds ACPI support for arm64 on Xen. The design document could be found from [1].

Quoted 6 lines

Thank you very much for sending a 62-patch series to a set of people without tailoring the distribution list for the individual patches. I'm pretty sure I mentioned this to you before - please be mindful of the workload you impose on other people by sending out patches. I'll make limited effort of identifying the patches I actually need to look at, but the risk of patches getting discarded is going to be there.

Quoted 3 lines

Yes, I skimmed the subjects and it doesn't look like I'm the maintainer for any of the patches.

The reason that I Cc to you is you gave some comments on the design document before. Thanks.

Quoted 2 lines

Please don't Cc me in the future.

Will do.

Signature · 1 line
Shannon
#344 lore raw
In reply to David Vrabel
Quoted 14 lines · David Vrabel
Quoted 6 lines · Jan Beulich
Quoted 5 lines
Quoted 1 line
Quoted 1 line · On 17.11.15 at 10:39, <[email protected]> wrote:

From: Shannon Zhao <[email protected]>

This patch set adds ACPI support for arm64 on Xen. The design document could be found from [1].

Quoted 6 lines

Thank you very much for sending a 62-patch series to a set of people without tailoring the distribution list for the individual patches. I'm pretty sure I mentioned this to you before - please be mindful of the workload you impose on other people by sending out patches. I'll make limited effort of identifying the patches I actually need to look at, but the risk of patches getting discarded is going to be there.

Quoted 3 lines

Yes, I skimmed the subjects and it doesn't look like I'm the maintainer for any of the patches.

The reason that I Cc to you is you gave some comments on the design document before. Thanks.

Quoted 2 lines

Please don't Cc me in the future.

Will do.

Signature · 1 line
Shannon
#345 lore raw
In reply to Jan Beulich
Quoted 6 lines · Jan Beulich
Quoted 5 lines
Quoted 1 line
Quoted 1 line · On 17.11.15 at 10:39, <[email protected]> wrote:

From: Shannon Zhao <[email protected]>

This patch set adds ACPI support for arm64 on Xen. The design document could be found from [1].

Quoted 6 lines

Thank you very much for sending a 62-patch series to a set of people without tailoring the distribution list for the individual patches. I'm pretty sure I mentioned this to you before - please be mindful of the workload you impose on other people by sending out patches. I'll make limited effort of identifying the patches I actually need to look at, but the risk of patches getting discarded is going to be there.

Yes, I skimmed the subjects and it doesn't look like I'm the maintainer for any of the patches.

Please don't Cc me in the future.

David

#346 lore raw

v3 cover Add ACPI support for arm64 on Xen

In reply to shannon.zhao at linaro.org

Hi Shannon,

Quoted 4 lines · shannon.zhao at linaro.org

From: Shannon Zhao <[email protected]>

This patch set adds ACPI support for arm64 on Xen. The design document could be found from [1].

Thank you for your work on it. I think this series would benefits to be split in smaller series.

I would do a first series which split DT code from common code. So we can get this code as soon as possible in Xen, avoid you to spend less time rebasing your us to be spammed with 62 patches for each new version.

Regards,

Signature · 1 line
Julien Grall
#347 lore raw

v3 cover Add ACPI support for arm64 on Xen

Quoted 8 lines · Julien Grall

Hi Shannon,

Quoted 4 lines · shannon.zhao at linaro.org

From: Shannon Zhao <[email protected]>

This patch set adds ACPI support for arm64 on Xen. The design document could be found from [1].

Quoted 7 lines

Thank you for your work on it. I think this series would benefits to be split in smaller series.

I would do a first series which split DT code from common code. So we can get this code as soon as possible in Xen, avoid you to spend less time rebasing your us to be spammed with 62 patches for each new version.

Sure, I think I can split this patch set in three parts.

First one would be porting the necessary Linux changes of ACPI 5.0~6.0. It includes:

ACPI 5.0: Add new/changed tables to headers (only changes of Generic Interrupt and Generic Distributor and some changes already exist) ACPICA/ARM: ACPI 5.1: Update for MADT changes.
ACPICA: ACPI 6.0: Add changes for MADT table.
ACPICA: ACPI 6.0: Add values for MADT GIC version field ACPICA/ARM: ACPI 5.1: Update for FADT changes.
ACPICA: ACPI 6.0: Add changes for FADT table
ACPICA/ARM: ACPI 5.1: Update for GTDT table changes.
ACPICA: Headers: Add GTDT flag definitions for the timer subtable.
ACPICA: ACPI 6.0: Add support for STAO table

Second one as you suggest would be the series which split DT codes from common code.

And the last one would be the series which add ACPI support for Xen on ARM and prepare the necessary things for Dom0.

How about this way? The order of the first and second can be changed if you like.

Thanks,

Signature · 1 line
Shannon
#348 lore raw

v3 cover Add ACPI support for arm64 on Xen

Quoted 33 lines · Shannon Zhao
Quoted 8 lines · Julien Grall

Hi Shannon,

Quoted 4 lines · shannon.zhao at linaro.org

From: Shannon Zhao <[email protected]>

This patch set adds ACPI support for arm64 on Xen. The design document could be found from [1].

Quoted 7 lines

Thank you for your work on it. I think this series would benefits to be split in smaller series.

I would do a first series which split DT code from common code. So we can get this code as soon as possible in Xen, avoid you to spend less time rebasing your us to be spammed with 62 patches for each new version.

Sure, I think I can split this patch set in three parts.

First one would be porting the necessary Linux changes of ACPI 5.0~6.0. It includes:

ACPI 5.0: Add new/changed tables to headers (only changes of Generic Interrupt and Generic Distributor and some changes already exist) ACPICA/ARM: ACPI 5.1: Update for MADT changes.
ACPICA: ACPI 6.0: Add changes for MADT table.
ACPICA: ACPI 6.0: Add values for MADT GIC version field ACPICA/ARM: ACPI 5.1: Update for FADT changes.
ACPICA: ACPI 6.0: Add changes for FADT table
ACPICA/ARM: ACPI 5.1: Update for GTDT table changes.
ACPICA: Headers: Add GTDT flag definitions for the timer subtable.
ACPICA: ACPI 6.0: Add support for STAO table

Quoted 8 lines

Second one as you suggest would be the series which split DT codes from common code.

And the last one would be the series which add ACPI support for Xen on ARM and prepare the necessary things for Dom0.

How about this way? The order of the first and second can be changed if you like.

I'm fine with either way.

Regards,

Signature · 1 line
Julien Grall
#349 lore raw
In reply to Shannon Zhao
Quoted 33 lines · Shannon Zhao
Quoted 8 lines · Julien Grall

Hi Shannon,

Quoted 4 lines · On 17/11/15 09:39, [email protected] wrote:

From: Shannon Zhao <[email protected]>

This patch set adds ACPI support for arm64 on Xen. The design document could be found from [1].

Quoted 7 lines

Thank you for your work on it. I think this series would benefits to be split in smaller series.

I would do a first series which split DT code from common code. So we can get this code as soon as possible in Xen, avoid you to spend less time rebasing your us to be spammed with 62 patches for each new version.

Sure, I think I can split this patch set in three parts.

First one would be porting the necessary Linux changes of ACPI 5.0~6.0. It includes:

ACPI 5.0: Add new/changed tables to headers (only changes of Generic Interrupt and Generic Distributor and some changes already exist) ACPICA/ARM: ACPI 5.1: Update for MADT changes.
ACPICA: ACPI 6.0: Add changes for MADT table.
ACPICA: ACPI 6.0: Add values for MADT GIC version field ACPICA/ARM: ACPI 5.1: Update for FADT changes.
ACPICA: ACPI 6.0: Add changes for FADT table
ACPICA/ARM: ACPI 5.1: Update for GTDT table changes.
ACPICA: Headers: Add GTDT flag definitions for the timer subtable.
ACPICA: ACPI 6.0: Add support for STAO table

Quoted 8 lines

Second one as you suggest would be the series which split DT codes from common code.

And the last one would be the series which add ACPI support for Xen on ARM and prepare the necessary things for Dom0.

How about this way? The order of the first and second can be changed if you like.

I'm fine with either way.

Regards,

Signature · 1 line
Julien Grall
#350 lore raw
In reply to Julien Grall
Quoted 8 lines · Julien Grall

Hi Shannon,

Quoted 4 lines · On 17/11/15 09:39, [email protected] wrote:

From: Shannon Zhao <[email protected]>

This patch set adds ACPI support for arm64 on Xen. The design document could be found from [1].

Quoted 7 lines

Thank you for your work on it. I think this series would benefits to be split in smaller series.

I would do a first series which split DT code from common code. So we can get this code as soon as possible in Xen, avoid you to spend less time rebasing your us to be spammed with 62 patches for each new version.

Sure, I think I can split this patch set in three parts.

First one would be porting the necessary Linux changes of ACPI 5.0~6.0. It includes:

ACPI 5.0: Add new/changed tables to headers (only changes of Generic Interrupt and Generic Distributor and some changes already exist) ACPICA/ARM: ACPI 5.1: Update for MADT changes.
ACPICA: ACPI 6.0: Add changes for MADT table.
ACPICA: ACPI 6.0: Add values for MADT GIC version field ACPICA/ARM: ACPI 5.1: Update for FADT changes.
ACPICA: ACPI 6.0: Add changes for FADT table
ACPICA/ARM: ACPI 5.1: Update for GTDT table changes.
ACPICA: Headers: Add GTDT flag definitions for the timer subtable.
ACPICA: ACPI 6.0: Add support for STAO table

Second one as you suggest would be the series which split DT codes from common code.

And the last one would be the series which add ACPI support for Xen on ARM and prepare the necessary things for Dom0.

How about this way? The order of the first and second can be changed if you like.

Thanks,

Signature · 1 line
Shannon
#351 lore raw
In reply to shannon.zhao at linaro.org

Hi Shannon,

Quoted 4 lines · On 17/11/15 09:39, [email protected] wrote:

From: Shannon Zhao <[email protected]>

This patch set adds ACPI support for arm64 on Xen. The design document could be found from [1].

Thank you for your work on it. I think this series would benefits to be split in smaller series.

I would do a first series which split DT code from common code. So we can get this code as soon as possible in Xen, avoid you to spend less time rebasing your us to be spammed with 62 patches for each new version.

Regards,

Signature · 1 line
Julien Grall