Skip to contentSkip to conversation

liquid-dsp: blacklist CS powerpc toolchains

PATCH New Gustavo Zacarias 2 participants 3 messages Nov 17, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 liquid-dsp: blacklist CS powerpc toolchains

They're unable to build liquid-dsp successfully resulting in an internal compiler error. Fixes:
http://autobuild.buildroot.net/results/2ac/2acd745f4e5ec6edfd09afcd57b9ece216724c1b/

---
 package/liquid-dsp/Config.in | 3 +++
 1 file changed, 3 insertions(+)
package/liquid-dsp/Config.in +3 -0
index 95233da..c388734 100644
@@ -5,6 +5,9 @@ config BR2_PACKAGE_LIQUID_DSP
 	bool "liquid-dsp"
 	depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL
 	depends on !BR2_STATIC_LIBS
+	# These result in internal compiler error
+	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201103
+	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201009
 	help
 	  Liquid-DSP is a free and open-source signal processing
 	  library for software-defined radios written in C.  Its
Signature · 1 line
2.4.10
#1 lore raw

PATCH 1/1 liquid-dsp: blacklist CS powerpc toolchains

Dear Gustavo Zacarias,

Quoted 8 lines · Gustavo Zacarias

They're unable to build liquid-dsp successfully resulting in an internal compiler error. Fixes:
http://autobuild.buildroot.net/results/2ac/2acd745f4e5ec6edfd09afcd57b9ece216724c1b/

---
 package/liquid-dsp/Config.in | 3 +++
 1 file changed, 3 insertions(+)

You forgot to use the same dependencies in the comment, to avoid it being displayed in cases where the package can anyway not be enabled. I've applied to master after fixing this. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 liquid-dsp: blacklist CS powerpc toolchains

Quoted 5 lines · Thomas Petazzoni

You forgot to use the same dependencies in the comment, to avoid it being displayed in cases where the package can anyway not be enabled. I've applied to master after fixing this. Thanks!

Thomas

Hi Thomas.
I believe that would be a no-op, since:

comment "liquid-dsp requires a (e)glibc/musl toolchain w/ dynamic library"

         depends on !(BR2_TOOLCHAIN_USES_GLIBC || 

BR2_TOOLCHAIN_USES_MUSL) || BR2_STATIC_LIBS

It is a glibc toolchain (well, eglibc i believe, but same deal), and glibc toolchains can't do static, so unreachable.

Regards.