Skip to contentSkip to conversation

of/irq: export of_irq_count

PATCH New Zhangfei Gao 3 participants 5 messages Oct 15, 2015 – Nov 18, 2015 Device tree

lore
Share & tools
lore

Zhangfei Gao

author
#0 lore raw

PATCH 1/1 of/irq: export of_irq_count

Export of_irq_count, otherwise module build fail if of_irq_count is used

Signed-off-by Zhangfei Gao <[email protected]>
Signed-off-by John Garry <[email protected]>
---
 drivers/of/irq.c | 1 +
 1 file changed, 1 insertion(+)
drivers/of/irq.c +1 -0
index 0c7f4cbe3434..0d149cc48cfe 100644
@@ -448,6 +448,7 @@ int of_irq_count(struct device_node *dev)
 
 	return nr;
 }
+EXPORT_SYMBOL_GPL(of_irq_count);
 
 /**
  * of_irq_to_resource_table - Fill in resource table with node's IRQ info
Signature · 1 line
1.9.1
maintainer
#2 lore raw

PATCH 1/1 of/irq: export of_irq_count

In reply to Zhangfei Gao
Quoted 1 line · Zhangfei Gao

Export of_irq_count, otherwise module build fail if of_irq_count is used

Which module?

Quoted 22 lines
Signed-off-by Zhangfei Gao <[email protected]>
Signed-off-by John Garry <[email protected]>
---
 drivers/of/irq.c | 1 +
 1 file changed, 1 insertion(+)
drivers/of/irq.c +1 -1
index 0c7f4cbe3434..0d149cc48cfe 100644
@@ -448,6 +448,7 @@ int of_irq_count(struct device_node *dev)
 
        return nr;
 }
+EXPORT_SYMBOL_GPL(of_irq_count);
 
 /**
  * of_irq_to_resource_table - Fill in resource table with node's IRQ info
--

1.9.1

author
#3 lore raw

PATCH 1/1 of/irq: export of_irq_count

Hi, Rob

Quoted 4 lines · Rob Herring
Quoted 1 line · Zhangfei Gao

Export of_irq_count, otherwise module build fail if of_irq_count is used

Which module?

We are developing sas driver for hisilicon hip660 platform. We using of_irq_count to get irq number, since there are many irqs. When we testing with build module, find build error since of_irq_count is not exported.

Thanks

author
#4 lore raw

PATCH 1/1 of/irq: export of_irq_count

In reply to Rob Herring

Hi Rob

Quoted 4 lines · Rob Herring
Quoted 1 line · Zhangfei Gao

Export of_irq_count, otherwise module build fail if of_irq_count is used

Which module?

https://lkml.org/lkml/2015/11/17/572

What do you think about this patch?

There is ERROR reported from kbuild.

[auto build test ERROR on scsi/for-next]
[also build test ERROR on v4.4-rc1 next-20151116]

url:
https://github.com/0day-ci/linux/commits/John-Garry/HiSilicon-SAS-driver/20151116-215304
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git
for-next
config: i386-allmodconfig (attached as .config)
reproduce:

         # save the attached .config to linux build tree
         make ARCH=i386

All errors (new ones prefixed by >>):

Quoted 1 line
Quoted 1 line

ERROR: "of_irq_count" undefined!

Thanks