Skip to contentSkip to conversation

libnet: disable for musl toolchains

PATCH New Joris Lijssens 3 participants 5 messages Nov 20, 2015 – Nov 29, 2015

lore
Share & tools
lore

Joris Lijssens

author
#0 lore raw

PATCH 1/2 libnet: disable for musl toolchains

Signed-off-by Joris Lijssens <[email protected]>
---
 package/libnet/Config.in | 5 +++++
 1 file changed, 5 insertions(+)
package/libnet/Config.in +5 -0
index 7186972..8a88128 100644
@@ -1,7 +1,12 @@
 config BR2_PACKAGE_LIBNET
 	bool "libnet"
+	# Build with musl fails due to header issues
+	depends on !BR2_TOOLCHAIN_USES_MUSL
 	help
 	  libnet provides a portable framework for low-level network
 	  packet construction.
 
 	  http://sourceforge.net/projects/libnet-dev
+
+comment "libnet needs a (e)glibc or uClibc toolchain"
+	depends on BR2_TOOLCHAIN_USES_MUSL
Signature · 1 line
1.8.3.1
author
#1 lore raw

PATCH 2/2 libnet: PF_PACKET is always available on Linux

Signed-off-by Joris Lijssens <[email protected]>
---
 package/libnet/libnet.mk | 3 +++
 1 file changed, 3 insertions(+)
package/libnet/libnet.mk +3 -0
index 3b62a79..1a5e610 100644
@@ -7,7 +7,10 @@
 LIBNET_VERSION = 1.1.6
 LIBNET_SITE = http://sourceforge.net/projects/libnet-dev/files
 LIBNET_INSTALL_STAGING = YES
+# PF_PACKET is always available on Linux
+LIBNET_CONF_OPTS = libnet_cv_have_packet_socket=yes
 LIBNET_LICENSE = BSD-2c, BSD-3c
 LIBNET_LICENSE_FILES = doc/COPYING
 
+
 $(eval $(autotools-package))
Signature · 1 line
1.8.3.1
#2 lore raw

PATCH 2/2 libnet: PF_PACKET is always available on Linux

Quoted 10 lines · Joris Lijssens
Signed-off-by Joris Lijssens <[email protected]>
---
 package/libnet/libnet.mk | 3 +++
 1 file changed, 3 insertions(+)
package/libnet/libnet.mk +0 -0
index 3b62a79..1a5e610 100644

package/libnet/libnet.mk line 15

Quoted 9 lines
package/libnet/libnet.mk +3 -0
@@ -7,7 +7,10 @@
 LIBNET_VERSION = 1.1.6
 LIBNET_SITE = http://sourceforge.net/projects/libnet-dev/files
 LIBNET_INSTALL_STAGING = YES
+# PF_PACKET is always available on Linux
+LIBNET_CONF_OPTS = libnet_cv_have_packet_socket=yes
 LIBNET_LICENSE = BSD-2c, BSD-3c
 LIBNET_LICENSE_FILES = doc/COPYING
 
+

This change is unnessary, but that can be fixed up during commit. Otherwise:

Acked-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Quoted 2 lines
package/libnet/libnet.mk +0 -0
 $(eval $(autotools-package))
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#3 lore raw

PATCH 1/2 libnet: disable for musl toolchains

In reply to Joris Lijssens
Quoted 1 line · Joris Lijssens
Signed-off-by Joris Lijssens <[email protected]>
Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 22 lines
---
 package/libnet/Config.in | 5 +++++
 1 file changed, 5 insertions(+)
package/libnet/Config.in +5 -0
index 7186972..8a88128 100644
@@ -1,7 +1,12 @@
 config BR2_PACKAGE_LIBNET
 	bool "libnet"
+	# Build with musl fails due to header issues
+	depends on !BR2_TOOLCHAIN_USES_MUSL
 	help
 	  libnet provides a portable framework for low-level network
 	  packet construction.
 
 	  http://sourceforge.net/projects/libnet-dev
+
+comment "libnet needs a (e)glibc or uClibc toolchain"
+	depends on BR2_TOOLCHAIN_USES_MUSL
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#4 lore raw

PATCH 1/2 libnet: disable for musl toolchains

In reply to Joris Lijssens

Dear Joris Lijssens,

Quoted 4 lines · Joris Lijssens
Signed-off-by Joris Lijssens <[email protected]>
---
 package/libnet/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

Both patches applied to next, with the minor nit noticed by Arnout on the second patch fixed.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com