scsi: aic7xxx: avoid checkpatch error
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 scsi: aic7xxx: avoid checkpatch error
ERROR: do not initialise statics to NULL
Signed-off-by Ran Sun <[email protected]>
--- drivers/scsi/aic7xxx/aic7xxx_osm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/aic7xxx/aic7xxx_osm.c +2 -2
@@ -124,7 +124,7 @@#include "aic7xxx_inline.h" #include <scsi/scsicam.h> -static struct scsi_transport_template *ahc_linux_transport_template =NULL ; +static struct scsi_transport_template *ahc_linux_transport_template;#include <linux/init.h> /* __setup */ #include <linux/mm.h> /* For fetching system memory size */
@@ -325,7 +325,7 @@ static uint32_t aic7xxx_periodic_otag;/* * Module information and settable options. */ -static char *aic7xxx =NULL ; +static char *aic7xxx;MODULE_AUTHOR ("Maintainer: Hannes Reinecke <[email protected]>" ); MODULE_DESCRIPTION("Adaptec AIC77XX/78XX SCSI Host Bus Adapter
driver");
Quoted 1 line · On Thu, 2023-07-20 at 17:57 +0800, [email protected] wrote:
ERROR: do not initialise statics to NULL
We don't accept checkpatch fixes on drivers, particularly not old ones. The reason is very simple: checkpatch keeps updating, so they would cause endless churn and a vastly increased risk of introducing bugs into older drivers. Checkpatch.pl as the name implies is for checking patches only.
James