scsi_debug: fix prevent_allow+verify regressions
Subsystems (2)
PATCH RESEND 1/1 scsi_debug: fix prevent_allow+verify regressions
Ruediger Meier observed a regression with the PREVENT ALLOW MEDIUM REMOVAL command in lk 3.19:
http://www.spinics.net/lists/util-linux-ng/msg11448.html
Inspection indicated the same regression with VERIFY(10).
The patch is against lk 3.19.3 and also works with lk 4.3.0 . With this patch both commands are accepted and do nothing.
ChangeLog:
- fix the lk 3.19 regression so that the PREVENT ALLOW MEDIUM REMOVAL command is supported once again
- same fix for VERIFY(10)
drivers/scsi/scsi_debug.c +5 -4
@@ -455,8 +455,9 @@ static const struct opcode_info_t opcode 0} }, {0 ,0 ,0 ,F_INV_OP |FF_RESPOND ,NULL ,NULL ,/* MAINT OUT */ {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} }, - {0, 0, 0, F_INV_OP | FF_RESPOND, NULL, NULL, /* VERIFY */ - {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} }, + {0, 0x2f, 0, F_D_OUT_MAYBE | FF_DIRECT_IO, NULL, NULL, /* VERIFY(10) */ + {10, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xc7, + 0, 0, 0, 0, 0, 0} }, {1, 0x7f, 0x9, F_SA_HIGH | F_D_IN | FF_DIRECT_IO, resp_read_dt0, vl_iarr, {32, 0xc7, 0, 0, 0, 0, 0x1f, 0x18, 0x0, 0x9, 0xfe, 0, 0xff, 0xff, 0xff, 0xff} },/* VARIABLE LENGTH, READ(32) */
@@ -467,8 +468,8 @@ static const struct opcode_info_t opcode {10 ,0x13 ,0xff ,0xff ,0 ,0 ,0 ,0xff ,0xff ,0xc7 ,0 ,0 ,0 ,0 ,0 , 0} },/* 20 */ - {0, 0, 0, F_INV_OP | FF_RESPOND, NULL, NULL, /* ALLOW REMOVAL */ - {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} }, + {0, 0x1e, 0, 0, NULL, NULL, /* ALLOW REMOVAL */ + {6, 0, 0, 0, 0x3, 0xc7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} }, {0, 0x1, 0, 0, resp_start_stop, NULL, /* REWIND ?? */ {6, 0x1, 0, 0, 0, 0xc7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} }, {0, 0, 0, F_INV_OP | FF_RESPOND, NULL, NULL, /* ATA_PT */
A message that is not in the archive (sent off-list or not yet received): 5651F740.3010707-qazKcTl6WRFWk0Htik3J/[email protected]
Hannes Reinecke
Reviewed-byQuoted 9 lines · Douglas Gilbert
Ruediger Meier observed a regression with the PREVENT ALLOW MEDIUM REMOVAL command in lk 3.19:
http://www.spinics.net/lists/util-linux-ng/msg11448.htmlInspection indicated the same regression with VERIFY(10).
The patch is against lk 3.19.3 and also works with lk 4.3.0 . With this patch both commands are accepted and do nothing.
Quoted 6 lines
ChangeLog:
- fix the lk 3.19 regression so that the PREVENT ALLOW MEDIUM REMOVAL command is supported once again
- same fix for VERIFY(10)
Cheers,
Hannes
Signature · 9 lines
Dr. Hannes Reinecke zSeries & Storage [email protected] +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 9 lines · Douglas Gilbert
Ruediger Meier observed a regression with the PREVENT ALLOW MEDIUM REMOVAL command in lk 3.19:
http://www.spinics.net/lists/util-linux-ng/msg11448.htmlInspection indicated the same regression with VERIFY(10).
The patch is against lk 3.19.3 and also works with lk 4.3.0 . With this patch both commands are accepted and do nothing.
Quoted 6 lines
ChangeLog:
- fix the lk 3.19 regression so that the PREVENT ALLOW MEDIUM REMOVAL command is supported once again
- same fix for VERIFY(10)Signed-off-by Douglas Gilbert <[email protected]>
Martin K. Petersen
AppliedQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Doug" == Douglas Gilbert <[email protected]> writes:
Doug> Ruediger Meier observed a regression with the PREVENT ALLOW MEDIUM Doug> REMOVAL command in lk 3.19:
Doug> http://www.spinics.net/lists/util-linux-ng/msg11448.html
Applied to 4.4.
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
A message that is not in the archive (sent off-list or not yet received): yq1k2p7kuvd.fsf-+q57XtR/[email protected]
Martin, sorry for offtopic, but can you pay a little attention to
http://www.spinics.net/lists/linux-scsi/msg81778.html ? It seems it wasn't applied.
Signature · 6 lines
With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): CAHp75VfpMdjmoipaJg7f4fR=6Mbyf1J_qmdoRm=zJ1ZWUW8EwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Andy" == Andy Shevchenko <[email protected]> writes:
Andy,
Andy> but can you pay a little attention to
Andy> http://www.spinics.net/lists/linux-scsi/msg81778.html ? It seems Andy> it wasn't applied.
Please resubmit to linux-scsi. We'll take a look.
Signature · 5 lines
Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): yq1fuztjymb.fsf-+q57XtR/[email protected]
Quoted 9 lines · Martin K. Petersen
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Andy" == Andy Shevchenko <[email protected]> writes:
Andy,
Andy> but can you pay a little attention to
Andy> http://www.spinics.net/lists/linux-scsi/msg81778.html ? It seems Andy> it wasn't applied.Please resubmit to linux-scsi. We'll take a look.
Done:
http://www.spinics.net/lists/linux-scsi/msg91207.html
Signature · 6 lines
With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html