ARM: shmobile: alt: Correct pfc
Subsystems (2)
cover ARM: shmobile: alt: Correct pfc
0c9400fab882 ("Merge branch 'heads/dt-for-v4.5' into next") introduced pfc pins to the alt device tree but did not reference them. This patch set addresses that and other deficiencies in that patch.
Written and tested against renesas-next-20151118-v4.4-rc1
Simon Horman (2):
ARM: shmobile: alt: Correct scif2 pfc
ARM: shmobile: alt: Correct ether pfc
arch/arm/boot/dts/r8a7794-alt.dts | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
Signature · 1 line
2.1.4
PATCH 1/2 ARM: shmobile: alt: Correct scif2 pfc
0c9400fab882 ("Merge branch 'heads/dt-for-v4.5' into next") introduced pfc pins to the alt device tree but did not reference them. This patch fixes scif2 pfc by adding references to the scif2 pins.
--- arch/arm/boot/dts/r8a7794-alt.dts | 3 +++ 1 file changed, 3 insertions(+)
arch/arm/boot/dts/r8a7794-alt.dts +3 -0
@@ -182,5 +182,8 @@ }; &scif2 { + pinctrl-0 = <&scif2_pins>; + pinctrl-names = "default"; + status = "okay"; };
Signature · 1 line
2.1.4
PATCH 1/2 ARM: shmobile: alt: Correct scif2 pfc
Hello.
Quoted 2 lines · Simon Horman
0c9400fab882("Merge branch 'heads/dt-for-v4.5' into next") introduced pfc pins to the alt device tree but did not reference them. This patch
Merge introduced? I thought there was a concrete commit doing that...
Quoted 4 lines
fixes scif2 pfc by adding references to the scif2 pins.
Reported-by Sergei Shtylyov <[email protected]>Signed-off-by Simon Horman <[email protected]>
[...]
MBR, Sergei
PATCH 1/2 ARM: shmobile: alt: Correct scif2 pfc
Quoted 8 lines · Sergei Shtylyov
Hello.
Quoted 2 lines · Simon Horman
0c9400fab882("Merge branch 'heads/dt-for-v4.5' into next") introduced pfc pins to the alt device tree but did not reference them. This patchMerge introduced? I thought there was a concrete commit doing that...
Indeed, I will fix that.
PATCH 2/2 ARM: shmobile: alt: Correct ether pfc
In reply to Simon Horman0c9400fab882 ("Merge branch 'heads/dt-for-v4.5' into next") introduced pfc pins to the alt device tree but did not reference them. This patch fixes ether pfc by:
* Referencing ether pins
* Adding and referencing phy1 pins
* Removing ether b pins. These are not used in the configuration of the alt board used for testing and their presence prevents ethernet from functioning correctly in that environment.
--- arch/arm/boot/dts/r8a7794-alt.dts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
arch/arm/boot/dts/r8a7794-alt.dts +6 -3
@@ -111,9 +111,9 @@ renesas,function = "eth"; }; - ether_b_pins: ether { - renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b"; - renesas,function = "eth"; + phy1_pins: phy1 { + renesas,groups = "intc_irq8"; + renesas,function = "intc"; }; i2c1_pins: i2c1 {
@@ -132,6 +132,9 @@ }; ðer { + pinctrl-0 = <ðer_pins &phy1_pins>; + pinctrl-names = "default"; + phy-handle = <&phy1>; renesas,ether-link-active-low; status = "okay";
Signature · 1 line
2.1.4
PATCH 2/2 ARM: shmobile: alt: Correct ether pfc
Hello.
Quoted 2 lines · Simon Horman
0c9400fab882("Merge branch 'heads/dt-for-v4.5' into next") introduced pfc pins to the alt device tree but did not reference them. This patch
Merge introduced?
Quoted 10 lines
fixes ether pfc by:
* Referencing ether pins
* Adding and referencing phy1 pins
* Removing ether b pins. These are not used in the configuration of the alt board used for testing and their presence prevents ethernet from functioning correctly in that environment.Reported-by Sergei Shtylyov <[email protected]>Signed-off-by Simon Horman <[email protected]>
[...]
MBR, Sergei