PCIe regression with DRA7xx in 4.4-rc1

DISCUSSION Kishon Vijay Abraham I 3 participants 5 messages Nov 24, 2015 PCI

lore

Share & tools

lore

Kishon Vijay Abraham I

author

2015-11-24 12:01 UTC #0 lore raw

Hi,

I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI:
designware: Make driver arch-agnostic").

Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that I observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O error, err_mask=0x4)"

Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine but when I give ifconfig up, it fails.

If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe cards starts to work fine again

Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine. Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now.

Actually I'm not able to find any obvious problems with the patch and the irq number and the memory resource also looks fine. Any idea what could be the problem?

[1] -> http://pastebin.ubuntu.com/13491456/
[2] -> http://pastebin.ubuntu.com/13491526/

[3] -> http://pastebin.ubuntu.com/13491658/
[4] -> http://pastebin.ubuntu.com/13491593/

Thanks
Kishon

Gabriele Paoloni

2015-11-24 12:08 UTC #1 lore raw

Hi Kishon

Quoted 12 lines

-----Original Message-----
From: Kishon Vijay Abraham I [mailto:kishon at ti.com]
Sent: 24 November 2015 12:01
To: linux-pci at vger.kernel.org; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; james.morse at arm.com; gabriel.fernandez at st.com; Minghuan.Lian at freescale.com; Wangzhou (B); Gabriele Paoloni; arnd at arndb.de; bhelgaas at google.com; pratyush.anand at gmail.com; Nori, Sekhar; jingoohan1 at gmail.com; linux-arm-kernel at lists.infradead.org
Subject: PCIe regression with DRA7xx in 4.4-rc1
Hi,

Quoted 8 lines

I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI:
designware: Make driver arch-agnostic").
Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that I
observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O error, err_mask=0x4)"

May this be related to the bug flagged in:

[PATCH] PCI: designware: remove wrong io_base assignment

[...]

drivers/pci/host/pcie-designware.c +0 -1

index 540f077c37ea..02a7452bdf23 100644
@@ -440,7 +440,6 @@ int dw_pcie_host_init(struct pcie_port *pp)
 					 ret, pp->io);
 				continue;
 			}
-			pp->io_base = pp->io->start;
 			break;
 		case IORESOURCE_MEM:
 			pp->mem = win->res;

Signature · 8 lines

1.7.9.5
[...]

Can you try to see if applying the patch above solves the issue?

Thanks

Gab

Quoted 21 lines

Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine but when I give ifconfig up, it fails.
If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe cards starts to work fine again
Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine. Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now.
Actually I'm not able to find any obvious problems with the patch and the irq number and the memory resource also looks fine. Any idea what could be the problem?
[1] -> http://pastebin.ubuntu.com/13491456/
[2] -> http://pastebin.ubuntu.com/13491526/
[3] -> http://pastebin.ubuntu.com/13491658/
[4] -> http://pastebin.ubuntu.com/13491593/
Thanks
Kishon

Kishon Vijay Abraham I

author

2015-11-24 12:18 UTC #2 lore raw

Hi,

Quoted 34 lines · Gabriele Paoloni

Hi Kishon
Quoted 12 lines
-----Original Message-----
From: Kishon Vijay Abraham I [mailto:kishon at ti.com]
Sent: 24 November 2015 12:01
To: linux-pci at vger.kernel.org; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; james.morse at arm.com; gabriel.fernandez at st.com; Minghuan.Lian at freescale.com; Wangzhou (B); Gabriele Paoloni; arnd at arndb.de; bhelgaas at google.com; pratyush.anand at gmail.com; Nori, Sekhar; jingoohan1 at gmail.com; linux-arm-kernel at lists.infradead.org
Subject: PCIe regression with DRA7xx in 4.4-rc1
Hi,
Quoted 8 lines
I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI:
designware: Make driver arch-agnostic").
Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that I
observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O error, err_mask=0x4)"
May this be related to the bug flagged in:
[PATCH] PCI: designware: remove wrong io_base assignment
[...]
drivers/pci/host/pcie-designware.c +0 -0
index 540f077c37ea..02a7452bdf23 100644

drivers/pci/host/pcie-designware.c int dw_pcie_host_init(struct pcie_port *pp) · line 445

Quoted 7 lines

drivers/pci/host/pcie-designware.c +0 -1

@@ -440,7 +440,6 @@ int dw_pcie_host_init(struct pcie_port *pp)
 					 ret, pp->io);
 				continue;
 			}
-			pp->io_base = pp->io->start;
 			break;
 		case IORESOURCE_MEM:
 			pp->mem = win->res;

yes, this indeed solved the bug.

Thanks
Kishon

Jisheng Zhang

2015-11-24 12:14 UTC #3 lore raw

In reply to Kishon Vijay Abraham I

Quoted 9 lines · On Tue, 24 Nov 2015 17:31:07 +0530 Kishon Vijay Abraham I wrote:

Hi,
I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI:
designware: Make driver arch-agnostic").
Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that I observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O error, err_mask=0x4)"

Quoted 5 lines

Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine but when I give ifconfig up, it fails.
If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe cards starts to work fine again

FYI, maybe the patch can fix the regression.
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/387362.html

Quoted 20 lines

Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine. Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now.
Actually I'm not able to find any obvious problems with the patch and the irq number and the memory resource also looks fine. Any idea what could be the problem?
[1] -> http://pastebin.ubuntu.com/13491456/
[2] -> http://pastebin.ubuntu.com/13491526/
[3] -> http://pastebin.ubuntu.com/13491658/
[4] -> http://pastebin.ubuntu.com/13491593/
Thanks
Kishon
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Kishon Vijay Abraham I

author

2015-11-24 12:59 UTC #4 lore raw

Hi,

Quoted 14 lines · Jisheng Zhang

Quoted 9 lines · On Tue, 24 Nov 2015 17:31:07 +0530 Kishon Vijay Abraham I wrote:
Hi,
I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI:
designware: Make driver arch-agnostic").
Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that I observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O error, err_mask=0x4)"

Quoted 8 lines

Quoted 5 lines
Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine but when I give ifconfig up, it fails.
If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe cards starts to work fine again
FYI, maybe the patch can fix the regression.
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/387362.html

yes, it fixed.

Thanks
Kishon

Quoted 22 lines

Quoted 21 lines
Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine. Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now.
Actually I'm not able to find any obvious problems with the patch and the irq number and the memory resource also looks fine. Any idea what could be the problem?
[1] -> http://pastebin.ubuntu.com/13491456/
[2] -> http://pastebin.ubuntu.com/13491526/
[3] -> http://pastebin.ubuntu.com/13491658/
[4] -> http://pastebin.ubuntu.com/13491593/
Thanks
Kishon
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel