Skip to contentSkip to conversation

minizip: new package

PATCH Superseded gustavo.zacarias at free-electrons.com 2 participants 3 messages Nov 23, 2015 – Nov 24, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 minizip: new package

From: Gustavo Zacarias <[email protected]>

---
 package/Config.in          |  1 +
 package/minizip/Config.in  | 15 +++++++++++++++
 package/minizip/minizip.mk | 17 +++++++++++++++++
 3 files changed, 33 insertions(+)
 create mode 100644 package/minizip/Config.in
 create mode 100644 package/minizip/minizip.mk
package/Config.in +1 -0
index f9af31c..d6d5505 100644
@@ -746,6 +746,7 @@ menu "Compression and decompression"
 	source "package/libsquish/Config.in"
 	source "package/libzip/Config.in"
 	source "package/lzo/Config.in"
+	source "package/minizip/Config.in"
 	source "package/snappy/Config.in"
 	source "package/szip/Config.in"
 	source "package/zlib/Config.in"
package/minizip/Config.in new file +15 -0
new file mode 100644
index 0000000..7205e00
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_MINIZIP
+	bool "minizip"
+	select BR2_PACKAGE_ZLIB
+	help
+	  Enables to extract files from a .zip archive file.
+	  It is compatible with PKZip 2.04g, WinZip, InfoZip,
+	  MimarSinan Codex Suite 2002 tools, and compatible sofware.
+
+	  https://github.com/nmoinvaz/minizip
+
+config BR2_PACKAGE_MINIZIP_DEMOS
+	bool "miniunzip/minizip"
+	depends on BR2_PACKAGE_MINIZIP
+	help
+	  Enable miniunzip/minizip binary tools.
package/minizip/minizip.mk new file +17 -0
new file mode 100644
index 0000000..aa77c56
@@ -0,0 +1,17 @@
+################################################################################
+#
+# minizip
+#
+################################################################################
+
+MINIZIP_VERSION = 977afb22966e6ab0ee401293a8e85fe808133f9a
+MINIZIP_SITE = https://github.com/nmoinvaz/minizip.git
+MINIZIP_SITE_METHOD = git
+MINIZIP_DEPENDENCIES = zlib
+MINIZIP_AUTORECONF = YES
+MINIZIP_INSTALL_STAGING = YES
+MINIZIP_CONF_OPTS = $(if $(BR2_PACKAGE_MINIZIP_DEMOS),--enable-demos)
+MINIZIP_LICENSE = zlib license
+MINIZIP_LICENSE_FILES = LICENSE
+
+$(eval $(autotools-package))
Signature · 1 line
2.4.10
#1 lore raw

PATCH 1/1 minizip: new package

Dear Gustavo Zacarias,

On 23/11/15 22:06, gustavo.zacarias at free-electrons.com wrote:

[snip]

Quoted 8 lines
package/minizip/Config.in new file +2 -0
new file mode 100644
index 0000000..7205e00
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_MINIZIP
+	bool "minizip"

package/minizip/Config.in line 12

Quoted 10 lines
package/minizip/Config.in new file +10 -0
+	select BR2_PACKAGE_ZLIB
+	help
+	  Enables to extract files from a .zip archive file.
+	  It is compatible with PKZip 2.04g, WinZip, InfoZip,
+	  MimarSinan Codex Suite 2002 tools, and compatible sofware.
+
+	  https://github.com/nmoinvaz/minizip
+
+config BR2_PACKAGE_MINIZIP_DEMOS
+	bool "miniunzip/minizip"

Personally I would write something more obvious like "Install tools".

Quoted 9 lines
package/minizip/Config.in new file +3 -0
+	depends on BR2_PACKAGE_MINIZIP
+	help
+	  Enable miniunzip/minizip binary tools.
package/minizip/minizip.mk new file +0 -0
new file mode 100644
index 0000000..aa77c56

package/minizip/minizip.mk line 8

Quoted 8 lines
package/minizip/minizip.mk new file +8 -0
@@ -0,0 +1,17 @@
+################################################################################
+#
+# minizip
+#
+################################################################################
+
+MINIZIP_VERSION = 977afb22966e6ab0ee401293a8e85fe808133f9a
+MINIZIP_SITE = https://github.com/nmoinvaz/minizip.git

Why not using the github helper?

MINIZIP_SITE = $(call github,nmoinvaz,minizip,$(MINIZIP_VERSION))

package/minizip/minizip.mk line 9

Quoted 1 line
package/minizip/minizip.mk new file +1 -0
+MINIZIP_SITE_METHOD = git

Not needed if you use the github helper, although I'm sure you already know that.

package/minizip/minizip.mk line 17

Quoted 9 lines
package/minizip/minizip.mk new file +8 -0
+MINIZIP_DEPENDENCIES = zlib
+MINIZIP_AUTORECONF = YES
+MINIZIP_INSTALL_STAGING = YES
+MINIZIP_CONF_OPTS = $(if $(BR2_PACKAGE_MINIZIP_DEMOS),--enable-demos)
+MINIZIP_LICENSE = zlib license
+MINIZIP_LICENSE_FILES = LICENSE
+
+$(eval $(autotools-package))

And you forgot to add a hash file like this:

# Locally calculated
sha256 b39158bdf3d8bf81d3a7412dc761851fda398bc93d8989d5e940ed4ae5bbb52c
minizip-977afb22966e6ab0ee401293a8e85fe808133f9a.tar.gz

Regards,

Vincent.

#2 lore raw

PATCH 1/1 minizip: new package

Quoted 4 lines · Vicente Olivert Riera

package/minizip/Config.in line 12

Quoted 2 lines
package/minizip/Config.in new file +2 -0
+config BR2_PACKAGE_MINIZIP_DEMOS
+	bool "miniunzip/minizip"

Personally I would write something more obvious like "Install tools".

Hi.
Well, "install tools" doesn't say much, saying what's installed if it fits is much more useful.
Besides these aren't tools, they're demos, that's why the config symbol is called so.
For a fully-fledged zip/unzip implementation infozip fits the bill more nicely, if you want a lib then this is it.
The rest addressed in v2.
Regards.