drm/i915/trace: Describe engines as class:instance pairs

From: Tvrtko Ursulin <[email protected]>

In the string tracepoint representation we ended up with the engine sandwiched between context hardware id and context fence id.

Move the two pieces of context data together and consolidate for redability using the format of ctx=hw_id:fence_context_id.

Quoting Tvrtko Ursulin (2018-05-24 16:04:47)

Quoted 7 lines

From: Tvrtko Ursulin <[email protected]>

In the string tracepoint representation we ended up with the engine sandwiched between context hardware id and context fence id.

Move the two pieces of context data together and consolidate for redability using the format of ctx=hw_id:fence_context_id.

Grr, bring backs my memory of ctx being the most important!

In order of segregation, I think of it as device+context as being the outer container (a user isn't meant to escape their context). The timelines and engines they use are all contained within their context.

But what we call ctx here isn't really context, but timeline; how about if we switch to the fence=%llx:%d representation we've mostly settled on for the debug messages?

Quoted 3 lines

But what we call ctx here isn't really context, but timeline; how about if we switch to the fence=%llx:%d representation we've mostly settled on for the debug messages?

For the ctx and seqno pair? But here we have the additional issue of hw_id. I think context is better than timeline at this level.

Or you mean keep explicit hw_id and join ctx and seqno into fence=%llx:%d?

Quoting Tvrtko Ursulin (2018-05-24 16:48:45)

Quoted 9 lines · Chris Wilson

Quoted 3 lines

But what we call ctx here isn't really context, but timeline; how about if we switch to the fence=%llx:%d representation we've mostly settled on for the debug messages?

For the ctx and seqno pair? But here we have the additional issue of hw_id. I think context is better than timeline at this level.

Quoted 1 line

Or you mean keep explicit hw_id and join ctx and seqno into fence=%llx:%d?

Right. I think what we call ctx here is very confusing, as it's just the fence.context (i.e timeline id) and not any of the ids we assign to the context (neither hw_id or uabi_id), so I don't think ctx refers to i915_gem_context/intel_context at all and so would rather stop using 'ctx'.

Quoted 10 lines

Quoting Tvrtko Ursulin (2018-05-24 16:48:45)

Quoted 9 lines · Chris Wilson

Quoted 3 lines

But what we call ctx here isn't really context, but timeline; how about if we switch to the fence=%llx:%d representation we've mostly settled on for the debug messages?

For the ctx and seqno pair? But here we have the additional issue of hw_id. I think context is better than timeline at this level.

Quoted 7 lines

Quoted 1 line

Or you mean keep explicit hw_id and join ctx and seqno into fence=%llx:%d?

Right. I think what we call ctx here is very confusing, as it's just the fence.context (i.e timeline id) and not any of the ids we assign to the context (neither hw_id or uabi_id), so I don't think ctx refers to i915_gem_context/intel_context at all and so would rather stop using 'ctx'.

I couldn't make myself re-order ctx and engine, since I did not find the solution for the resulting ctx and seqno split. And I did not like the fence=%llu:%u for tracepoints. Just can't think of requests as fences.

Wrt hw_id and dev moving to u16, both fields theoretically can be wider so I did not do that either.

From: Tvrtko Ursulin <[email protected]>

In the string tracepoint representation we ended up with the engine sandwiched between context hardware id and context fence id.

Move the two pieces of context data together and consolidate for redability using the format of ctx=hw_id:fence_context_id.

Binary records are left as is, that is both fields remaing under the existing name and ordering.

Signed-off-by Tvrtko Ursulin <[email protected]>

Cc Lionel Landwerlin <[email protected]>

---
  drivers/gpu/drm/i915/i915_trace.h | 30 +++++++++++++++---------------
  1 file changed, 15 insertions(+), 15 deletions(-)

drivers/gpu/drm/i915/i915_trace.h +12 -12

index 3465cc1f9345..ab67b1661de4 100644
@@ -638,9 +638,9 @@ TRACE_EVENT(i915_request_queue,
  			   __entry->flags = flags;
  			   ),
 
-	    TP_printk("dev=%u, hw_id=%u, engine=%u:%u, ctx=%u, seqno=%u, flags=0x%x",
-		      __entry->dev, __entry->hw_id, __entry->class,
-		      __entry->instance, __entry->ctx, __entry->seqno,
+	    TP_printk("dev=%u, engine=%u:%u, ctx=%u:%u, seqno=%u, flags=0x%x",
+		      __entry->dev, __entry->class, __entry->instance,
+	              __entry->hw_id, __entry->ctx, __entry->seqno,
  		      __entry->flags)
  );
 

@@ -668,9 +668,9 @@ DECLARE_EVENT_CLASS(i915_request,
  			   __entry->global = rq->global_seqno;
  			   ),
 
-	    TP_printk("dev=%u, hw_id=%u, engine=%u:%u, ctx=%u, seqno=%u, global=%u",
-		      __entry->dev, __entry->hw_id, __entry->class,
-		      __entry->instance, __entry->ctx, __entry->seqno,
+	    TP_printk("dev=%u, engine=%u:%u, ctx=%u:%u, seqno=%u, global=%u",
+		      __entry->dev, __entry->class, __entry->instance,
+		      __entry->hw_id, __entry->ctx, __entry->seqno,
  		      __entry->global)
  );
 

@@ -718,9 +718,9 @@ TRACE_EVENT(i915_request_in,
  			   __entry->port = port;
  			   ),
 
-	    TP_printk("dev=%u, hw_id=%u, engine=%u:%u, ctx=%u, seqno=%u, prio=%u, global=%u, port=%u",
-		      __entry->dev, __entry->hw_id, __entry->class,
-		      __entry->instance, __entry->ctx, __entry->seqno,
+	    TP_printk("dev=%u, engine=%u:%u, ctx=%u:%u, seqno=%u, prio=%u, global=%u, port=%u",
+		      __entry->dev, __entry->class, __entry->instance,
+		      __entry->hw_id, __entry->ctx, __entry->seqno,
  		      __entry->prio, __entry->global_seqno, __entry->port)
  );
 

@@ -750,9 +750,9 @@ TRACE_EVENT(i915_request_out,
  			   __entry->completed = i915_request_completed(rq);
  			   ),
 
-		    TP_printk("dev=%u, hw_id=%u, engine=%u:%u, ctx=%u, seqno=%u, global=%u, completed?=%u",
-			      __entry->dev, __entry->hw_id, __entry->class,
-			      __entry->instance, __entry->ctx, __entry->seqno,
+		    TP_printk("dev=%u, engine=%u:%u, ctx=%u:%u, seqno=%u, global=%u, completed?=%u",
+			      __entry->dev, __entry->class, __entry->instance,
+			      __entry->hw_id, __entry->ctx, __entry->seqno,
  			      __entry->global_seqno, __entry->completed)
  );
 

@@ -842,9 +842,9 @@ TRACE_EVENT(i915_request_wait_begin,
  			   __entry->flags = flags;
  			   ),

Quoted 7 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

In the string tracepoint representation we ended up with the engine sandwiched between context hardware id and context fence id.

Move the two pieces of context data together and consolidate for redability using the format of ctx=hw_id:fence_context_id.

Arg! Will need to update the tracepoint parser in igt :(

Quoted 78 lines

Binary records are left as is, that is both fields remaing under the existing name and ordering.

Signed-off-by Tvrtko Ursulin <[email protected]>

Cc Lionel Landwerlin <[email protected]>

---
  drivers/gpu/drm/i915/i915_trace.h | 30 +++++++++++++++---------------

  1 file changed, 15 insertions(+), 15 deletions(-)

drivers/gpu/drm/i915/i915_trace.h +15 -15

index 3465cc1f9345..ab67b1661de4 100644
@@ -638,9 +638,9 @@ TRACE_EVENT(i915_request_queue,
                  __entry->flags = flags;
                  ),
-        TP_printk("dev=%u, hw_id=%u, engine=%u:%u, ctx=%u, seqno=%u, 
 flags=0x%x",
-              __entry->dev, __entry->hw_id, __entry->class,
-              __entry->instance, __entry->ctx, __entry->seqno,
+        TP_printk("dev=%u, engine=%u:%u, ctx=%u:%u, seqno=%u, 
 flags=0x%x",
+              __entry->dev, __entry->class, __entry->instance,
+                  __entry->hw_id, __entry->ctx, __entry->seqno,
                 __entry->flags)
   );

@@ -668,9 +668,9 @@ DECLARE_EVENT_CLASS(i915_request,
                  __entry->global = rq->global_seqno;
                  ),
-        TP_printk("dev=%u, hw_id=%u, engine=%u:%u, ctx=%u, seqno=%u, 
 global=%u",
-              __entry->dev, __entry->hw_id, __entry->class,
-              __entry->instance, __entry->ctx, __entry->seqno,
+        TP_printk("dev=%u, engine=%u:%u, ctx=%u:%u, seqno=%u, 
 global=%u",
+              __entry->dev, __entry->class, __entry->instance,
+              __entry->hw_id, __entry->ctx, __entry->seqno,
                 __entry->global)
   );

@@ -718,9 +718,9 @@ TRACE_EVENT(i915_request_in,
                  __entry->port = port;
                  ),
-        TP_printk("dev=%u, hw_id=%u, engine=%u:%u, ctx=%u, seqno=%u, 
 prio=%u, global=%u, port=%u",
-              __entry->dev, __entry->hw_id, __entry->class,
-              __entry->instance, __entry->ctx, __entry->seqno,
+        TP_printk("dev=%u, engine=%u:%u, ctx=%u:%u, seqno=%u, 
 prio=%u, global=%u, port=%u",
+              __entry->dev, __entry->class, __entry->instance,
+              __entry->hw_id, __entry->ctx, __entry->seqno,
                 __entry->prio, __entry->global_seqno, __entry->port)
   );

@@ -750,9 +750,9 @@ TRACE_EVENT(i915_request_out,
                  __entry->completed = i915_request_completed(rq);
                  ),
-            TP_printk("dev=%u, hw_id=%u, engine=%u:%u, ctx=%u, 
 seqno=%u, global=%u, completed?=%u",
-                  __entry->dev, __entry->hw_id, __entry->class,
-                  __entry->instance, __entry->ctx, __entry->seqno,
+            TP_printk("dev=%u, engine=%u:%u, ctx=%u:%u, seqno=%u, 
 global=%u, completed?=%u",
+                  __entry->dev, __entry->class, __entry->instance,
+                  __entry->hw_id, __entry->ctx, __entry->seqno,
                     __entry->global_seqno, __entry->completed)
   );

@@ -842,9 +842,9 @@ TRACE_EVENT(i915_request_wait_begin,
                  __entry->flags = flags;
                  ),
-        TP_printk("dev=%u, hw_id=%u, engine=%u:%u, ctx=%u, seqno=%u, 
 global=%u, blocking=%u, flags=0x%x",
-              __entry->dev, __entry->hw_id, __entry->class,
-              __entry->instance, __entry->ctx, __entry->seqno,
+        TP_printk("dev=%u, engine=%u:%u, ctx=%u:%u, seqno=%u, 
 global=%u, blocking=%u, flags=0x%x",
+              __entry->dev, __entry->class, __entry->instance,
+              __entry->hw_id, __entry->ctx, __entry->seqno,
                 __entry->global, !!(__entry->flags & I915_WAIT_LOCKED),

Quoted 2 lines

drivers/gpu/drm/i915/i915_trace.h +0 -0

                 __entry->flags)

  );

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

From: Tvrtko Ursulin <[email protected]>

Instead of using the engine->id, use uabi_class:instance pairs in trace- points including engine info.

This will be more readable, more future proof and more stable for userspace consumption.

Signed-off-by Tvrtko Ursulin <[email protected]>

Cc Chris Wilson <[email protected]>

Cc [email protected]

---

Quoting Tvrtko Ursulin (2018-05-24 16:04:46)

Quoted 4 lines

From: Tvrtko Ursulin <[email protected]>

Instead of using the engine->id, use uabi_class:instance pairs in trace- points including engine info.

Should we not pack dev,hw_id,class,instance into u16s?

Quoted 8 lines

This will be more readable, more future proof and more stable for userspace consumption.

Signed-off-by Tvrtko Ursulin <[email protected]>

Cc Chris Wilson <[email protected]>

Cc [email protected]

---

drivers/gpu/drm/i915/i915_trace.h TRACE_EVENT(i915_request_queue, · line 626

Quoted 7 lines

drivers/gpu/drm/i915/i915_trace.h +2 -1

@@ -616,7 +621,8 @@ TRACE_EVENT(i915_request_queue,
             TP_STRUCT__entry(
                              __field(u32, dev)
                              __field(u32, hw_id)
-                            __field(u32, ring)
+                            __field(u32, class)
+                            __field(u32, instance)
                              __field(u32, ctx)

ctx needs u64 :(
I've no objection to switching to our hopefully futureproof uabi nomenclature.

Reviewed-by Chris Wilson <[email protected]>

From: Tvrtko Ursulin <[email protected]>

Instead of using the engine->id, use uabi_class:instance pairs in trace- points including engine info.

This will be more readable, more future proof and more stable for userspace consumption.

Signed-off-by Tvrtko Ursulin <[email protected]>

Cc Chris Wilson <[email protected]>

Cc [email protected]

---
  drivers/gpu/drm/i915/i915_trace.h | 107 ++++++++++++++++++------------
  1 file changed, 65 insertions(+), 42 deletions(-)

drivers/gpu/drm/i915/i915_trace.h +62 -40

index 5d4f78765083..3465cc1f9345 100644
@@ -591,21 +591,26 @@ TRACE_EVENT(i915_gem_ring_sync_to,
 
  	    TP_STRUCT__entry(
  			     __field(u32, dev)
-			     __field(u32, sync_from)
-			     __field(u32, sync_to)
+			     __field(u32, from_class)
+			     __field(u32, from_instance)
+			     __field(u32, to_class)
+			     __field(u32, to_instance)
  			     __field(u32, seqno)
  			     ),
 
  	    TP_fast_assign(
  			   __entry->dev = from->i915->drm.primary->index;
-			   __entry->sync_from = from->engine->id;
-			   __entry->sync_to = to->engine->id;
+			   __entry->from_class = from->engine->uabi_class;
+			   __entry->from_instance = from->engine->instance;
+			   __entry->to_class = to->engine->uabi_class;
+			   __entry->to_instance = to->engine->instance;
  			   __entry->seqno = from->global_seqno;
  			   ),
 
-	    TP_printk("dev=%u, sync-from=%u, sync-to=%u, seqno=%u",
+	    TP_printk("dev=%u, sync-from=%u:%u, sync-to=%u:%u, seqno=%u",
  		      __entry->dev,
-		      __entry->sync_from, __entry->sync_to,
+		      __entry->from_class, __entry->from_instance,
+		      __entry->to_class, __entry->to_instance,
  		      __entry->seqno)
  );
 

@@ -616,7 +621,8 @@ TRACE_EVENT(i915_request_queue,
  	    TP_STRUCT__entry(
  			     __field(u32, dev)
  			     __field(u32, hw_id)
-			     __field(u32, ring)
+			     __field(u32, class)
+			     __field(u32, instance)
  			     __field(u32, ctx)
  			     __field(u32, seqno)
  			     __field(u32, flags)

@@ -625,15 +631,17 @@ TRACE_EVENT(i915_request_queue,
  	    TP_fast_assign(
  			   __entry->dev = rq->i915->drm.primary->index;
  			   __entry->hw_id = rq->gem_context->hw_id;
-			   __entry->ring = rq->engine->id;
+			   __entry->class = rq->engine->uabi_class;
+			   __entry->instance = rq->engine->instance;
  			   __entry->ctx = rq->fence.context;
  			   __entry->seqno = rq->fence.seqno;
  			   __entry->flags = flags;
  			   ),
 
-	    TP_printk("dev=%u, hw_id=%u, ring=%u, ctx=%u, seqno=%u, flags=0x%x",
-		      __entry->dev, __entry->hw_id, __entry->ring, __entry->ctx,
-		      __entry->seqno, __entry->flags)
+	    TP_printk("dev=%u, hw_id=%u, engine=%u:%u, ctx=%u, seqno=%u, flags=0x%x",
+		      __entry->dev, __entry->hw_id, __entry->class,
+		      __entry->instance, __entry->ctx, __entry->seqno,
+		      __entry->flags)
  );
 
  DECLARE_EVENT_CLASS(i915_request,

@@ -643,7 +651,8 @@ DECLARE_EVENT_CLASS(i915_request,
  	    TP_STRUCT__entry(
  			     __field(u32, dev)
  			     __field(u32, hw_id)
-			     __field(u32, ring)
+			     __field(u32, class)
+			     __field(u32, instance)
  			     __field(u32, ctx)
  			     __field(u32, seqno)
  			     __field(u32, global)

@@ -652,15 +661,17 @@ DECLARE_EVENT_CLASS(i915_request,
  	    TP_fast_assign(
  			   __entry->dev = rq->i915->drm.primary->index;
  			   __entry->hw_id = rq->gem_context->hw_id;
-			   __entry->ring = rq->engine->id;
+			   __entry->class = rq->engine->uabi_class;
+			   __entry->instance = rq->engine->instance;
  			   __entry->ctx = rq->fence.context;
  			   __entry->seqno = rq->fence.seqno;
  			   __entry->global = rq->global_seqno;
  			   ),
 
-	    TP_printk("dev=%u, hw_id=%u, ring=%u, ctx=%u, seqno=%u, global=%u",
-		      __entry->dev, __entry->hw_id, __entry->ring, __entry->ctx,
-		      __entry->seqno, __entry->global)
+	    TP_printk("dev=%u, hw_id=%u, engine=%u:%u, ctx=%u, seqno=%u, global=%u",
+		      __entry->dev, __entry->hw_id, __entry->class,
+		      __entry->instance, __entry->ctx, __entry->seqno,
+		      __entry->global)
  );
 
  DEFINE_EVENT(i915_request, i915_request_add,

@@ -686,7 +697,8 @@ TRACE_EVENT(i915_request_in,
  	    TP_STRUCT__entry(
  			     __field(u32, dev)
  			     __field(u32, hw_id)
-			     __field(u32, ring)
+			     __field(u32, class)
+			     __field(u32, instance)
  			     __field(u32, ctx)
  			     __field(u32, seqno)
  			     __field(u32, global_seqno)

@@ -697,7 +709,8 @@ TRACE_EVENT(i915_request_in,
  	    TP_fast_assign(
  			   __entry->dev = rq->i915->drm.primary->index;
  			   __entry->hw_id = rq->gem_context->hw_id;
-			   __entry->ring = rq->engine->id;
+			   __entry->class = rq->engine->uabi_class;
+			   __entry->instance = rq->engine->instance;
  			   __entry->ctx = rq->fence.context;
  			   __entry->seqno = rq->fence.seqno;
  			   __entry->global_seqno = rq->global_seqno;

@@ -705,10 +718,10 @@ TRACE_EVENT(i915_request_in,
  			   __entry->port = port;
  			   ),
 
-	    TP_printk("dev=%u, hw_id=%u, ring=%u, ctx=%u, seqno=%u, prio=%u, global=%u, port=%u",
-		      __entry->dev, __entry->hw_id, __entry->ring, __entry->ctx,
-		      __entry->seqno, __entry->prio, __entry->global_seqno,
-		      __entry->port)
+	    TP_printk("dev=%u, hw_id=%u, engine=%u:%u, ctx=%u, seqno=%u, prio=%u, global=%u, port=%u",
+		      __entry->dev, __entry->hw_id, __entry->class,
+		      __entry->instance, __entry->ctx, __entry->seqno,
+		      __entry->prio, __entry->global_seqno, __entry->port)
  );
 
  TRACE_EVENT(i915_request_out,

@@ -718,7 +731,8 @@ TRACE_EVENT(i915_request_out,
  	    TP_STRUCT__entry(
  			     __field(u32, dev)
  			     __field(u32, hw_id)
-			     __field(u32, ring)
+			     __field(u32, class)
+			     __field(u32, instance)
  			     __field(u32, ctx)
  			     __field(u32, seqno)
  			     __field(u32, global_seqno)

@@ -728,16 +742,17 @@ TRACE_EVENT(i915_request_out,
  	    TP_fast_assign(
  			   __entry->dev = rq->i915->drm.primary->index;
  			   __entry->hw_id = rq->gem_context->hw_id;
-			   __entry->ring = rq->engine->id;
+			   __entry->class = rq->engine->uabi_class;
+			   __entry->instance = rq->engine->instance;
  			   __entry->ctx = rq->fence.context;
  			   __entry->seqno = rq->fence.seqno;
  			   __entry->global_seqno = rq->global_seqno;
  			   __entry->completed = i915_request_completed(rq);
  			   ),
 
-		    TP_printk("dev=%u, hw_id=%u, ring=%u, ctx=%u, seqno=%u, global=%u, completed?=%u",
-			      __entry->dev, __entry->hw_id, __entry->ring,
-			      __entry->ctx, __entry->seqno,
+		    TP_printk("dev=%u, hw_id=%u, engine=%u:%u, ctx=%u, seqno=%u, global=%u, completed?=%u",
+			      __entry->dev, __entry->hw_id, __entry->class,
+			      __entry->instance, __entry->ctx, __entry->seqno,
  			      __entry->global_seqno, __entry->completed)
  );
 

@@ -771,21 +786,23 @@ TRACE_EVENT(intel_engine_notify,
 
  	    TP_STRUCT__entry(
  			     __field(u32, dev)
-			     __field(u32, ring)
+			     __field(u32, class)
+			     __field(u32, instance)
  			     __field(u32, seqno)
  			     __field(bool, waiters)
  			     ),
 
  	    TP_fast_assign(
  			   __entry->dev = engine->i915->drm.primary->index;
-			   __entry->ring = engine->id;
+			   __entry->class = engine->uabi_class;
+			   __entry->instance = engine->instance;
  			   __entry->seqno = intel_engine_get_seqno(engine);
  			   __entry->waiters = waiters;
  			   ),
 
-	    TP_printk("dev=%u, ring=%u, seqno=%u, waiters=%u",
-		      __entry->dev, __entry->ring, __entry->seqno,
-		      __entry->waiters)
+	    TP_printk("dev=%u, engine=%u:%u, seqno=%u, waiters=%u",
+		      __entry->dev, __entry->class, __entry->instance,
+		      __entry->seqno, __entry->waiters)
  );
 
  DEFINE_EVENT(i915_request, i915_request_retire,

@@ -800,7 +817,8 @@ TRACE_EVENT(i915_request_wait_begin,
  	    TP_STRUCT__entry(
  			     __field(u32, dev)
  			     __field(u32, hw_id)
-			     __field(u32, ring)
+			     __field(u32, class)
+			     __field(u32, instance)
  			     __field(u32, ctx)
  			     __field(u32, seqno)
  			     __field(u32, global)

@@ -816,17 +834,19 @@ TRACE_EVENT(i915_request_wait_begin,
  	    TP_fast_assign(
  			   __entry->dev = rq->i915->drm.primary->index;
  			   __entry->hw_id = rq->gem_context->hw_id;
-			   __entry->ring = rq->engine->id;
+			   __entry->class = rq->engine->uabi_class;
+			   __entry->instance = rq->engine->instance;
  			   __entry->ctx = rq->fence.context;
  			   __entry->seqno = rq->fence.seqno;
  			   __entry->global = rq->global_seqno;
  			   __entry->flags = flags;
  			   ),
 
-	    TP_printk("dev=%u, hw_id=%u, ring=%u, ctx=%u, seqno=%u, global=%u, blocking=%u, flags=0x%x",
-		      __entry->dev, __entry->hw_id, __entry->ring, __entry->ctx,
-		      __entry->seqno, __entry->global,
-		      !!(__entry->flags & I915_WAIT_LOCKED), __entry->flags)
+	    TP_printk("dev=%u, hw_id=%u, engine=%u:%u, ctx=%u, seqno=%u, global=%u, blocking=%u, flags=0x%x",
+		      __entry->dev, __entry->hw_id, __entry->class,
+		      __entry->instance, __entry->ctx, __entry->seqno,
+		      __entry->global, !!(__entry->flags & I915_WAIT_LOCKED),
+		      __entry->flags)
  );
 
  DEFINE_EVENT(i915_request, i915_request_wait_end,

@@ -966,21 +986,24 @@ TRACE_EVENT(switch_mm,
  	TP_ARGS(engine, to),
 
  	TP_STRUCT__entry(
-			__field(u32, ring)
+			__field(u32, class)
+			__field(u32, instance)
  			__field(struct i915_gem_context *, to)
  			__field(struct i915_address_space *, vm)
  			__field(u32, dev)
  	),
 
  	TP_fast_assign(
-			__entry->ring = engine->id;
+			__entry->class = engine->uabi_class;
+			__entry->instance = engine->instance;
  			__entry->to = to;
  			__entry->vm = to->ppgtt? &to->ppgtt->base : NULL;
  			__entry->dev = engine->i915->drm.primary->index;

Quoted 5 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Instead of using the engine->id, use uabi_class:instance pairs in trace- points including engine info.

Quoted 6 lines

This will be more readable, more future proof and more stable for userspace consumption.

Signed-off-by Tvrtko Ursulin <[email protected]>

Cc Chris Wilson <[email protected]>

Cc [email protected]

Don't you want engine->uabi_id instead of engine->instance ?

Quoted 9 lines · Lionel Landwerlin

Quoted 8 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Instead of using the engine->id, use uabi_class:instance pairs in trace- points including engine info.

This will be more readable, more future proof and more stable for userspace consumption.

Quoted 4 lines

Quoted 3 lines

Signed-off-by Tvrtko Ursulin <[email protected]>

Cc Chris Wilson <[email protected]>

Cc [email protected]

Don't you want engine->uabi_id instead of engine->instance ?

No, class:instance is the new engine identifier - why do you think we would need legacy engine->uabi_id?

Regards,

Tvrtko

Quoted 14 lines · Tvrtko Ursulin

Quoted 12 lines · Lionel Landwerlin

Quoted 11 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Instead of using the engine->id, use uabi_class:instance pairs in trace- points including engine info.

This will be more readable, more future proof and more stable for userspace consumption.

Signed-off-by Tvrtko Ursulin <[email protected]>

Cc Chris Wilson <[email protected]>

Cc [email protected]

Quoted 3 lines

Quoted 1 line

Don't you want engine->uabi_id instead of engine->instance ?

No, class:instance is the new engine identifier - why do you think we would need legacy engine->uabi_id?

Maybe I forgot about your engine listing series...
I would expect the tracepoint to match the engines listed through that uapi.

Quoted 21 lines · Tvrtko Ursulin

Quoted 19 lines · Lionel Landwerlin

Quoted 7 lines · Tvrtko Ursulin

Quoted 6 lines

From: Tvrtko Ursulin <[email protected]>

Instead of using the engine->id, use uabi_class:instance pairs in trace-
points including engine info.

Quoted 7 lines

Quoted 6 lines

This will be more readable, more future proof and more stable for userspace consumption.

Signed-off-by Tvrtko Ursulin <[email protected]>

Cc Chris Wilson <[email protected]>

Cc [email protected]

Don't you want engine->uabi_id instead of engine->instance ?

No, class:instance is the new engine identifier - why do you think we would need legacy engine->uabi_id?

Quoted 3 lines

Maybe I forgot about your engine listing series...
I would expect the tracepoint to match the engines listed through that uapi.

Yeah I don't have engine->uabi_id exported in engine discovery. I could add it, but given how we don't plan to extend it (the legacy engine selection), I think it is not needed. If there will be popular demand though can do it.