Skip to contentSkip to conversation

xen/x86: drop dependency of XEN_SHSTK on EXPERT

PATCH In review Juergen Gross 3 participants 3 messages Mar 9, 2022 – Mar 18, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/x86: drop dependency of XEN_SHSTK on EXPERT

XEN_SHSTK should be on per default now that it is supported officially. Only let the prompt depend on EXPERT.

---
 xen/arch/x86/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
xen/arch/x86/Kconfig +2 -2
index 83d0f317ec..c166db3499 100644
@@ -117,8 +117,8 @@ config HVM
 	  If unsure, say Y.
 
 config XEN_SHSTK
-	bool "Supervisor Shadow Stacks (EXPERT)"
-	depends on HAS_AS_CET_SS && EXPERT
+	bool "Supervisor Shadow Stacks" if EXPERT
+	depends on HAS_AS_CET_SS
 	default y
 	---help---
 	  Control-flow Enforcement Technology (CET) is a set of features in
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Juergen Gross

XEN_SHSTK should be on per default now that it is supported officially. Only let the prompt depend on EXPERT.

xen/arch/x86/Kconfig config HVM · line 121

Quoted 10 lines
xen/arch/x86/Kconfig +2 -2
@@ -117,8 +117,8 @@ config HVM
 	  If unsure, say Y.
 
 config XEN_SHSTK
-	bool "Supervisor Shadow Stacks (EXPERT)"
-	depends on HAS_AS_CET_SS && EXPERT
+	bool "Supervisor Shadow Stacks" if EXPERT
+	depends on HAS_AS_CET_SS

While I think it's better this way, if others thought the dependency should be dropped altogether, I wouldn't mind.

Jan

#2 lore raw
In reply to Juergen Gross
Quoted 13 lines · Juergen Gross

XEN_SHSTK should be on per default now that it is supported officially. Only let the prompt depend on EXPERT.

---
 xen/arch/x86/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
xen/arch/x86/Kconfig +0 -0
index 83d0f317ec..c166db3499 100644

xen/arch/x86/Kconfig config HVM · line 120

Quoted 6 lines
xen/arch/x86/Kconfig +1 -2
@@ -117,8 +117,8 @@ config HVM
 	  If unsure, say Y.
 
 config XEN_SHSTK
-	bool "Supervisor Shadow Stacks (EXPERT)"
-	depends on HAS_AS_CET_SS && EXPERT
+	bool "Supervisor Shadow Stacks" if EXPERT

It has previously been stated that anything hidden behind expert is not supported.  shstk is sure as hell supported when compiled off, because that's been the status quo so far.

It's also wrong for shstk to be handled differently to IBT.

Most importantly however, it is simply obstructive to have options like this hidden because the user can force them off by using an older compiler.

~Andrew