Skip to contentSkip to conversation

dm: core: Enable SPL_SIMPLE_BUS by default

PATCH New Michal Simek 3 participants 4 messages Dec 1, 2015

lore
Share & tools
lore

Michal Simek

author
#0 lore raw

PATCH 1/1 dm: core: Enable SPL_SIMPLE_BUS by default

This option is needed for all SoCs which have nodes on bus. Without enabling this drivers are not found and probed.
Issue was found on Zynq MMC probe.
Enable this option by default.

Signed-off-by Michal Simek <[email protected]>

---

 drivers/core/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/core/Kconfig +1 -1
index 15681df6d379..74eee1066092 100644
@@ -115,7 +115,7 @@ config SIMPLE_BUS
 config SPL_SIMPLE_BUS
 	bool "Support simple-bus driver in SPL"
 	depends on SPL_DM && SPL_OF_CONTROL
-	default n
+	default y
 	help
 	  Supports the 'simple-bus' driver, which is used on some systems
 	  in SPL.
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 dm: core: Enable SPL_SIMPLE_BUS by default

Hi Michal,

Quoted 16 lines · Michal Simek

This option is needed for all SoCs which have nodes on bus. Without enabling this drivers are not found and probed.
Issue was found on Zynq MMC probe.
Enable this option by default.

Signed-off-by Michal Simek <[email protected]>

---

  drivers/core/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/core/Kconfig +0 -0
index 15681df6d379..74eee1066092 100644

drivers/core/Kconfig config SIMPLE_BUS · line 121

Quoted 8 lines
drivers/core/Kconfig +1 -1
@@ -115,7 +115,7 @@ config SIMPLE_BUS
  config SPL_SIMPLE_BUS
  	bool "Support simple-bus driver in SPL"
  	depends on SPL_DM && SPL_OF_CONTROL
-	default n
+	default y
  	help
  	  Supports the 'simple-bus' driver, which is used on some systems
  	  in SPL.

I stumbled over this missing option while porting DM_SPL to mvebu as well. So:

Reviewed-by Stefan Roese <[email protected]>

Thanks,
Stefan

author
#2 lore raw

PATCH 1/1 dm: core: Enable SPL_SIMPLE_BUS by default

Quoted 31 lines · Stefan Roese

Hi Michal,

Quoted 16 lines · Michal Simek

This option is needed for all SoCs which have nodes on bus. Without enabling this drivers are not found and probed.
Issue was found on Zynq MMC probe.
Enable this option by default.

Signed-off-by Michal Simek <[email protected]>

---

  drivers/core/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/core/Kconfig +0 -0
index 15681df6d379..74eee1066092 100644

drivers/core/Kconfig config SIMPLE_BUS · line 121

Quoted 8 lines
drivers/core/Kconfig +1 -1
@@ -115,7 +115,7 @@ config SIMPLE_BUS
  config SPL_SIMPLE_BUS
      bool "Support simple-bus driver in SPL"
      depends on SPL_DM && SPL_OF_CONTROL
-    default n
+    default y
      help
        Supports the 'simple-bus' driver, which is used on some systems
        in SPL.

I stumbled over this missing option while porting DM_SPL to mvebu as well. So:

Quoted 1 line
Reviewed-by Stefan Roese <[email protected]>

yep. btw: I have added you to cc to one more email regarding SPL.

Thanks,
Michal

#3 lore raw

PATCH 1/1 dm: core: Enable SPL_SIMPLE_BUS by default

In reply to Michal Simek
Quoted 10 lines · Michal Simek

This option is needed for all SoCs which have nodes on bus. Without enabling this drivers are not found and probed.
Issue was found on Zynq MMC probe.
Enable this option by default.

Signed-off-by Michal Simek <[email protected]>

---

 drivers/core/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks.

Reviewed-by Simon Glass <[email protected]>