Re-enable setexpr on Raspberry Pi
PATCH 1/1 Re-enable setexpr on Raspberry Pi
This patch re-enables the setexpr command, I don't really understand why it got excluded in the first place.
setexpr can be used e.g. to implement failed-boot-counters and failovers to rescue firmware.
--- configs/rpi_2_defconfig | 1 - configs/rpi_defconfig | 1 - 2 files changed, 2 deletions(-)
configs/rpi_2_defconfig +0 -1
@@ -6,5 +6,4 @@ CONFIG_SYS_PROMPT="U-Boot> " # CONFIG_CMD_FLASH is not set # CONFIG_CMD_FPGA is not set CONFIG_CMD_GPIO=y -# CONFIG_CMD_SETEXPR is not set CONFIG_PHYS_TO_BUS=y
configs/rpi_defconfig +0 -1
@@ -6,5 +6,4 @@ CONFIG_SYS_PROMPT="U-Boot> " # CONFIG_CMD_FLASH is not set # CONFIG_CMD_FPGA is not set CONFIG_CMD_GPIO=y -# CONFIG_CMD_SETEXPR is not set CONFIG_PHYS_TO_BUS=y
--
2.6.2
PATCH 1/1 Re-enable setexpr on Raspberry Pi
Quoted 7 lines · Marco Schuster
This patch re-enables the setexpr command, I don't really understand why it got excluded in the first place.
setexpr can be used e.g. to implement failed-boot-counters and failovers to rescue firmware.
Two blank lines?
Quoted 1 line
Signed-off-by Marco Schuster <[email protected]>
This looks like a reasonable change, but
* You should CC the author of the patch that caused this issue (now CC'd)
* You should CC the person who would apply this patch (Tom Rini, now CC'd)
* You should include a Fixes: tag that specifies the commit that caused this issue; I think:
* You should double-check all the changes in the original patch in case any other similar issues were introduced.
Quoted 25 lines
--- configs/rpi_2_defconfig | 1 - configs/rpi_defconfig | 1 - 2 files changed, 2 deletions(-)configs/rpi_2_defconfig +0
-1@@ -6,5 +6,4 @@ CONFIG_SYS_PROMPT="U-Boot> " # CONFIG_CMD_FLASH is not set # CONFIG_CMD_FPGA is not set CONFIG_CMD_GPIO=y -# CONFIG_CMD_SETEXPR is not set CONFIG_PHYS_TO_BUS=yconfigs/rpi_defconfig +0
-1@@ -6,5 +6,4 @@ CONFIG_SYS_PROMPT="U-Boot> " # CONFIG_CMD_FLASH is not set # CONFIG_CMD_FPGA is not set CONFIG_CMD_GPIO=y -# CONFIG_CMD_SETEXPR is not set CONFIG_PHYS_TO_BUS=y
PATCH 1/1 Re-enable setexpr on Raspberry Pi
Quoted 15 lines · Stephen Warren
Quoted 7 lines · Marco Schuster
This patch re-enables the setexpr command, I don't really understand why it got excluded in the first place.
setexpr can be used e.g. to implement failed-boot-counters and failovers to rescue firmware.
Two blank lines?
Quoted 1 line
Signed-off-by Marco Schuster <[email protected]>This looks like a reasonable change, but
Quoted 8 lines
* You should CC the author of the patch that caused this issue (now CC'd)
* You should CC the person who would apply this patch (Tom Rini, now CC'd)
* You should include a Fixes: tag that specifies the commit that caused this issue; I think:
Fixes ef0f2f57524e ("Move defaults from config_cmd_default.h to Kconfig")
I knew I shouldn't work on that kind of patch. Too easy to miss something. :/ Maybe modern buildman will help.
Quoted 33 lines
* You should double-check all the changes in the original patch in case any other similar issues were introduced.
Quoted 20 lines
--- configs/rpi_2_defconfig | 1 - configs/rpi_defconfig | 1 - 2 files changed, 2 deletions(-)configs/rpi_2_defconfig +0
-1@@ -6,5 +6,4 @@ CONFIG_SYS_PROMPT="U-Boot> " # CONFIG_CMD_FLASH is not set # CONFIG_CMD_FPGA is not set CONFIG_CMD_GPIO=y -# CONFIG_CMD_SETEXPR is not set CONFIG_PHYS_TO_BUS=yconfigs/rpi_defconfig +0
-0configs/rpi_defconfig CONFIG_SYS_PROMPT="U-Boot> " · line 9
Quoted 5 lines
configs/rpi_defconfig +0
-1@@ -6,5 +6,4 @@ CONFIG_SYS_PROMPT="U-Boot> " # CONFIG_CMD_FLASH is not set # CONFIG_CMD_FPGA is not set CONFIG_CMD_GPIO=y -# CONFIG_CMD_SETEXPR is not set CONFIG_PHYS_TO_BUS=y_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot