Skip to contentSkip to conversation

vhost-user: verify that number of queues is non-zero

PATCH In review Victor Kaplansky 2 participants 2 messages Dec 1, 2015 – Dec 2, 2015 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vhost-user: verify that number of queues is non-zero

Fix QEMU crash when -netdev type=vhost-user,queues=n is passed with zero number of queues.

---
 net/vhost-user.c | 5 +++++
 1 file changed, 5 insertions(+)
net/vhost-user.c +5 -0
index 5071602..b368a90 100644
@@ -316,6 +316,11 @@ int net_init_vhost_user(const NetClientOptions *opts, const char *name,
     }
 
     queues = vhost_user_opts->has_queues ? vhost_user_opts->queues : 1;
+    if (queues < 1) {
+        error_setg(errp,
+                   "vhost-user number of queues must be bigger than zero");
+        return -1;
+    }
 
     return net_vhost_user_init(peer, "vhost_user", name, chr, queues);
 }
Signature · 1 line
--Victor
Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Victor Kaplansky

Fix QEMU crash when -netdev type=vhost-user,queues=n is passed with zero number of queues.

---
 net/vhost-user.c | 5 +++++
 1 file changed, 5 insertions(+)
net/vhost-user.c +0 -0
index 5071602..b368a90 100644
@@ -316,6 +316,11 @@ int net_init_vhost_user(const NetClientOptions *opts, const char *name,
     }

net/vhost-user.c int net_init_vhost_user(const NetClientOptions *opts, const char *name, · line 326

Quoted 10 lines
net/vhost-user.c +5 -0
 
     queues = vhost_user_opts->has_queues ? vhost_user_opts->queues : 1;
+    if (queues < 1) {
+        error_setg(errp,
+                   "vhost-user number of queues must be bigger than zero");
+        return -1;
+    }
 
     return net_vhost_user_init(peer, "vhost_user", name, chr, queues);
 }