Skip to contentSkip to conversation

fix missing dependencies

PATCH Applied Stephen Hemminger 3 participants 5 messages Dec 2, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover fix missing dependencies

Fix some issues found when doing parallel builds

Stephen Hemminger (2):
cmdline_test: add missing dependencies
bonding: add depencency on cmdline library

 app/cmdline_test/Makefile    | 3 +++
 drivers/net/bonding/Makefile | 1 +
 2 files changed, 4 insertions(+)
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/2 cmdline_test: add missing dependencies

The cmdline test is missing a necessary dependency on other components. This caused a build failure when doing parallel builds.

---
 app/cmdline_test/Makefile | 3 +++
 1 file changed, 3 insertions(+)
app/cmdline_test/Makefile +3 -0
index e9eafd2..c6169f5 100644
@@ -47,6 +47,9 @@ SRCS-y += commands.c
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 
+# this application needs libraries first
+DEPDIRS-y += lib drivers
+
 include $(RTE_SDK)/mk/rte.app.mk
 
 endif
Signature · 1 line
2.1.4
#2 lore raw

PATCH 2/2 bonding: add depencency on cmdline library

In reply to Stephen Hemminger

Parallel build of bonding driver can fail because of missing dependency.

---
 drivers/net/bonding/Makefile | 1 +
 1 file changed, 1 insertion(+)
drivers/net/bonding/Makefile +1 -0
index dee0875..10c794c 100644
@@ -63,5 +63,6 @@ DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += lib/librte_mbuf
 DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += lib/librte_ether
 DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += lib/librte_eal
 DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += lib/librte_kvargs
+DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += lib/librte_cmdline
 
 include $(RTE_SDK)/mk/rte.lib.mk
Signature · 1 line
2.1.4
#3 lore raw
In reply to Stephen Hemminger
Quoted 10 lines · Stephen Hemminger

Fix some issues found when doing parallel builds

Stephen Hemminger (2):
cmdline_test: add missing dependencies
bonding: add depencency on cmdline library

  app/cmdline_test/Makefile    | 3 +++
  drivers/net/bonding/Makefile | 1 +
  2 files changed, 4 insertions(+)

Series Acked-by: Declan Doherty<[email protected]>

#4 lore raw

2015-12-02 17:09, Declan Doherty:

Quoted 7 lines · Stephen Hemminger
Quoted 6 lines

Fix some issues found when doing parallel builds

Stephen Hemminger (2):
cmdline_test: add missing dependencies
bonding: add depencency on cmdline library

Quoted 5 lines
Quoted 4 lines
  app/cmdline_test/Makefile    | 3 +++
  drivers/net/bonding/Makefile | 1 +
  2 files changed, 4 insertions(+)

Series Acked-by: Declan Doherty<[email protected]>

Applied, thanks