distro_bootcmd: do not try to fetch unused bootfile for PXE
PATCH 1/1 distro_bootcmd: do not try to fetch unused bootfile for PXE
pxe get derives the pxelinux config file name from the bootfile name, but the bootfile itself is never used and might not even exist. Disable bootfile autoload to avoid the delay.
--- include/config_distro_bootcmd.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
include/config_distro_bootcmd.h +3 -1
@@ -176,7 +176,9 @@#define BOOTENV_DEV_PXE (devtypeu, devtypel, instance) \ "bootcmd_pxe=" \ BOOTENV_RUN_USB_INIT \ - "dhcp; " \ + "env exists autoload && setenv autoload_save ${autoload}; " \ + "setenv autoload no; dhcp; " \ + "env exists autoload_save && setenv autoload ${autoload_save}; " \ "if pxe get; then " \ "pxe boot; " \ "fi\0"
Signature · 1 line
2.1.4
PATCH 1/1 distro_bootcmd: do not try to fetch unused bootfile for PXE
Quoted 3 lines · Stefan Br?ns
pxe get derives the pxelinux config file name from the bootfile name, but the bootfile itself is never used and might not even exist. Disable bootfile autoload to avoid the delay.
I wasn't CC'd on this and only accidentally noticed it, since it just happened to be the first email in this list folder this morning. It's good to CC people based on ./scripts/get_maintainer.pl's output.
include/config_distro_bootcmd.h line 181
Quoted 9 lines
include/config_distro_bootcmd.h +3
-1#define BOOTENV_DEV_PXE (devtypeu, devtypel, instance) \ "bootcmd_pxe=" \ BOOTENV_RUN_USB_INIT \ - "dhcp; " \ + "env exists autoload && setenv autoload_save ${autoload}; " \ + "setenv autoload no; dhcp; " \ + "env exists autoload_save && setenv autoload ${autoload_save}; " \
I think that last line should be unconditional; the previous statement unconditionally sets autoload to no, so we want to unconditionally restore the previous value of autoload, irrespective of whether it was set or not.
I'd expect:
setenv autoload_save $autoload
setenv autoload no
dhcp
setenv autoload $autoload_save
setenv autoload_save
(or a cmdline option to "dhcp" to force it to only acquire an IP address would be nice too).