Skip to contentSkip to conversation

staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN

PATCH RESEND In review Arnd Bergmann 2 participants 2 messages Dec 3, 2015 – Dec 5, 2015 IIO

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN

The iio dummy code was recently changed to use irq_work_queue, but that code is compiled into the kernel only if IRQ_WORK is set, so we can get a link error here:

drivers/built-in.o: In function `iio_evgen_poke':
(.text+0x208a04): undefined reference to `irq_work_queue'

This changes the Kconfig file to match what other drivers do.

Fixes fd2bb310ca3d ("Staging: iio: Move evgen interrupt generation to irq_work")

---
I submitted the patch before and it was accepted, but then it apparently got lost when the driver was moved out of staging, and the bug came back with today's linux-next

drivers/iio/dummy/Kconfig +2 -1
index e8676aa97d62..71805ced1aae 100644
@@ -5,7 +5,8 @@ menu "IIO dummy driver"
 	depends on IIO
 
 config IIO_DUMMY_EVGEN
-       tristate
+	select IRQ_WORK
+	tristate
 
 config IIO_SIMPLE_DUMMY
        tristate "An example driver with no hardware requirements"
maintainer
#1 lore raw
Quoted 9 lines · Arnd Bergmann

The iio dummy code was recently changed to use irq_work_queue, but that code is compiled into the kernel only if IRQ_WORK is set, so we can get a link error here:

drivers/built-in.o: In function `iio_evgen_poke':
(.text+0x208a04): undefined reference to `irq_work_queue'

This changes the Kconfig file to match what other drivers do.

Quoted 7 lines
Fixes fd2bb310ca3d ("Staging: iio: Move evgen interrupt generation to irq_work")

---
I submitted the patch before and it was accepted, but then it apparently got lost when the driver was moved out of staging, and the bug came back with today's linux-next

Good spot - thanks Arnd - this probably explains an odd merge conflict that turned up around that Kconfig. Completely missed this sorry about that!

Have applied to my togreg branch - but there is a slightly delay on this going to Greg from another issue that needs to get sorted so might be a few days before the fix reaches next.

Pushed out as testing for the autobuilders to play with it.

Thanks,

Jonathan

Quoted 22 lines
drivers/iio/dummy/Kconfig +2 -2
index e8676aa97d62..71805ced1aae 100644
@@ -5,7 +5,8 @@ menu "IIO dummy driver"
 	depends on IIO
 
 config IIO_DUMMY_EVGEN
-       tristate
+	select IRQ_WORK
+	tristate
 
 config IIO_SIMPLE_DUMMY
        tristate "An example driver with no hardware requirements"
 
--

To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html