net: eth_designware: select PHYLIB in Kconfig

PATCH New Thomas Chou 5 participants 14 messages Dec 6, 2015 – Dec 21, 2015

Subsystems (2)

Network drivers Arm/Allwinner sunXi SoC support

lore

Share & tools

lore

Thomas Chou

author

2015-12-06 13:19 UTC #0 lore raw

PATCH 1/1 net: eth_designware: select PHYLIB in Kconfig

Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files.

This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE are selected.

Reported-by Pavel Machek <[email protected]>

Signed-off-by Thomas Chou <[email protected]>

---
 drivers/net/Kconfig              | 1 +
 include/configs/axs101.h         | 1 -
 include/configs/bf609-ezkit.h    | 1 -
 include/configs/galileo.h        | 1 -
 include/configs/socfpga_common.h | 1 -
 include/configs/spear-common.h   | 1 -
 include/configs/stv0991.h        | 1 -
 include/configs/sunxi-common.h   | 1 -
 include/configs/tb100.h          | 1 -
 include/configs/x600.h           | 1 -
 10 files changed, 1 insertion(+), 9 deletions(-)

drivers/net/Kconfig +1 -0

index a03a95d..4b04d09 100644
@@ -88,6 +88,7 @@ config ETH_SANDBOX_RAW
 
 config ETH_DESIGNWARE
 	bool "Synopsys Designware Ethernet MAC"
+	select PHYLIB
 	help
 	  This MAC is present in SoCs from various vendors. It supports
 	  100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to

include/configs/axs101.h +0 -1

index 650d97d..eeb2ae6 100644
@@ -95,7 +95,6 @@
 /*
  * Ethernet PHY configuration
  */
-#define CONFIG_PHYLIB
 #define CONFIG_MII
 #define CONFIG_PHY_GIGE

include/configs/bf609-ezkit.h +0 -1

index 0e353b9..b5d4847 100644
@@ -75,7 +75,6 @@
 #define CONFIG_DW_ALTDESCRIPTOR
 #define CONFIG_CMD_MII
 #define CONFIG_MII
-#define CONFIG_PHYLIB
 
 /* i2c Settings */
 #define CONFIG_SYS_I2C

include/configs/galileo.h +0 -1

index eb16a5e..14a42b1 100644
@@ -45,7 +45,6 @@
 /* 10/100M Ethernet support */
 #define CONFIG_DESIGNWARE_ETH
 #define CONFIG_DW_ALTDESCRIPTOR
-#define CONFIG_PHYLIB
 
 /* Environment configuration */
 #define CONFIG_ENV_SECT_SIZE		0x1000

include/configs/socfpga_common.h +0 -1

index b3f65b6..86eccba 100644
@@ -105,7 +105,6 @@
 #define CONFIG_DW_ALTDESCRIPTOR
 #define CONFIG_MII
 #define CONFIG_AUTONEG_TIMEOUT		(15 * CONFIG_SYS_HZ)
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_GIGE
 #endif

include/configs/spear-common.h +0 -1

index 1d69477..d2630f4 100644
@@ -17,7 +17,6 @@
 
 /* Ethernet driver configuration */
 #define CONFIG_MII
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_RESET_DELAY			10000		/* in usec */
 #define CONFIG_PHY_GIGE			/* Include GbE speed/duplex detection */

include/configs/stv0991.h +0 -1

index 14c6a9e..f421321 100644
@@ -53,7 +53,6 @@
 /* GMAC related configs */
 
 #define CONFIG_MII
-#define CONFIG_PHYLIB
 #define CONFIG_DW_ALTDESCRIPTOR
 #define CONFIG_PHY_MICREL

include/configs/sunxi-common.h +0 -1

index 98a2c74..31a68ac 100644
@@ -312,7 +312,6 @@ extern int soft_i2c_gpio_scl;
 #define CONFIG_PHY_GIGE			/* GMAC can use gigabit PHY	*/
 #define CONFIG_PHY_ADDR		1
 #define CONFIG_MII			/* MII PHY management		*/
-#define CONFIG_PHYLIB
 #endif
 
 #ifdef CONFIG_USB_EHCI_HCD

include/configs/tb100.h +0 -1

index 8660ed4..e06484f 100644
@@ -42,7 +42,6 @@
 /*
  * Ethernet PHY configuration
  */
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_GIGE
 
 /*

include/configs/x600.h +0 -1

index 58f1aca..0263c50 100644
@@ -77,7 +77,6 @@
 
 /* Ethernet config options */
 #define CONFIG_MII
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_RESET_DELAY			10000		/* in usec */
 #define CONFIG_PHY_ADDR		0	/* PHY address */
 #define CONFIG_PHY_GIGE			/* Include GbE speed/duplex detection */

Signature · 1 line

2.5.0

Marek Vasut

2015-12-06 18:52 UTC #1 lore raw

PATCH 1/1 net: eth_designware: select PHYLIB in Kconfig

Quoted 26 lines · Thomas Chou

Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files.
This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE are selected.
Reported-by Pavel Machek <[email protected]>
Signed-off-by Thomas Chou <[email protected]>
---
 drivers/net/Kconfig              | 1 +
 include/configs/axs101.h         | 1 -
 include/configs/bf609-ezkit.h    | 1 -
 include/configs/galileo.h        | 1 -
 include/configs/socfpga_common.h | 1 -
 include/configs/spear-common.h   | 1 -
 include/configs/stv0991.h        | 1 -
 include/configs/sunxi-common.h   | 1 -
 include/configs/tb100.h          | 1 -
 include/configs/x600.h           | 1 -
 10 files changed, 1 insertion(+), 9 deletions(-)
drivers/net/Kconfig +0 -0
index a03a95d..4b04d09 100644

drivers/net/Kconfig config ETH_SANDBOX_RAW · line 94

Quoted 7 lines

drivers/net/Kconfig +1 -0

@@ -88,6 +88,7 @@ config ETH_SANDBOX_RAW
 
 config ETH_DESIGNWARE
 	bool "Synopsys Designware Ethernet MAC"
+	select PHYLIB
 	help
 	  This MAC is present in SoCs from various vendors. It supports
 	  100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to

You should also remove the PHYLIB check in drivers/net/designware.c , otherwise looks good.

[...]

Best regards,
Marek Vasut

Thomas Chou

author

2015-12-07 06:37 UTC #2 lore raw

PATCH 1/1 net: eth_designware: select PHYLIB in Kconfig

HI Marek,

Quoted 28 lines · Marek Vasut

Quoted 27 lines · Thomas Chou
Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files.
This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE are selected.
Reported-by Pavel Machek <[email protected]>
Signed-off-by Thomas Chou <[email protected]>
---
  drivers/net/Kconfig              | 1 +
  include/configs/axs101.h         | 1 -
  include/configs/bf609-ezkit.h    | 1 -
  include/configs/galileo.h        | 1 -
  include/configs/socfpga_common.h | 1 -
  include/configs/spear-common.h   | 1 -
  include/configs/stv0991.h        | 1 -
  include/configs/sunxi-common.h   | 1 -
  include/configs/tb100.h          | 1 -
  include/configs/x600.h           | 1 -
  10 files changed, 1 insertion(+), 9 deletions(-)
drivers/net/Kconfig +0 -0
index a03a95d..4b04d09 100644
@@ -88,6 +88,7 @@ config ETH_SANDBOX_RAW
 

Quoted 10 lines

drivers/net/Kconfig config ETH_SANDBOX_RAW · line 94
Quoted 6 lines
drivers/net/Kconfig +1 -0
  config ETH_DESIGNWARE
  	bool "Synopsys Designware Ethernet MAC"
+	select PHYLIB
  	help
  	  This MAC is present in SoCs from various vendors. It supports
  	  100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
You should also remove the PHYLIB check in drivers/net/designware.c , otherwise looks good.

Yes, it will be removed. Thanks.

Best regards,
Thomas

Bin Meng

2015-12-07 01:50 UTC #3 lore raw

PATCH 1/1 net: eth_designware: select PHYLIB in Kconfig

In reply to Thomas Chou

Hi Thomas,

Quoted 134 lines · Thomas Chou

Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files.

This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE are selected.

Reported-by Pavel Machek <[email protected]>

Signed-off-by Thomas Chou <[email protected]>

---
 drivers/net/Kconfig              | 1 +
 include/configs/axs101.h         | 1 -
 include/configs/bf609-ezkit.h    | 1 -
 include/configs/galileo.h        | 1 -
 include/configs/socfpga_common.h | 1 -
 include/configs/spear-common.h   | 1 -
 include/configs/stv0991.h        | 1 -
 include/configs/sunxi-common.h   | 1 -
 include/configs/tb100.h          | 1 -
 include/configs/x600.h           | 1 -
 10 files changed, 1 insertion(+), 9 deletions(-)

drivers/net/Kconfig +1 -0

index a03a95d..4b04d09 100644
@@ -88,6 +88,7 @@ config ETH_SANDBOX_RAW
 
 config ETH_DESIGNWARE
        bool "Synopsys Designware Ethernet MAC"
+       select PHYLIB
        help
          This MAC is present in SoCs from various vendors. It supports
          100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to

include/configs/axs101.h +0 -1

index 650d97d..eeb2ae6 100644
@@ -95,7 +95,6 @@
 /*
  * Ethernet PHY configuration
  */
-#define CONFIG_PHYLIB
 #define CONFIG_MII
 #define CONFIG_PHY_GIGE

include/configs/bf609-ezkit.h +0 -1

index 0e353b9..b5d4847 100644
@@ -75,7 +75,6 @@
 #define CONFIG_DW_ALTDESCRIPTOR
 #define CONFIG_CMD_MII
 #define CONFIG_MII
-#define CONFIG_PHYLIB
 
 /* i2c Settings */
 #define CONFIG_SYS_I2C

include/configs/galileo.h +0 -1

index eb16a5e..14a42b1 100644
@@ -45,7 +45,6 @@
 /* 10/100M Ethernet support */
 #define CONFIG_DESIGNWARE_ETH
 #define CONFIG_DW_ALTDESCRIPTOR
-#define CONFIG_PHYLIB
 
 /* Environment configuration */
 #define CONFIG_ENV_SECT_SIZE           0x1000

include/configs/socfpga_common.h +0 -1

index b3f65b6..86eccba 100644
@@ -105,7 +105,6 @@
 #define CONFIG_DW_ALTDESCRIPTOR
 #define CONFIG_MII
 #define CONFIG_AUTONEG_TIMEOUT         (15 * CONFIG_SYS_HZ)
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_GIGE
 #endif

include/configs/spear-common.h +0 -1

index 1d69477..d2630f4 100644
@@ -17,7 +17,6 @@
 
 /* Ethernet driver configuration */
 #define CONFIG_MII
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_RESET_DELAY                 10000           /* in usec */
 #define CONFIG_PHY_GIGE                        /* Include GbE speed/duplex detection */

include/configs/stv0991.h +0 -1

index 14c6a9e..f421321 100644
@@ -53,7 +53,6 @@
 /* GMAC related configs */
 
 #define CONFIG_MII
-#define CONFIG_PHYLIB
 #define CONFIG_DW_ALTDESCRIPTOR
 #define CONFIG_PHY_MICREL

include/configs/sunxi-common.h +0 -1

index 98a2c74..31a68ac 100644
@@ -312,7 +312,6 @@ extern int soft_i2c_gpio_scl;
 #define CONFIG_PHY_GIGE                        /* GMAC can use gigabit PHY     */
 #define CONFIG_PHY_ADDR                1
 #define CONFIG_MII                     /* MII PHY management           */
-#define CONFIG_PHYLIB
 #endif
 
 #ifdef CONFIG_USB_EHCI_HCD

include/configs/tb100.h +0 -1

index 8660ed4..e06484f 100644
@@ -42,7 +42,6 @@
 /*
  * Ethernet PHY configuration
  */
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_GIGE
 
 /*

include/configs/x600.h +0 -0

index 58f1aca..0263c50 100644

include/configs/x600.h

Quoted 8 lines

include/configs/x600.h +0 -2

@@ -77,7 +77,6 @@
 
 /* Ethernet config options */
 #define CONFIG_MII
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_RESET_DELAY                 10000           /* in usec */
 #define CONFIG_PHY_ADDR                0       /* PHY address */
 #define CONFIG_PHY_GIGE                        /* Include GbE speed/duplex detection */
--

Please remove CONFIG_PHYLIB from galileo.h as well.

Regards,
Bin

Thomas Chou

author

2015-12-07 06:35 UTC #4 lore raw

PATCH 1/1 net: eth_designware: select PHYLIB in Kconfig

Hi Bin,

Quoted 25 lines · Bin Meng

Hi Thomas,
Quoted 21 lines · Thomas Chou
Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files.
This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE are selected.
Reported-by Pavel Machek <[email protected]>
Signed-off-by Thomas Chou <[email protected]>
---
  drivers/net/Kconfig              | 1 +
  include/configs/axs101.h         | 1 -
  include/configs/bf609-ezkit.h    | 1 -
  include/configs/galileo.h        | 1 -
  include/configs/socfpga_common.h | 1 -
  include/configs/spear-common.h   | 1 -
  include/configs/stv0991.h        | 1 -
  include/configs/sunxi-common.h   | 1 -
  include/configs/tb100.h          | 1 -
  include/configs/x600.h           | 1 -
  10 files changed, 1 insertion(+), 9 deletions(-)

Quoted 10 lines

include/configs/galileo.h line 48

Quoted 10 lines

include/configs/galileo.h +0 -1

index eb16a5e..14a42b1 100644
@@ -45,7 +45,6 @@
  /* 10/100M Ethernet support */
  #define CONFIG_DESIGNWARE_ETH
  #define CONFIG_DW_ALTDESCRIPTOR
-#define CONFIG_PHYLIB

The CONFIG_PHYLIB is removed from galileo.h with this patch.

Best regards,
Thomas

Bin Meng

2015-12-07 09:32 UTC #5 lore raw

PATCH 1/1 net: eth_designware: select PHYLIB in Kconfig

Hi Thomas,

Quoted 30 lines · Thomas Chou

Hi Bin,
Quoted 26 lines · Bin Meng
Hi Thomas,
Quoted 22 lines · Thomas Chou
Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files.
This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE are selected.
Reported-by Pavel Machek <[email protected]>
Signed-off-by Thomas Chou <[email protected]>
---
  drivers/net/Kconfig              | 1 +
  include/configs/axs101.h         | 1 -
  include/configs/bf609-ezkit.h    | 1 -
  include/configs/galileo.h        | 1 -
  include/configs/socfpga_common.h | 1 -
  include/configs/spear-common.h   | 1 -
  include/configs/stv0991.h        | 1 -
  include/configs/sunxi-common.h   | 1 -
  include/configs/tb100.h          | 1 -
  include/configs/x600.h           | 1 -
  10 files changed, 1 insertion(+), 9 deletions(-)

Quoted 13 lines

Quoted 10 lines
include/configs/galileo.h line 48
Quoted 10 lines
include/configs/galileo.h +0 -1
index eb16a5e..14a42b1 100644
@@ -45,7 +45,6 @@
  /* 10/100M Ethernet support */
  #define CONFIG_DESIGNWARE_ETH
  #define CONFIG_DW_ALTDESCRIPTOR
-#define CONFIG_PHYLIB
 
The CONFIG_PHYLIB is removed from galileo.h with this patch.

Ah, yes, I must be brain dead :)

Regards,
Bin

Chin Liang See

2015-12-07 06:09 UTC #6 lore raw

PATCH 1/1 net: eth_designware: select PHYLIB in Kconfig

In reply to Thomas Chou

Quoted 8 lines · Thomas Chou

Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files.
This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE are selected.
Reported-by Pavel Machek <[email protected]>
Signed-off-by Thomas Chou <[email protected]>

Quoted 13 lines

---
 drivers/net/Kconfig              | 1 +
 include/configs/axs101.h         | 1 -
 include/configs/bf609-ezkit.h    | 1 -
 include/configs/galileo.h        | 1 -
 include/configs/socfpga_common.h | 1 -
 include/configs/spear-common.h   | 1 -
 include/configs/stv0991.h        | 1 -
 include/configs/sunxi-common.h   | 1 -
 include/configs/tb100.h          | 1 -
 include/configs/x600.h           | 1 -
 10 files changed, 1 insertion(+), 9 deletions(-)

Acked-by Chin Liang See <[email protected]>

Thanks
Chin Liang

Pavel Machek

2015-12-07 07:59 UTC #7 lore raw

PATCH 1/1 net: eth_designware: select PHYLIB in Kconfig

In reply to Thomas Chou

Quoted 6 lines · Thomas Chou

Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files.
This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE are selected.

Acked-by Pavel Machek <[email protected]>

Tested-by Pavel Machek <[email protected]>

Thanks!
Pavel

Signature · 2 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Bin Meng

2015-12-07 09:33 UTC #8 lore raw

PATCH 1/1 net: eth_designware: select PHYLIB in Kconfig

In reply to Thomas Chou

Quoted 134 lines · Thomas Chou

Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files.

This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE are selected.

Reported-by Pavel Machek <[email protected]>

Signed-off-by Thomas Chou <[email protected]>

---
 drivers/net/Kconfig              | 1 +
 include/configs/axs101.h         | 1 -
 include/configs/bf609-ezkit.h    | 1 -
 include/configs/galileo.h        | 1 -
 include/configs/socfpga_common.h | 1 -
 include/configs/spear-common.h   | 1 -
 include/configs/stv0991.h        | 1 -
 include/configs/sunxi-common.h   | 1 -
 include/configs/tb100.h          | 1 -
 include/configs/x600.h           | 1 -
 10 files changed, 1 insertion(+), 9 deletions(-)

drivers/net/Kconfig +1 -0

index a03a95d..4b04d09 100644
@@ -88,6 +88,7 @@ config ETH_SANDBOX_RAW
 
 config ETH_DESIGNWARE
        bool "Synopsys Designware Ethernet MAC"
+       select PHYLIB
        help
          This MAC is present in SoCs from various vendors. It supports
          100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to

include/configs/axs101.h +0 -1

index 650d97d..eeb2ae6 100644
@@ -95,7 +95,6 @@
 /*
  * Ethernet PHY configuration
  */
-#define CONFIG_PHYLIB
 #define CONFIG_MII
 #define CONFIG_PHY_GIGE

include/configs/bf609-ezkit.h +0 -1

index 0e353b9..b5d4847 100644
@@ -75,7 +75,6 @@
 #define CONFIG_DW_ALTDESCRIPTOR
 #define CONFIG_CMD_MII
 #define CONFIG_MII
-#define CONFIG_PHYLIB
 
 /* i2c Settings */
 #define CONFIG_SYS_I2C

include/configs/galileo.h +0 -1

index eb16a5e..14a42b1 100644
@@ -45,7 +45,6 @@
 /* 10/100M Ethernet support */
 #define CONFIG_DESIGNWARE_ETH
 #define CONFIG_DW_ALTDESCRIPTOR
-#define CONFIG_PHYLIB
 
 /* Environment configuration */
 #define CONFIG_ENV_SECT_SIZE           0x1000

include/configs/socfpga_common.h +0 -1

index b3f65b6..86eccba 100644
@@ -105,7 +105,6 @@
 #define CONFIG_DW_ALTDESCRIPTOR
 #define CONFIG_MII
 #define CONFIG_AUTONEG_TIMEOUT         (15 * CONFIG_SYS_HZ)
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_GIGE
 #endif

include/configs/spear-common.h +0 -1

index 1d69477..d2630f4 100644
@@ -17,7 +17,6 @@
 
 /* Ethernet driver configuration */
 #define CONFIG_MII
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_RESET_DELAY                 10000           /* in usec */
 #define CONFIG_PHY_GIGE                        /* Include GbE speed/duplex detection */

include/configs/stv0991.h +0 -1

index 14c6a9e..f421321 100644
@@ -53,7 +53,6 @@
 /* GMAC related configs */
 
 #define CONFIG_MII
-#define CONFIG_PHYLIB
 #define CONFIG_DW_ALTDESCRIPTOR
 #define CONFIG_PHY_MICREL

include/configs/sunxi-common.h +0 -1

index 98a2c74..31a68ac 100644
@@ -312,7 +312,6 @@ extern int soft_i2c_gpio_scl;
 #define CONFIG_PHY_GIGE                        /* GMAC can use gigabit PHY     */
 #define CONFIG_PHY_ADDR                1
 #define CONFIG_MII                     /* MII PHY management           */
-#define CONFIG_PHYLIB
 #endif
 
 #ifdef CONFIG_USB_EHCI_HCD

include/configs/tb100.h +0 -1

index 8660ed4..e06484f 100644
@@ -42,7 +42,6 @@
 /*
  * Ethernet PHY configuration
  */
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_GIGE
 
 /*

include/configs/x600.h +0 -0

index 58f1aca..0263c50 100644

include/configs/x600.h

Quoted 8 lines

include/configs/x600.h +0 -2

@@ -77,7 +77,6 @@
 
 /* Ethernet config options */
 #define CONFIG_MII
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_RESET_DELAY                 10000           /* in usec */
 #define CONFIG_PHY_ADDR                0       /* PHY address */
 #define CONFIG_PHY_GIGE                        /* Include GbE speed/duplex detection */
--

Reviewed-by Bin Meng <[email protected]>

Thomas Chou

author

2015-12-07 12:53 UTC #9 lore raw

PATCH v2 1/1 net: eth_designware: select PHYLIB in Kconfig

In reply to Thomas Chou

Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files.

This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE are selected.

Signed-off-by Thomas Chou <[email protected]>

Reported-by Pavel Machek <[email protected]>

Acked-by Chin Liang See <[email protected]>

Acked-by Pavel Machek <[email protected]>

Tested-by Pavel Machek <[email protected]>

Reviewed-by Bin Meng <[email protected]>

---
v2
remove the PHYLIB check as suggested by Marek.

 drivers/net/Kconfig              | 1 +
 drivers/net/designware.c         | 4 ----
 include/configs/axs101.h         | 1 -
 include/configs/bf609-ezkit.h    | 1 -
 include/configs/galileo.h        | 1 -
 include/configs/socfpga_common.h | 1 -
 include/configs/spear-common.h   | 1 -
 include/configs/stv0991.h        | 1 -
 include/configs/sunxi-common.h   | 1 -
 include/configs/tb100.h          | 1 -
 include/configs/x600.h           | 1 -
 11 files changed, 1 insertion(+), 13 deletions(-)

drivers/net/Kconfig +1 -0

index a03a95d..4b04d09 100644
@@ -88,6 +88,7 @@ config ETH_SANDBOX_RAW
 
 config ETH_DESIGNWARE
 	bool "Synopsys Designware Ethernet MAC"
+	select PHYLIB
 	help
 	  This MAC is present in SoCs from various vendors. It supports
 	  100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to

drivers/net/designware.c +0 -4

index a6c39c3..3af43b4 100644
@@ -22,10 +22,6 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-#if !defined(CONFIG_PHYLIB)
-# error "DesignWare Ether MAC requires PHYLIB - missing CONFIG_PHYLIB"
-#endif
-
 static int dw_mdio_read(struct mii_dev *bus, int addr, int devad, int reg)
 {
 	struct eth_mac_regs *mac_p = bus->priv;

include/configs/axs101.h +0 -1

index 650d97d..eeb2ae6 100644
@@ -95,7 +95,6 @@
 /*
  * Ethernet PHY configuration
  */
-#define CONFIG_PHYLIB
 #define CONFIG_MII
 #define CONFIG_PHY_GIGE

include/configs/bf609-ezkit.h +0 -1

index 0e353b9..b5d4847 100644
@@ -75,7 +75,6 @@
 #define CONFIG_DW_ALTDESCRIPTOR
 #define CONFIG_CMD_MII
 #define CONFIG_MII
-#define CONFIG_PHYLIB
 
 /* i2c Settings */
 #define CONFIG_SYS_I2C

include/configs/galileo.h +0 -1

index eb16a5e..14a42b1 100644
@@ -45,7 +45,6 @@
 /* 10/100M Ethernet support */
 #define CONFIG_DESIGNWARE_ETH
 #define CONFIG_DW_ALTDESCRIPTOR
-#define CONFIG_PHYLIB
 
 /* Environment configuration */
 #define CONFIG_ENV_SECT_SIZE		0x1000

include/configs/socfpga_common.h +0 -1

index b3f65b6..86eccba 100644
@@ -105,7 +105,6 @@
 #define CONFIG_DW_ALTDESCRIPTOR
 #define CONFIG_MII
 #define CONFIG_AUTONEG_TIMEOUT		(15 * CONFIG_SYS_HZ)
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_GIGE
 #endif

include/configs/spear-common.h +0 -1

index 1d69477..d2630f4 100644
@@ -17,7 +17,6 @@
 
 /* Ethernet driver configuration */
 #define CONFIG_MII
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_RESET_DELAY			10000		/* in usec */
 #define CONFIG_PHY_GIGE			/* Include GbE speed/duplex detection */

include/configs/stv0991.h +0 -1

index 14c6a9e..f421321 100644
@@ -53,7 +53,6 @@
 /* GMAC related configs */
 
 #define CONFIG_MII
-#define CONFIG_PHYLIB
 #define CONFIG_DW_ALTDESCRIPTOR
 #define CONFIG_PHY_MICREL

include/configs/sunxi-common.h +0 -1

index 98a2c74..31a68ac 100644
@@ -312,7 +312,6 @@ extern int soft_i2c_gpio_scl;
 #define CONFIG_PHY_GIGE			/* GMAC can use gigabit PHY	*/
 #define CONFIG_PHY_ADDR		1
 #define CONFIG_MII			/* MII PHY management		*/
-#define CONFIG_PHYLIB
 #endif
 
 #ifdef CONFIG_USB_EHCI_HCD

include/configs/tb100.h +0 -1

index 8660ed4..e06484f 100644
@@ -42,7 +42,6 @@
 /*
  * Ethernet PHY configuration
  */
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_GIGE
 
 /*

include/configs/x600.h +0 -1

index 58f1aca..0263c50 100644
@@ -77,7 +77,6 @@
 
 /* Ethernet config options */
 #define CONFIG_MII
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_RESET_DELAY			10000		/* in usec */
 #define CONFIG_PHY_ADDR		0	/* PHY address */
 #define CONFIG_PHY_GIGE			/* Include GbE speed/duplex detection */

Signature · 1 line

2.5.0

Thomas Chou

author

2015-12-19 03:56 UTC #10 lore raw

PATCH v2 1/1 net: eth_designware: select PHYLIB in Kconfig

Hi Marek,

Quoted 16 lines · Thomas Chou

Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files.
This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE are selected.
Signed-off-by Thomas Chou <[email protected]>
Reported-by Pavel Machek <[email protected]>
Acked-by Chin Liang See <[email protected]>
Acked-by Pavel Machek <[email protected]>
Tested-by Pavel Machek <[email protected]>
Reviewed-by Bin Meng <[email protected]>
---
v2
remove the PHYLIB check as suggested by Marek.

Quoted 13 lines

  drivers/net/Kconfig              | 1 +
  drivers/net/designware.c         | 4 ----
  include/configs/axs101.h         | 1 -
  include/configs/bf609-ezkit.h    | 1 -
  include/configs/galileo.h        | 1 -
  include/configs/socfpga_common.h | 1 -
  include/configs/spear-common.h   | 1 -
  include/configs/stv0991.h        | 1 -
  include/configs/sunxi-common.h   | 1 -
  include/configs/tb100.h          | 1 -
  include/configs/x600.h           | 1 -
  11 files changed, 1 insertion(+), 13 deletions(-)

Would you please pick this one? I didn't notice that it was delegated to me before I sent a PR for nios. Thanks.

Best regards,
Thomas

Marek Vasut

2015-12-19 05:47 UTC #11 lore raw

PATCH v2 1/1 net: eth_designware: select PHYLIB in Kconfig

Quoted 33 lines · Thomas Chou

Hi Marek,
Quoted 17 lines · Thomas Chou
Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files.
This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE are selected.
Signed-off-by Thomas Chou <[email protected]>
Reported-by Pavel Machek <[email protected]>
Acked-by Chin Liang See <[email protected]>
Acked-by Pavel Machek <[email protected]>
Tested-by Pavel Machek <[email protected]>
Reviewed-by Bin Meng <[email protected]>
---
v2
remove the PHYLIB check as suggested by Marek.
Quoted 12 lines
  drivers/net/Kconfig              | 1 +
  drivers/net/designware.c         | 4 ----
  include/configs/axs101.h         | 1 -
  include/configs/bf609-ezkit.h    | 1 -
  include/configs/galileo.h        | 1 -
  include/configs/socfpga_common.h | 1 -
  include/configs/spear-common.h   | 1 -
  include/configs/stv0991.h        | 1 -
  include/configs/sunxi-common.h   | 1 -
  include/configs/tb100.h          | 1 -
  include/configs/x600.h           | 1 -
  11 files changed, 1 insertion(+), 13 deletions(-)

Quoted 2 lines

Would you please pick this one? I didn't notice that it was delegated to me before I sent a PR for nios. Thanks.

You mean via socfpga ?

Best regards,
Marek Vasut

Thomas Chou

author

2015-12-19 08:24 UTC #12 lore raw

PATCH v2 1/1 net: eth_designware: select PHYLIB in Kconfig

Hi Marek,

Quoted 34 lines · Marek Vasut

Quoted 33 lines · Thomas Chou
Hi Marek,
Quoted 29 lines · Thomas Chou
Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files.
This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE are selected.
Signed-off-by Thomas Chou <[email protected]>
Reported-by Pavel Machek <[email protected]>
Acked-by Chin Liang See <[email protected]>
Acked-by Pavel Machek <[email protected]>
Tested-by Pavel Machek <[email protected]>
Reviewed-by Bin Meng <[email protected]>
---
v2
remove the PHYLIB check as suggested by Marek.
   drivers/net/Kconfig              | 1 +
   drivers/net/designware.c         | 4 ----
   include/configs/axs101.h         | 1 -
   include/configs/bf609-ezkit.h    | 1 -
   include/configs/galileo.h        | 1 -
   include/configs/socfpga_common.h | 1 -
   include/configs/spear-common.h   | 1 -
   include/configs/stv0991.h        | 1 -
   include/configs/sunxi-common.h   | 1 -
   include/configs/tb100.h          | 1 -
   include/configs/x600.h           | 1 -
   11 files changed, 1 insertion(+), 13 deletions(-)

Quoted 4 lines

Quoted 2 lines
Would you please pick this one? I didn't notice that it was delegated to me before I sent a PR for nios. Thanks.
You mean via socfpga ?

Yes, please. It was reported on socfpga.

Best regards,
Thomas

Marek Vasut

Applied

2015-12-21 14:20 UTC #13 lore raw

PATCH v2 1/1 net: eth_designware: select PHYLIB in Kconfig

Quoted 37 lines · Thomas Chou

Hi Marek,
Quoted 34 lines · Marek Vasut
Quoted 33 lines · Thomas Chou
Hi Marek,
Quoted 29 lines · Thomas Chou
Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files.
This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE are selected.
Signed-off-by Thomas Chou <[email protected]>
Reported-by Pavel Machek <[email protected]>
Acked-by Chin Liang See <[email protected]>
Acked-by Pavel Machek <[email protected]>
Tested-by Pavel Machek <[email protected]>
Reviewed-by Bin Meng <[email protected]>
---
v2
remove the PHYLIB check as suggested by Marek.
   drivers/net/Kconfig              | 1 +
   drivers/net/designware.c         | 4 ----
   include/configs/axs101.h         | 1 -
   include/configs/bf609-ezkit.h    | 1 -
   include/configs/galileo.h        | 1 -
   include/configs/socfpga_common.h | 1 -
   include/configs/spear-common.h   | 1 -
   include/configs/stv0991.h        | 1 -
   include/configs/sunxi-common.h   | 1 -
   include/configs/tb100.h          | 1 -
   include/configs/x600.h           | 1 -
   11 files changed, 1 insertion(+), 13 deletions(-)

Quoted 6 lines

Quoted 4 lines
Quoted 2 lines
Would you please pick this one? I didn't notice that it was delegated to me before I sent a PR for nios. Thanks.
You mean via socfpga ?
Yes, please. It was reported on socfpga.

Applied, thanks!

Best regards,
Marek Vasut