usb: udc: Fix warnings on 64-bit builds

PATCH New Michal Simek 3 participants 7 messages Oct 30, 2015 – Dec 9, 2015 USB

Share & tools

Michal Simek

author

2015-10-30 15:21 UTC #0 lore raw

PATCH 1/1 usb: udc: Fix warnings on 64-bit builds

Cast u32 bit value to 64bit before recasting to 64bit pointer to avoid pointer from integer cast size mismatch warnings.

Warning log:
+../drivers/usb/gadget/udc/udc-core.c: In function ?usb_gadget_unmap_request?:
+../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

Signed-off-by Michal Simek <[email protected]>

---

 drivers/usb/gadget/udc/udc-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/usb/gadget/udc/udc-core.c +1 -1

index 875e998a82e3..326757b547fa 100644
@@ -65,7 +65,7 @@ void usb_gadget_unmap_request(struct usb_gadget *gadget,
 	if (req->length == 0)
 		return;
 
-	dma_unmap_single((void *)req->dma, req->length,
+	dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
 			 is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
 }
 EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);

Signature · 1 line

2.5.0

Lukasz Majewski

2015-11-03 10:14 UTC #1 lore raw

PATCH 1/1 usb: udc: Fix warnings on 64-bit builds

Hi Michal,

Quoted 20 lines

Cast u32 bit value to 64bit before recasting to 64bit pointer to avoid pointer from integer cast size mismatch warnings.
Warning log:
+../drivers/usb/gadget/udc/udc-core.c: In function ?usb_gadget_unmap_request?:
+../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
Signed-off-by Michal Simek <[email protected]>
---
 drivers/usb/gadget/udc/udc-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0
b/drivers/usb/gadget/udc/udc-core.c index 875e998a82e3..326757b547fa 100644 --- a/drivers/usb/gadget/udc/udc-core.c
+++ b/drivers/usb/gadget/udc/udc-core.c

drivers/usb/gadget/udc/udc-core.c void usb_gadget_unmap_request(struct usb_gadget · line 71

Quoted 8 lines

drivers/usb/gadget/udc/udc-core.c +1 -1

@@ -65,7 +65,7 @@ void usb_gadget_unmap_request(struct usb_gadget
 *gadget, if (req->length == 0)
 		return;
 
-	dma_unmap_single((void *)req->dma, req->length,
+	dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
 			 is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
 }
 EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);

Acked-by Lukasz Majewski <[email protected]>

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Michal Simek

2015-12-07 12:01 UTC #2 lore raw

PATCH 1/1 usb: udc: Fix warnings on 64-bit builds

Hi Marek and Lukasz,

Quoted 25 lines · Lukasz Majewski

Hi Michal,
Quoted 23 lines
Cast u32 bit value to 64bit before recasting to 64bit pointer to avoid pointer from integer cast size mismatch warnings.
Warning log:
+../drivers/usb/gadget/udc/udc-core.c: In function ?usb_gadget_unmap_request?:
+../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
Signed-off-by Michal Simek <[email protected]>
---
 drivers/usb/gadget/udc/udc-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0
b/drivers/usb/gadget/udc/udc-core.c index 875e998a82e3..326757b547fa 100644 --- a/drivers/usb/gadget/udc/udc-core.c
+++ b/drivers/usb/gadget/udc/udc-core.c
(quoted diff) +0 -0
@@ -65,7 +65,7 @@ void usb_gadget_unmap_request(struct usb_gadget
 *gadget, if (req->length == 0)
 		return;
 

Quoted 8 lines

drivers/usb/gadget/udc/udc-core.c void usb_gadget_unmap_request(struct usb_gadget *gadget, · line 71
Quoted 5 lines
drivers/usb/gadget/udc/udc-core.c +1 -1
-	dma_unmap_single((void *)req->dma, req->length,
+	dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
 			 is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
 }
 EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
Acked-by Lukasz Majewski <[email protected]>

Is this patch in any of your queue?

Thanks,
Michal

Signature · 14 lines

Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151207/e0e1431b/attachment.sig>

Lukasz Majewski

2015-12-08 06:59 UTC #3 lore raw

PATCH 1/1 usb: udc: Fix warnings on 64-bit builds

Hi Michal,

Quoted 37 lines

Hi Marek and Lukasz,
Quoted 25 lines · Lukasz Majewski
Hi Michal,
Quoted 23 lines
Cast u32 bit value to 64bit before recasting to 64bit pointer to avoid pointer from integer cast size mismatch warnings.
Warning log:
+../drivers/usb/gadget/udc/udc-core.c: In function ?usb_gadget_unmap_request?:
+../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
Signed-off-by Michal Simek <[email protected]>
---
 drivers/usb/gadget/udc/udc-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0
b/drivers/usb/gadget/udc/udc-core.c index 875e998a82e3..326757b547fa 100644 --- a/drivers/usb/gadget/udc/udc-core.c +++ b/drivers/usb/gadget/udc/udc-core.c @@ -65,7 +65,7 @@ void usb_gadget_unmap_request(struct usb_gadget *gadget, if (req->length == 0) return;
Quoted 8 lines
drivers/usb/gadget/udc/udc-core.c void usb_gadget_unmap_request(struct usb_gadget *gadget, · line 71
Quoted 5 lines
drivers/usb/gadget/udc/udc-core.c +1 -1
-	dma_unmap_single((void *)req->dma, req->length,
+	dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
 			 is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
 }
 EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
Acked-by Lukasz Majewski <[email protected]>

Quoted 5 lines

Is this patch in any of your queue?
Thanks,
Michal

I can grab this to -dfu tree since I'm in the middle of preparing PR.

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Michal Simek

author

2015-12-08 07:18 UTC #4 lore raw

PATCH 1/1 usb: udc: Fix warnings on 64-bit builds

Quoted 39 lines · Lukasz Majewski

Hi Michal,
Quoted 37 lines
Hi Marek and Lukasz,
Quoted 33 lines · Lukasz Majewski
Hi Michal,
Quoted 23 lines
Cast u32 bit value to 64bit before recasting to 64bit pointer to avoid pointer from integer cast size mismatch warnings.
Warning log:
+../drivers/usb/gadget/udc/udc-core.c: In function ?usb_gadget_unmap_request?:
+../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
Signed-off-by Michal Simek <[email protected]>
---
 drivers/usb/gadget/udc/udc-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0
b/drivers/usb/gadget/udc/udc-core.c index 875e998a82e3..326757b547fa 100644 --- a/drivers/usb/gadget/udc/udc-core.c +++ b/drivers/usb/gadget/udc/udc-core.c @@ -65,7 +65,7 @@ void usb_gadget_unmap_request(struct usb_gadget *gadget, if (req->length == 0) return;
drivers/usb/gadget/udc/udc-core.c void usb_gadget_unmap_request(struct usb_gadget *gadget, · line 71
Quoted 5 lines
drivers/usb/gadget/udc/udc-core.c +1 -1
-	dma_unmap_single((void *)req->dma, req->length,
+	dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
 			 is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
 }
 EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
Acked-by Lukasz Majewski <[email protected]>

Quoted 8 lines

Quoted 5 lines
Is this patch in any of your queue?
Thanks,
Michal
I can grab this to -dfu tree since I'm in the middle of preparing PR.

Thanks,
Michal

Lukasz Majewski

2015-12-09 09:33 UTC #5 lore raw

PATCH 1/1 usb: udc: Fix warnings on 64-bit builds

In reply to Michal Simek

Hi Michal,

Quoted 37 lines

Hi Marek and Lukasz,
Quoted 25 lines · Lukasz Majewski
Hi Michal,
Quoted 23 lines
Cast u32 bit value to 64bit before recasting to 64bit pointer to avoid pointer from integer cast size mismatch warnings.
Warning log:
+../drivers/usb/gadget/udc/udc-core.c: In function ?usb_gadget_unmap_request?:
+../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
Signed-off-by Michal Simek <[email protected]>
---
 drivers/usb/gadget/udc/udc-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0
b/drivers/usb/gadget/udc/udc-core.c index 875e998a82e3..326757b547fa 100644 --- a/drivers/usb/gadget/udc/udc-core.c +++ b/drivers/usb/gadget/udc/udc-core.c @@ -65,7 +65,7 @@ void usb_gadget_unmap_request(struct usb_gadget *gadget, if (req->length == 0) return;
Quoted 8 lines
drivers/usb/gadget/udc/udc-core.c void usb_gadget_unmap_request(struct usb_gadget *gadget, · line 71
Quoted 5 lines
drivers/usb/gadget/udc/udc-core.c +1 -1
-	dma_unmap_single((void *)req->dma, req->length,
+	dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
 			 is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
 }
 EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
Acked-by Lukasz Majewski <[email protected]>

Quoted 1 line

Is this patch in any of your queue?

It is already applied to -usb tree :-).

Quoted 4 lines

Thanks,
Michal

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Michal Simek

author

2015-12-09 09:40 UTC #6 lore raw

PATCH 1/1 usb: udc: Fix warnings on 64-bit builds

Quoted 39 lines · Lukasz Majewski

Hi Michal,
Quoted 37 lines
Hi Marek and Lukasz,
Quoted 33 lines · Lukasz Majewski
Hi Michal,
Quoted 23 lines
Cast u32 bit value to 64bit before recasting to 64bit pointer to avoid pointer from integer cast size mismatch warnings.
Warning log:
+../drivers/usb/gadget/udc/udc-core.c: In function ?usb_gadget_unmap_request?:
+../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
Signed-off-by Michal Simek <[email protected]>
---
 drivers/usb/gadget/udc/udc-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0
b/drivers/usb/gadget/udc/udc-core.c index 875e998a82e3..326757b547fa 100644 --- a/drivers/usb/gadget/udc/udc-core.c +++ b/drivers/usb/gadget/udc/udc-core.c @@ -65,7 +65,7 @@ void usb_gadget_unmap_request(struct usb_gadget *gadget, if (req->length == 0) return;
drivers/usb/gadget/udc/udc-core.c void usb_gadget_unmap_request(struct usb_gadget *gadget, · line 71
Quoted 5 lines
drivers/usb/gadget/udc/udc-core.c +1 -1
-	dma_unmap_single((void *)req->dma, req->length,
+	dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
 			 is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
 }
 EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
Acked-by Lukasz Majewski <[email protected]>

Quoted 3 lines

Quoted 1 line
Is this patch in any of your queue?
It is already applied to -usb tree :-).

Then great.

Thanks,
Michal