Skip to contentSkip to conversation

UML fixes for 4.4-rc5

GIT PULL Richard Weinberger 2 participants 3 messages Dec 8, 2015 – Dec 9, 2015 User-mode Linux (UML)

lore
Share & tools
lore

Richard Weinberger

author maintainer
#0 lore raw

Linus,

The following changes since commit 527e9316f8ec44bd53d90fb9f611fa7ffff52bb9:

Linux 4.4-rc4 (2015-12-06 15:43:12 -0800)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git for-linus-4.4-rc5

for you to fetch changes up to 887a9853092c09e20598f4a7f91ac1cfb762be50:

um: fix returns without va_end (2015-12-08 22:26:00 +0100)

----------------------------------------------------------------
This pull request contains various bug fixes, most of them are fall out from the merge window.

----------------------------------------------------------------
Geyslan G. Bem (1):
um: fix returns without va_end

Lorenzo Colitti (1):
arch: um: fix error when linking vmlinux.

Richard Weinberger (2):
um: Fix get_signal() usage
um: Fix fpstate handling

 arch/um/Makefile           |  2 +-
 arch/um/drivers/net_user.c | 10 ++++++----
 arch/um/kernel/signal.c    |  2 +-
 arch/x86/um/signal.c       | 18 ++++++++++--------
 scripts/link-vmlinux.sh    |  2 +-
 5 files changed, 19 insertions(+), 15 deletions(-)
#1 lore raw
Quoted 6 lines · Richard Weinberger

This pull request contains various bug fixes, most of them are fall out from the merge window.

Richard Weinberger (2):
um: Fix fpstate handling

Ugh. This is very ugly. It's apparently the result of commit 530e5c827182 ("x86/headers: Make sigcontext pointers bit independent") and apparently nobody noticed the uml fallout.

I've pulled, but I wanted the x86 people involved to be aware of this ugly corner. I wonder if there might be some way for uml to continue to use that fpstate entry as a pointer, at least when the wordsize matches (which it will)?

Linus

------------------------------------------------------------------------------
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

author maintainer
#2 lore raw

Linus,

Am 09.12.2015 um 02:35 schrieb Linus Torvalds:

Quoted 8 lines · Richard Weinberger
Quoted 6 lines

This pull request contains various bug fixes, most of them are fall out from the merge window.

Richard Weinberger (2):
um: Fix fpstate handling

Quoted 8 lines

Ugh. This is very ugly. It's apparently the result of commit 530e5c827182 ("x86/headers: Make sigcontext pointers bit independent") and apparently nobody noticed the uml fallout.

I've pulled, but I wanted the x86 people involved to be aware of this ugly corner. I wonder if there might be some way for uml to continue to use that fpstate entry as a pointer, at least when the wordsize matches (which it will)?

I agree. One way to get rid of the ugliness would be rewriting UML's FP code. The code is very old and doing it like x86 does would be a good thing anyway. But that's nothing I'll do at this stage of development. That's material for the next merge window.

Thanks,
//richard