Skip to contentSkip to conversation

edid-decode: new package

PATCH New Peter Seiderer 3 participants 3 messages Dec 7, 2015 – Dec 9, 2015

lore
Share & tools
lore

Peter Seiderer

author
#0 lore raw

PATCH 1/1 edid-decode: new package

Signed-off-by Peter Seiderer <[email protected]>
---
 package/Config.in                  |  1 +
 package/edid-decode/Config.in      |  6 ++++++
 package/edid-decode/edid-decode.mk | 20 ++++++++++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/edid-decode/Config.in
 create mode 100644 package/edid-decode/edid-decode.mk
package/Config.in +1 -0
index 38436e2..07461e5 100644
@@ -338,6 +338,7 @@ endif
 	source "package/dtv-scan-tables/Config.in"
 	source "package/dvb-apps/Config.in"
 	source "package/dvbsnoop/Config.in"
+	source "package/edid-decode/Config.in"
 	source "package/eeprog/Config.in"
 	source "package/eudev/Config.in"
 	source "package/evemu/Config.in"
package/edid-decode/Config.in new file +6 -0
new file mode 100644
index 0000000..64297b4
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_EDID_DECODE
+	bool "edid-decode"
+	help
+	  Decode EDID data in human-readable format.
+
+	  http://cgit.freedesktop.org/xorg/app/edid-decode/
package/edid-decode/edid-decode.mk new file +20 -0
new file mode 100644
index 0000000..da6a1d1
@@ -0,0 +1,20 @@
+################################################################################
+#
+# edid-decode
+#
+################################################################################
+
+EDID_DECODE_VERSION = 681153145d5e05ee15032ea792e967cda06e7622
+EDID_DECODE_SITE = git://anongit.freedesktop.org/git/xorg/app/edid-decode.git
+EDID_DECODE_LICENSE = MIT
+EDID_DECODE_LICENSE_FILES = edid-decode.c
+
+define EDID_DECODE_BUILD_CMDS
+	$(MAKE) -C $(@D) CC="$(TARGET_CC)" edid-decode
+endef
+
+define EDID_DECODE_INSTALL_TARGET_CMDS
+	$(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
+endef
+
+$(eval $(generic-package))
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 edid-decode: new package

Dear Peter Seiderer,

On 07/12/15 21:14, Peter Seiderer wrote:

[snip]

Quoted 6 lines
package/edid-decode/edid-decode.mk new file +0 -0
new file mode 100644
index 0000000..da6a1d1

package/edid-decode/edid-decode.mk line 9

Quoted 9 lines
package/edid-decode/edid-decode.mk new file +9 -0
@@ -0,0 +1,20 @@
+################################################################################
+#
+# edid-decode
+#
+################################################################################
+
+EDID_DECODE_VERSION = 681153145d5e05ee15032ea792e967cda06e7622
+EDID_DECODE_SITE = git://anongit.freedesktop.org/git/xorg/app/edid-decode.git
+EDID_DECODE_LICENSE = MIT

I'm not sure if we should write MIT or MIT-like here. Can anyone else have a look to this, please?

package/edid-decode/edid-decode.mk line 13

Quoted 4 lines
package/edid-decode/edid-decode.mk new file +4 -0
+EDID_DECODE_LICENSE_FILES = edid-decode.c
+
+define EDID_DECODE_BUILD_CMDS
+	$(MAKE) -C $(@D) CC="$(TARGET_CC)" edid-decode

You are missing the $(TARGET_MAKE_ENV) variable in front of $(MAKE).

Also, if you want, you can use $(TARGET_CONFIGURE_OPTS) which will do the CC="$(TARGET_CC)" (among other things) for you.

Regards,

Vincent.

Quoted 8 lines
package/edid-decode/edid-decode.mk new file +7 -0
+endef
+
+define EDID_DECODE_INSTALL_TARGET_CMDS
+	$(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
+endef
+
+$(eval $(generic-package))
#2 lore raw

PATCH 1/1 edid-decode: new package

In reply to Peter Seiderer
Quoted 44 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Seiderer <[email protected]> writes:

Signed-off-by Peter Seiderer <[email protected]>
---
 package/Config.in                  |  1 +
 package/edid-decode/Config.in      |  6 ++++++
 package/edid-decode/edid-decode.mk | 20 ++++++++++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/edid-decode/Config.in
 create mode 100644 package/edid-decode/edid-decode.mk
package/Config.in +1 -0
index 38436e2..07461e5 100644
@@ -338,6 +338,7 @@ endif
 	source "package/dtv-scan-tables/Config.in"
 	source "package/dvb-apps/Config.in"
 	source "package/dvbsnoop/Config.in"
+	source "package/edid-decode/Config.in"
 	source "package/eeprog/Config.in"
 	source "package/eudev/Config.in"
 	source "package/evemu/Config.in"
package/edid-decode/Config.in new file +6 -0
new file mode 100644
index 0000000..64297b4
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_EDID_DECODE
+	bool "edid-decode"
+	help
+	  Decode EDID data in human-readable format.
+
+	  http://cgit.freedesktop.org/xorg/app/edid-decode/
package/edid-decode/edid-decode.mk new file +3 -0
new file mode 100644
index 0000000..da6a1d1
@@ -0,0 +1,20 @@
+################################################################################
+#
+# edid-decode

package/edid-decode/edid-decode.mk line 13

Quoted 10 lines
package/edid-decode/edid-decode.mk new file +10 -0
+#
+################################################################################
+
+EDID_DECODE_VERSION = 681153145d5e05ee15032ea792e967cda06e7622
+EDID_DECODE_SITE = git://anongit.freedesktop.org/git/xorg/app/edid-decode.git
+EDID_DECODE_LICENSE = MIT
+EDID_DECODE_LICENSE_FILES = edid-decode.c
+
+define EDID_DECODE_BUILD_CMDS
+	$(MAKE) -C $(@D) CC="$(TARGET_CC)" edid-decode

We should also use our CFLAGS / LDFLAGS. The Makefile doesn't directly provide support for this, so I've changed it to pass it in CC="".

Committed with that fixed, thanks.

Signature · 1 line
Bye, Peter Korsgaard