Skip to contentSkip to conversation

serial: Use static inline for _debug_uart_init()

PATCH Superseded Michal Simek 4 participants 5 messages Dec 14, 2015 – Dec 15, 2015 Arm/Zynq architecture

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Michal Simek

author
#0 lore raw

PATCH 1/1 serial: Use static inline for _debug_uart_init()

Reported-by Thomas Chou <[email protected]>
Signed-off-by Michal Simek <[email protected]>

---

 drivers/serial/serial_xuartlite.c | 2 +-
 drivers/serial/serial_zynq.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/serial/serial_xuartlite.c +1 -1
index fe87b515d902..0238a52380c7 100644
@@ -122,7 +122,7 @@ U_BOOT_DRIVER(serial_uartlite) = {
 };
 
 #ifdef CONFIG_DEBUG_UART_UARTLITE
-void _debug_uart_init(void)
+static inline void _debug_uart_init(void)
 {
 	struct uartlite *regs = (struct uartlite *)CONFIG_DEBUG_UART_BASE;
drivers/serial/serial_zynq.c +1 -1
index b2b98dea1561..3430482f8d8b 100644
@@ -192,7 +192,7 @@ U_BOOT_DRIVER(serial_zynq) = {
 };
 
 #ifdef CONFIG_DEBUG_UART_ZYNQ
-void _debug_uart_init(void)
+static inline void _debug_uart_init(void)
 {
 	struct uart_zynq *regs = (struct uart_zynq *)CONFIG_DEBUG_UART_BASE;
Signature · 1 line
1.9.1
#2 lore raw

PATCH 1/1 serial: Use static inline for _debug_uart_init()

In reply to Michal Simek

Hi Michal,

Quoted 3 lines · Michal Simek
Reported-by Thomas Chou <[email protected]>
Signed-off-by Michal Simek <[email protected]>

---

Could you always include a simple sentence in the commit message?

Quoted 23 lines
 drivers/serial/serial_xuartlite.c | 2 +-
 drivers/serial/serial_zynq.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/serial/serial_xuartlite.c +1 -1
index fe87b515d902..0238a52380c7 100644
@@ -122,7 +122,7 @@ U_BOOT_DRIVER(serial_uartlite) = {
 };
 
 #ifdef CONFIG_DEBUG_UART_UARTLITE
-void _debug_uart_init(void)
+static inline void _debug_uart_init(void)
 {
        struct uartlite *regs = (struct uartlite *)CONFIG_DEBUG_UART_BASE;
drivers/serial/serial_zynq.c +0 -0
index b2b98dea1561..3430482f8d8b 100644

drivers/serial/serial_zynq.c U_BOOT_DRIVER(serial_zynq) = {

Quoted 9 lines
drivers/serial/serial_zynq.c +1 -2
@@ -192,7 +192,7 @@ U_BOOT_DRIVER(serial_zynq) = {
 };
 
 #ifdef CONFIG_DEBUG_UART_ZYNQ
-void _debug_uart_init(void)
+static inline void _debug_uart_init(void)
 {
        struct uart_zynq *regs = (struct uart_zynq *)CONFIG_DEBUG_UART_BASE;
 
--

Other than that,

Reviewed-by Bin Meng <[email protected]>

Regards,
Bin

#4 lore raw

PATCH 1/1 serial: Use static inline for _debug_uart_init()

In reply to Michal Simek

Hi Michal,

Quoted 27 lines · Michal Simek
Reported-by Thomas Chou <[email protected]>
Signed-off-by Michal Simek <[email protected]>

---

  drivers/serial/serial_xuartlite.c | 2 +-
  drivers/serial/serial_zynq.c      | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
drivers/serial/serial_xuartlite.c +1 -1
index fe87b515d902..0238a52380c7 100644
@@ -122,7 +122,7 @@ U_BOOT_DRIVER(serial_uartlite) = {
  };
 
  #ifdef CONFIG_DEBUG_UART_UARTLITE
-void _debug_uart_init(void)
+static inline void _debug_uart_init(void)
  {
  	struct uartlite *regs = (struct uartlite *)CONFIG_DEBUG_UART_BASE;
drivers/serial/serial_zynq.c +0 -0
index b2b98dea1561..3430482f8d8b 100644

drivers/serial/serial_zynq.c U_BOOT_DRIVER(serial_zynq) = { · line 198

Quoted 8 lines
drivers/serial/serial_zynq.c +1 -1
@@ -192,7 +192,7 @@ U_BOOT_DRIVER(serial_zynq) = {
  };
 
  #ifdef CONFIG_DEBUG_UART_ZYNQ
-void _debug_uart_init(void)
+static inline void _debug_uart_init(void)
  {
  	struct uart_zynq *regs = (struct uart_zynq *)CONFIG_DEBUG_UART_BASE;
Reviewed-by Thomas Chou <[email protected]>

Thanks,
Thomas