nios2: display altera sysid at startup

PATCH New Thomas Chou 2 participants 6 messages Dec 16, 2015 NIOS2 architecture

lore

Share & tools

lore

Thomas Chou

author

2015-12-16 08:07 UTC #0 lore raw

PATCH 1/1 nios2: display altera sysid at startup

Display altera sysid at startup, which was once removed during the move.

Signed-off-by Thomas Chou <[email protected]>

---
 arch/nios2/cpu/cpu.c | 8 ++++++++
 1 file changed, 8 insertions(+)

arch/nios2/cpu/cpu.c +8 -0

index f6d5cd3..be7f99c 100644
@@ -21,6 +21,14 @@ int print_cpuinfo(void)
 }
 #endif /* CONFIG_DISPLAY_CPUINFO */
 
+#ifdef CONFIG_ALTERA_SYSID
+int checkboard(void)
+{
+	display_sysid();
+	return 0;
+}
+#endif
+
 int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
 	disable_interrupts();

Signature · 1 line

2.5.0

Marek Vasut

2015-12-16 10:25 UTC #1 lore raw

PATCH 1/1 nios2: display altera sysid at startup

Quoted 4 lines · Thomas Chou

Display altera sysid at startup, which was once removed during the move.
Signed-off-by Thomas Chou <[email protected]>

What if the sysid block isn't part of the design ?

Best regards,
Marek Vasut

Thomas Chou

author

2015-12-16 13:10 UTC #2 lore raw

PATCH 1/1 nios2: display altera sysid at startup

Hi Marek,

Quoted 7 lines · Marek Vasut

Quoted 4 lines · Thomas Chou
Display altera sysid at startup, which was once removed during the move.
Signed-off-by Thomas Chou <[email protected]>
What if the sysid block isn't part of the design ?

If the sysid block is not present, nothing will display and it is not an error.

Best regards,
Thomas

Marek Vasut

2015-12-16 13:23 UTC #3 lore raw

PATCH 1/1 nios2: display altera sysid at startup

Quoted 1 line · Thomas Chou

Hi Marek,

Hi!

Quoted 11 lines · Marek Vasut

Quoted 7 lines · Thomas Chou
Quoted 4 lines
Display altera sysid at startup, which was once removed during the move.
Signed-off-by Thomas Chou <[email protected]>
What if the sysid block isn't part of the design ?
If the sysid block is not present, nothing will display and it is not an error.

Won't this cause bus stall if you try to access unpopulated location ?

Best regards,
Marek Vasut

Thomas Chou

author

2015-12-16 13:44 UTC #4 lore raw

PATCH 1/1 nios2: display altera sysid at startup

Hi Marek,

Quoted 10 lines · Marek Vasut

Quoted 1 line · Thomas Chou
Hi Marek,
Hi!
Quoted 5 lines · Marek Vasut
Quoted 4 lines · Thomas Chou
Quoted 3 lines
Display altera sysid at startup, which was once removed during the move.

Quoted 8 lines

Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Thomas Chou <[email protected]>
What if the sysid block isn't part of the design ?
If the sysid block is not present, nothing will display and it is not an error.
Won't this cause bus stall if you try to access unpopulated location ?

It will be accessed though DT binding. As long as DT is correct, it won't access unpopulated location.

With the Altera Avalon bus, even a unpopulated access will not stall.

Best regards,
Thomas

Marek Vasut

2015-12-16 14:01 UTC #5 lore raw

PATCH 1/1 nios2: display altera sysid at startup

Quoted 20 lines · Thomas Chou

Hi Marek,
Quoted 17 lines · Marek Vasut
Quoted 1 line · Thomas Chou
Hi Marek,
Hi!
Quoted 11 lines · Marek Vasut
Quoted 7 lines · Thomas Chou
Quoted 4 lines
Display altera sysid at startup, which was once removed during the move.
Signed-off-by Thomas Chou <[email protected]>
What if the sysid block isn't part of the design ?
If the sysid block is not present, nothing will display and it is not an error.

Quoted 6 lines

Quoted 1 line
Won't this cause bus stall if you try to access unpopulated location ?
It will be accessed though DT binding. As long as DT is correct, it won't access unpopulated location.
With the Altera Avalon bus, even a unpopulated access will not stall.

OK! Thanks for clarifying.

Acked-by Marek Vasut <[email protected]>

Best regards,
Marek Vasut