Skip to contentSkip to conversation

GPU-host1x: Use a signed return type for do_relocs()

PATCH In review SF Markus Elfring 2 participants 2 messages Dec 19, 2015 – Jan 25, 2016

Subsystems (4)
DRM drivers Kernel janitors Tegra architecture support DRM drivers for NVIDIA Tegra
lore
Share & tools
lore

SF Markus Elfring

author
#0 lore raw

PATCH 1/1 GPU-host1x: Use a signed return type for do_relocs()

From: Markus Elfring <[email protected]>
Date: Sat, 19 Dec 2015 12:48:31 +0100

The return type "unsigned int" was used by the do_relocs() function despite of the aspect that it will eventually return a negative error code. Improve this implementation detail by deletion of the type qualifier then.

This issue was detected by using the Coccinelle software.

Signed-off-by Markus Elfring <[email protected]>
---
 drivers/gpu/host1x/job.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/host1x/job.c +1 -1
index 63bd63f..1919aab 100644
@@ -225,7 +225,7 @@ unpin:
 	return 0;
 }
 
-static unsigned int do_relocs(struct host1x_job *job, struct host1x_bo *cmdbuf)
+static int do_relocs(struct host1x_job *job, struct host1x_bo *cmdbuf)
 {
 	int i = 0;
 	u32 last_page = ~0;
Signature · 1 line
2.6.3
#1 lore raw
Quoted 7 lines · SF Markus Elfring

From: Markus Elfring <[email protected]>
Date: Sat, 19 Dec 2015 12:48:31 +0100

The return type "unsigned int" was used by the do_relocs() function despite of the aspect that it will eventually return a negative error code. Improve this implementation detail by deletion of the type qualifier then.

Quoted 6 lines

This issue was detected by using the Coccinelle software.

Signed-off-by Markus Elfring <[email protected]>
---
 drivers/gpu/host1x/job.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Good catch. Applied, thanks.

Thierry