SCSI-lpfc: Use a signed return type for two functions

From: Markus Elfring <[email protected]>
Date: Sat, 19 Dec 2015 19:32:27 +0100

The return type "size_t" was used by the functions "lpfc_wwn_set" and "lpfc_oas_lun_state_set" despite of the aspect that they will eventually return a negative error code.
Improve this implementation detail by using the type "ssize_t" instead.

This issue was detected by using the Coccinelle software.

---
 drivers/scsi/lpfc/lpfc_attr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

index f6446d7..777960e 100644
@@ -2089,7 +2089,7 @@ static char *lpfc_soft_wwn_key = "C99G71SL8032A";
  * -EINVAL if the buffer does not contain a valid wwn
  * 0 success
  **/
-static size_t
+static ssize_t
 lpfc_wwn_set(const char *buf, size_t cnt, char wwn[])
 {
 	unsigned int i, j;

@@ -2570,7 +2570,7 @@ static DEVICE_ATTR(lpfc_xlane_lun_status, S_IRUGO,
  * -EPERM OAS is not enabled or not supported by this port.
  *
  */
-static size_t
+static ssize_t
 lpfc_oas_lun_state_set(struct lpfc_hba *phba, uint8_t vpt_wwpn[],
 		       uint8_t tgt_wwpn[], uint64_t lun, uint32_t oas_state)
 {

2.6.3

It returns zero or negative error codes. The callers expect int. The current code is harmless. It should return an int.

regards,
dan carpenter