Skip to contentSkip to conversation

ARM: dts: sun4i: Use red1 LED for heartbeat indication on Marsboard A10

PATCH New Aleksei Mamlin 4 participants 6 messages Dec 26, 2015 – Jan 6, 2016

Subsystems (2)
Device tree bindings Arm/Allwinner sunXi SoC support
lore
Share & tools
lore

Aleksei Mamlin

author
#0 lore raw

PATCH 1/1 ARM: dts: sun4i: Use red1 LED for heartbeat indication on Marsboard A10

Marsboard A10 have four red LEDs, the first one can be used for heartbeat indication.

Signed-off-by Aleksei Mamlin <[email protected]>
---
 arch/arm/boot/dts/sun4i-a10-marsboard.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/sun4i-a10-marsboard.dts +1 -0
index 8e50723..ff73ee1 100644
@@ -68,6 +68,7 @@
 		red1 {
 			label = "marsboard:red1:usr";
 			gpios = <&pio 1 5 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "heartbeat";
 		};
 
 		red2 {
Signature · 1 line
2.4.10
#1 lore raw

PATCH 1/1 ARM: dts: sun4i: Use red1 LED for heartbeat indication on Marsboard A10

Quoted 4 lines · Aleksei Mamlin

Marsboard A10 have four red LEDs, the first one can be used for heartbeat indication.

Signed-off-by Aleksei Mamlin <[email protected]>

I'm really not sure about this one.

This is something that can easily be changed through sysfs, and it will likely end up being a "war" on what trigger people want to use.

Hans, Chen-Yu, What's your view on this?

Thanks,
Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151227/aa02729c/attachment.sig>
#2 lore raw

Hi,

Quoted 4 lines · Maxime Ripard
Quoted 3 lines · Aleksei Mamlin

Marsboard A10 have four red LEDs, the first one can be used for heartbeat indication.

Quoted 8 lines
Quoted 1 line
Signed-off-by Aleksei Mamlin <[email protected]>

I'm really not sure about this one.

This is something that can easily be changed through sysfs, and it will likely end up being a "war" on what trigger people want to use.

Hans, Chen-Yu, What's your view on this?

I would prefer to not set any (default) led triggers in the dts files for sunxi boards.

Regards,

Hans

#3 lore raw
Quoted 14 lines · Hans de Goede

Hi,

Quoted 11 lines · Maxime Ripard
Quoted 5 lines · Aleksei Mamlin

Marsboard A10 have four red LEDs, the first one can be used for heartbeat indication.

Signed-off-by Aleksei Mamlin <[email protected]>

I'm really not sure about this one.

Quoted 8 lines
Quoted 4 lines

This is something that can easily be changed through sysfs, and it will likely end up being a "war" on what trigger people want to use.

Hans, Chen-Yu, What's your view on this?

I would prefer to not set any (default) led triggers in the dts files for sunxi boards.

+1

ChenYu

author
#4 lore raw

PATCH 1/1 ARM: dts: sun4i: Use red1 LED for heartbeat indication on Marsboard A10

In reply to Maxime Ripard
Quoted 11 lines · On Sun, 27 Dec 2015 21:51:51 +0100 Maxime Ripard…
Quoted 4 lines · Aleksei Mamlin

Marsboard A10 have four red LEDs, the first one can be used for heartbeat indication.

Signed-off-by Aleksei Mamlin <[email protected]>

I'm really not sure about this one.

This is something that can easily be changed through sysfs, and it will likely end up being a "war" on what trigger people want to use.

If so, then Ok, please ignore this patch.

Is there any way to set led triggers through cmdline instead of sysfs?

Quoted 10 lines

Hans, Chen-Yu, What's your view on this?

Thanks,
Maxime

Signature · 3 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Signature · 2 lines
Thanks and regards,
Aleksei Mamlin
#5 lore raw

PATCH 1/1 ARM: dts: sun4i: Use red1 LED for heartbeat indication on Marsboard A10

Quoted 11 lines · Aleksei Mamlin
Quoted 8 lines · On Sun, 27 Dec 2015 21:51:51 +0100 Maxime Ripard…
Quoted 4 lines · Aleksei Mamlin

Marsboard A10 have four red LEDs, the first one can be used for heartbeat indication.

Signed-off-by Aleksei Mamlin <[email protected]>

I'm really not sure about this one.

Quoted 7 lines
Quoted 3 lines

This is something that can easily be changed through sysfs, and it will likely end up being a "war" on what trigger people want to use.

If so, then Ok, please ignore this patch.

Is there any way to set led triggers through cmdline instead of sysfs?

Unfortunately, I don't think there's any.

Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160106/f7c16428/attachment-0001.sig>