Skip to contentSkip to conversation

extcon: arizona: Use DAPM mutex helper functions

PATCH In review Charles Keepax 2 participants 2 messages Dec 29, 2015 – Dec 30, 2015 External connector subsystem (extcon)

lore
Share & tools
lore

Charles Keepax

author
#0 lore raw

PATCH 1/1 extcon: arizona: Use DAPM mutex helper functions

We should be using the helper functions to lock the DAPM mutex not accessing it directly. There are no ill effects of this as the moment but it is best practice, and the implementation could be changed in the future.

Signed-off-by Charles Keepax <[email protected]>
---
 drivers/extcon/extcon-arizona.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/extcon/extcon-arizona.c +2 -2
index c121d01..1d8e0a5 100644
@@ -185,7 +185,7 @@ static void arizona_extcon_hp_clamp(struct arizona_extcon_info *info,
 		break;
 	};
 
-	mutex_lock(&arizona->dapm->card->dapm_mutex);
+	snd_soc_dapm_mutex_lock(arizona->dapm);
 
 	arizona->hpdet_clamp = clamp;
 

@@ -227,7 +227,7 @@ static void arizona_extcon_hp_clamp(struct arizona_extcon_info *info,
 				 ret);
 	}
 
-	mutex_unlock(&arizona->dapm->card->dapm_mutex);
+	snd_soc_dapm_mutex_unlock(arizona->dapm);
 }
 
 static void arizona_extcon_set_mode(struct arizona_extcon_info *info, int mode)
Signature · 1 line
2.1.4
maintainer
#1 lore raw
Quoted 25 lines · Charles Keepax

We should be using the helper functions to lock the DAPM mutex not accessing it directly. There are no ill effects of this as the moment but it is best practice, and the implementation could be changed in the future.

Signed-off-by Charles Keepax <[email protected]>
---
 drivers/extcon/extcon-arizona.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/extcon/extcon-arizona.c +1 -1
index c121d01..1d8e0a5 100644
@@ -185,7 +185,7 @@ static void arizona_extcon_hp_clamp(struct arizona_extcon_info *info,
 		break;
 	};
 
-	mutex_lock(&arizona->dapm->card->dapm_mutex);
+	snd_soc_dapm_mutex_lock(arizona->dapm);
 
 	arizona->hpdet_clamp = clamp;

drivers/extcon/extcon-arizona.c static void arizona_extcon_hp_clamp(struct arizona_extcon_info *info, · line 233

Quoted 8 lines
drivers/extcon/extcon-arizona.c +1 -1
@@ -227,7 +227,7 @@ static void arizona_extcon_hp_clamp(struct arizona_extcon_info *info,
 				 ret);
 	}
 
-	mutex_unlock(&arizona->dapm->card->dapm_mutex);
+	snd_soc_dapm_mutex_unlock(arizona->dapm);
 }
 
 static void arizona_extcon_set_mode(struct arizona_extcon_info *info, int mode)

Looks good to me. Applied it.

Thanks,
Chanwoo Choi