drm/i915: increase the tries for HDMI hotplug live status checking
Subsystems (2)
PATCH 1/1 drm/i915: increase the tries for HDMI hotplug live status checking
The total delay of HDMI hotplug detecting with 30ms is sometimes not enoughtfor HDMI live status up with specific HDMI monitors in BSW platform.
After doing experiments for following monitors, it needs 80ms at least for those worst cases.
Lenovo L246 1xwA (4 failed, necessary hot-plug delay: 58/40/60/40ms) Philips HH2AP (9 failed, necessary hot-plug delay: 80/50/50/60/46/40/58/58/39ms) BENQ ET-0035-N (6 failed, necessary hot-plug delay: 60/50/50/80/80/40ms) DELL U2713HM (2 failed, necessary hot-plug delay: 58/59ms)
HP HP-LP2475w (5 failed, necessary hot-plug delay: 70/50/40/60/40ms)
It looks like 70-80 ms is BSW platform needs in some bad cases of the monitors at this end (8 times delay at most). Keep less than 100ms for HDCP pulse HPD low (with at least 100ms) to respond a plug out.
--- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) mode change 100644 => 100755 drivers/gpu/drm/i915/intel_hdmi.c
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
@@ -1392,7 +1392,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force)intel_display_power_get (dev_priv,POWER_DOMAIN_GMBUS ); -for (try =0 ; !live_status && try <4 ; try++) { +for (try =0 ; !live_status && try <9 ; try++) {if (try)msleep (10 ); live_status = intel_digital_port_connected(dev_priv,
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
For my test on this issue, it only got high fail-rate with some specific HDMI monitors.
It’s also not easy to reproduce it by modern HDMI monitors (with 1080p/2K/4K resolutions…etc.) or will get low fail-rat (e.g. 1/50 failed test) with that ones. So Linux BSW Gfx validation team could also suffer being hard to reproduce it.
I just would like to raise this problem (about HDMI compatibility) and collect practical cases for handling this kind of issue more smoothly.
Thanks!
Gary
-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Gary Wang
Sent: Wednesday, December 23, 2015 4:12 PM
To: [email protected]
Cc: Kumar, Shobhit <[email protected]>
Subject: [Intel-gfx] [PATCH] drm/i915: increase the tries for HDMI hotplug live status checking
The total delay of HDMI hotplug detecting with 30ms is sometimes not enoughtfor HDMI live status up with specific HDMI monitors in BSW platform.
After doing experiments for following monitors, it needs 80ms at least for those worst cases.
Lenovo L246 1xwA (4 failed, necessary hot-plug delay: 58/40/60/40ms) Philips HH2AP (9 failed, necessary hot-plug delay: 80/50/50/60/46/40/58/58/39ms) BENQ ET-0035-N (6 failed, necessary hot-plug delay: 60/50/50/80/80/40ms) DELL U2713HM (2 failed, necessary hot-plug delay: 58/59ms) HP HP-LP2475w (5 failed, necessary hot-plug delay: 70/50/40/60/40ms)
It looks like 70-80 ms is BSW platform needs in some bad cases of the monitors at this end (8 times delay at most). Keep less than 100ms for HDCP pulse HPD low (with at least 100ms) to respond a plug out.
--- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) mode change 100644 => 100755 drivers/gpu/drm/i915/intel_hdmi.c
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
@@ -1392,7 +1392,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force)intel_display_power_get (dev_priv,POWER_DOMAIN_GMBUS ); -for (try =0 ; !live_status && try <4 ; try++) { +for (try =0 ; !live_status && try <9 ; try++) {if (try)msleep (10 ); live_status = intel_digital_port_connected(dev_priv,
--
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ failure: Fi.CI.BAT
In reply to Gary Wang== Summary ==
== Summary ==
Built on 7e671e69deffb88d60687dacffe6e34a5d046500 drm-intel-nightly: 2015y-12m-22d-13h-28m-34s UTC integration manifest
Test gem_storedw_loop:
Subgroup basic-render:
pass -> DMESG-WARN (skl-i5k-2)
Test kms_flip:
Subgroup basic-flip-vs-dpms:
dmesg-warn -> PASS (ilk-hp8440p)
Subgroup basic-flip-vs-modeset:
dmesg-warn -> PASS (bsw-nuc-2)
dmesg-warn -> PASS (hsw-xps12)
pass -> DMESG-WARN (hsw-brixbox)
dmesg-warn -> PASS (ilk-hp8440p)
dmesg-warn -> PASS (byt-nuc)
Subgroup basic-flip-vs-wf_vblank:
dmesg-warn -> PASS (snb-x220t)
Subgroup basic-plain-flip:
pass -> DMESG-WARN (hsw-xps12)
pass -> DMESG-WARN (bdw-nuci7)
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-a:
pass -> DMESG-WARN (snb-x220t)
Subgroup read-crc-pipe-a:
pass -> DMESG-WARN (snb-x220t)
Subgroup read-crc-pipe-a-frame-sequence:
dmesg-warn -> PASS (byt-nuc)
Subgroup read-crc-pipe-b:
dmesg-warn -> PASS (skl-i5k-2)
Subgroup read-crc-pipe-c:
pass -> DMESG-WARN (skl-i5k-2)
Test kms_psr_sink_crc:
Subgroup psr_basic:
dmesg-warn -> PASS (bdw-ultra)
Test pm_rpm:
Subgroup basic-pci-d3-state:
pass -> DMESG-WARN (bdw-ultra)bdw-nuci7 total:132 pass:121 dwarn:2 dfail:0 fail:0 skip:9 bdw-ultra total:132 pass:124 dwarn:2 dfail:0 fail:0 skip:6 bsw-nuc-2 total:135 pass:114 dwarn:1 dfail:0 fail:0 skip:20 byt-nuc total:135 pass:120 dwarn:2 dfail:0 fail:0 skip:13 hsw-brixbox total:135 pass:126 dwarn:2 dfail:0 fail:0 skip:7 hsw-xps12 total:132 pass:125 dwarn:3 dfail:0 fail:0 skip:4 ilk-hp8440p total:135 pass:100 dwarn:0 dfail:0 fail:0 skip:35 ivb-t430s total:135 pass:127 dwarn:2 dfail:0 fail:0 skip:6 skl-i5k-2 total:135 pass:123 dwarn:4 dfail:0 fail:0 skip:8 skl-i7k-2 total:135 pass:124 dwarn:3 dfail:0 fail:0 skip:8 snb-dellxps total:135 pass:121 dwarn:2 dfail:0 fail:0 skip:12 snb-x220t total:135 pass:121 dwarn:2 dfail:0 fail:1 skip:11
HANGED hsw-gt2 in igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c
Results at /archive/results/CI_IGT_test/Patchwork_801/
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 12 lines · Gary Wang
The total delay of HDMI hotplug detecting with 30ms is sometimes not enoughtfor HDMI live status up with specific HDMI monitors in BSW platform.
After doing experiments for following monitors, it needs 80ms at least for those worst cases.
Lenovo L246 1xwA (4 failed, necessary hot-plug delay: 58/40/60/40ms) Philips HH2AP (9 failed, necessary hot-plug delay: 80/50/50/60/46/40/58/58/39ms) BENQ ET-0035-N (6 failed, necessary hot-plug delay: 60/50/50/80/80/40ms) DELL U2713HM (2 failed, necessary hot-plug delay: 58/59ms)
HP HP-LP2475w (5 failed, necessary hot-plug delay: 70/50/40/60/40ms)
Quoted 4 lines
It looks like 70-80 ms is BSW platform needs in some bad cases of the monitors at this end (8 times delay at most). Keep less than 100ms for HDCP pulse HPD low (with at least 100ms) to respond a plug out.
Adding
Cc: [email protected]
Quoted 20 lines
Reviewed-by Cooper Chiou <[email protected]>Tested-by Gary Wang <[email protected]>Cc Gavin Hindman <[email protected]>Cc Sonika Jindal <[email protected]>Cc Shashank Sharma <[email protected]>Cc Shobhit Kumar <[email protected]>Signed-off-by Gary Wang <[email protected]>--- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mode change 100644 => 100755
drivers/gpu/drm/i915/intel_hdmi.cdrivers/gpu/drm/i915/intel_hdmi.c +0
-0
drivers/gpu/drm/i915/intel_hdmi.c intel_hdmi_detect(struct drm_connector *connector, bool force) · line 1398
Quoted 8 lines
drivers/gpu/drm/i915/intel_hdmi.c +1
-1@@ -1392,7 +1392,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force)intel_display_power_get (dev_priv,POWER_DOMAIN_GMBUS ); -for (try =0 ; !live_status && try <4 ; try++) { +for (try =0 ; !live_status && try <9 ; try++) {if (try)msleep (10 ); live_status = intel_digital_port_connected(dev_priv,
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Regards
Shashank
-----Original Message-----
From: Wang, Gary C
Sent: Wednesday, December 23, 2015 1:42 PM
To: [email protected]
Cc: Hindman, Gavin; Jindal, Sonika; Sharma, Shashank; Kumar, Shobhit
Subject: [PATCH] drm/i915: increase the tries for HDMI hotplug live status checking
The total delay of HDMI hotplug detecting with 30ms is sometimes not enoughtfor HDMI live status up with specific HDMI monitors in BSW platform.
After doing experiments for following monitors, it needs 80ms at least for those worst cases.
Lenovo L246 1xwA (4 failed, necessary hot-plug delay: 58/40/60/40ms) Philips HH2AP (9 failed, necessary hot-plug delay: 80/50/50/60/46/40/58/58/39ms) BENQ ET-0035-N (6 failed, necessary hot-plug delay: 60/50/50/80/80/40ms) DELL U2713HM (2 failed, necessary hot-plug delay: 58/59ms) HP HP-LP2475w (5 failed, necessary hot-plug delay: 70/50/40/60/40ms)
It looks like 70-80 ms is BSW platform needs in some bad cases of the monitors at this end (8 times delay at most). Keep less than 100ms for HDCP pulse HPD low (with at least 100ms) to respond a plug out.
--- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) mode change 100644 => 100755 drivers/gpu/drm/i915/intel_hdmi.c
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
@@ -1392,7 +1392,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force)intel_display_power_get (dev_priv,POWER_DOMAIN_GMBUS ); -for (try =0 ; !live_status && try <4 ; try++) { +for (try =0 ; !live_status && try <9 ; try++) {if (try)msleep (10 ); live_status = intel_digital_port_connected(dev_priv,
--
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerdrivers/gpu/drm/i915/intel_hdmi.c
Quoted 3 lines · Gary Wang
drivers/gpu/drm/i915/intel_hdmi.c +0
-0
Please pay more attention to not changing the file permissions.
Thanks,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 7 lines · Jani Nikula
drivers/gpu/drm/i915/intel_hdmi.c
Quoted 3 lines · Gary Wang
drivers/gpu/drm/i915/intel_hdmi.c +0
-0Please pay more attention to not changing the file permissions.
Yeah, and the new permissions are merged in drm-intel-nightly. Needs correcting the permissions back.
Regards
Shobhit
Quoted 3 lines
Thanks,
Jani.
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
So sorry for it, and will keep in mind on this kind of mistake.
Gary
-----Original Message-----
From: Kumar, Shobhit [mailto:[email protected]]
Sent: Thursday, December 31, 2015 1:47 AM
To: Jani Nikula <[email protected]>; Wang, Gary C <[email protected]>; [email protected]
Cc: Kumar, Shobhit <[email protected]>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: increase the tries for HDMI hotplug live status checking
Quoted 8 lines · Jani Nikula
drivers/gpu/drm/i915/intel_hdmi.c
Quoted 4 lines · Gary Wang
drivers/gpu/drm/i915/intel_hdmi.c +0
-0Please pay more attention to not changing the file permissions.
Yeah, and the new permissions are merged in drm-intel-nightly. Needs correcting the permissions back.
Regards
Shobhit
Quoted 3 lines
Thanks,
Jani.
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx