chromium: update from 40.0.2214.91 to 49.0.2607.0
cover chromium: update from 40.0.2214.91 to 49.0.2607.0
Here is my first submission of a patch series to upgrade the chromium recipe from 40.0.2214.91 to 49.0.2607.0.
The first couple patches perform a bit of cleanup on the existing metadata (fix typos, improve recipe comments). The last patch performs that actual update.
I also took this opportunity to examine the existing patches and remove the ones that are no longer necessary.
The LICENSE file changed because the copyright year was updated. Diff as follows:
--- 40.0.2214.91-r0/chromium-40.0.2214.91/LICENSE 2015-01-21 15:05:37.000000000 -0500 +++ 49.0.2607.0-r0/chromium-49.0.2607.0/LICENSE 2015-11-13 06:04:13.000000000 -0500 @@ -1,4 +1,4 @@ -// Copyright 2014 The Chromium Authors. All rights reserved. +// Copyright 2015 The Chromium Authors. All rights reserved. // // Redistribution and use in source and binary forms, with or without // modification, are permitted provided that the following conditions are
I compile-tested this series with a MACHINE of intel-corei7-64 and no PACKAGECONFIG options in effect.
I run-tested the resulting browser in an image on the ADI Engineering Turbot board (a successor to the MinnowBoard).
This patch series is marked RFC so others can take a look and give it a whirl with their particular configurations. I will continue testing myself but would appreciate any and all feedback. Things to test include:
DISTRO_FEATURES:
- x11
- wayland
CHROMIUM_BUILD_TYPE:
- Release
- Debug
PACKAGECONFIG options:
- use-egl (on by default)
- disable-api-keys-info-bar
- component-build
- ignore-lost-context
- impl-side-painting
Trevor Woerner (4):
chromium.inc: fix typos chromium_40.0.2214.91.bb: improve PACKAGECONFIG info chromium_40.0.2214.91: API keys update
chromium: upgrade 40.0.2214.91 to 49.0.2607.0
recipes-browser/chromium/chromium.inc | 4 +-
...4-Remove-hard-coded-values-for-CC-and-CXX.patch | 0
...4-Remove-hard-coded-values-for-CC-and-CXX.patch | 43 ++++++++
...0001-bignum.cc-disable-warning-from-gcc-5.patch | 39 -------
...-image_util.cc-disable-warning-from-gcc-5.patch | 40 -------
.../chromium-40/add_missing_stat_h_include.patch | 39 -------
.../fix-build-error-with-GCC-in-Debug-mode.patch | 32 ------
...accelerated-Canvas-support-from-blacklist.patch | 0
...Add-Linux-to-impl-side-painting-whitelist.patch | 0
.../0003-Disable-API-keys-info-bar.patch | 0
.../0005-Remove-X-libraries-from-GYP-files.patch | 0
.../0010-systemd-218.patch | 0
.../chromium-49/create-file-for-configure.patch | 3 +
.../chromium-49/fix-compile-warnings.patch | 45 ++++++++
.../chromium-49/v8-internal-startup-data.patch | 13 +++
recipes-browser/chromium/chromium/unistd-2.patch | 27 -----
...ium_40.0.2214.91.bb => chromium_49.0.2607.0.bb} | 115 +++++++++++----------
17 files changed, 169 insertions(+), 231 deletions(-)
rename recipes-browser/chromium/chromium/{chromium-40 => armv6}/0004-Remove-hard-coded-values-for-CC-and-CXX.patch (100%)
create mode 100644 recipes-browser/chromium/chromium/armv7a/0004-Remove-hard-coded-values-for-CC-and-CXX.patch
delete mode 100644 recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-disable-warning-from-gcc-5.patch
delete mode 100644 recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch
delete mode 100644 recipes-browser/chromium/chromium/chromium-40/add_missing_stat_h_include.patch
delete mode 100644 recipes-browser/chromium/chromium/chromium-40/fix-build-error-with-GCC-in-Debug-mode.patch
rename recipes-browser/chromium/chromium/{chromium-40 => chromium-49}/0001-Remove-accelerated-Canvas-support-from-blacklist.patch (100%)
rename recipes-browser/chromium/chromium/{chromium-40 => chromium-49}/0002-Add-Linux-to-impl-side-painting-whitelist.patch (100%)
rename recipes-browser/chromium/chromium/{chromium-40 => chromium-49}/0003-Disable-API-keys-info-bar.patch (100%)
rename recipes-browser/chromium/chromium/{chromium-40 => chromium-49}/0005-Remove-X-libraries-from-GYP-files.patch (100%)
rename recipes-browser/chromium/chromium/{chromium-40 => chromium-49}/0010-systemd-218.patch (100%)
create mode 100644 recipes-browser/chromium/chromium/chromium-49/create-file-for-configure.patch
create mode 100644 recipes-browser/chromium/chromium/chromium-49/fix-compile-warnings.patch
create mode 100644 recipes-browser/chromium/chromium/chromium-49/v8-internal-startup-data.patch
delete mode 100644 recipes-browser/chromium/chromium/unistd-2.patch
rename recipes-browser/chromium/{chromium_40.0.2214.91.bb => chromium_49.0.2607.0.bb} (71%)Signature · 1 line
2.7.0.rc3
RFC PATCH 1/4 chromium.inc: fix typos
The gl PACKAGECONFIG is "use-egl", not "use-gl".
Adjust comment to include a space after initial comment delimiter (#). Close parenthesis at end of comment.
--- recipes-browser/chromium/chromium.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
recipes-browser/chromium/chromium.inc +2 -2
@@ -24,7 +24,7 @@ PACKAGECONFIG[component-build] = "" PACKAGECONFIG[disable-api-keys-info-bar] = "" PACKAGECONFIG[ignore-lost-context] = "" PACKAGECONFIG[impl-side-painting] = "" -PACKAGECONFIG[use-gl] = "" +PACKAGECONFIG[use-egl] = "" GYP_DEFINES += "${ARMFPABI} release_extra_cflags='-Wno-error=unused-local-typedefs' sysroot=''"
@@ -71,7 +71,7 @@ do_install() { fi done - #Chromium *.pak files and CEF pak files ( prefixed with cef_ + # Chromium *.pak files and CEF pak files (prefixed with cef_) for f in content_resources.pak keyboard_resources.pak chrome_100_percent.pak product_logo_48.png resources.pak \ cef_100_percent.pak cef_200_percent.pak cef_resources.pak cef.pak \ locales/en-US.pak; do
Signature · 1 line
2.7.0.rc3
RFC PATCH 2/4 chromium_40.0.2214.91.bb: improve PACKAGECONFIG info
In reply to Trevor WoernerImprove the visual appearance of the PACKAGECONFIG options by adding a title to the PACKAGECONFIG option section, wrapping lines to 80 columns, aligning the left justification for subsequent lines, moving the default settings for each option to a more prominent location, and moving all the items affected by PACKAGECONFIG options to be closer to where these options are listed and explained.
--- recipes-browser/chromium/chromium_40.0.2214.91.bb | 81 +++++++++++++---------- 1 file changed, 45 insertions(+), 36 deletions(-)
recipes-browser/chromium/chromium_40.0.2214.91.bb +45 -36
@@ -26,39 +26,61 @@ SRC_URI = "\ ${@bb.utils.contains('PACKAGECONFIG', 'component-build', 'file://component-build.gypi', '', d)} \ file://google-chrome \ file://google-chrome.desktop \ + file://unistd-2.patch \ file://chromium-40/fix-build-error-with-GCC-in-Debug-mode.patch \ file://chromium-40/add_missing_stat_h_include.patch \ file://chromium-40/0001-bignum.cc-disable-warning-from-gcc-5.patch \ file://chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch \ + file://chromium-40/0004-Remove-hard-coded-values-for-CC-and-CXX.patch \ " +# PACKAGECONFIG options +# ^^^^^^^^^^^^^^^^^^^^^ +# * use-egl: (on by default) +# Without this packageconfig, the Chromium build will use GLX for +# creating an OpenGL context in X11, and regular OpenGL for painting +# operations. Neither are desirable on embedded platforms. With this +# packageconfig, EGL and OpenGL ES 2.x are used instead. # -# * use-egl : Without this packageconfig, the Chromium build will use GLX for creating an OpenGL context in X11, -# and regular OpenGL for painting operations. Neither are desirable on embedded platforms. With this -# packageconfig, EGL and OpenGL ES 2.x are used instead. On by default. +# * disable-api-keys-info-bar: (off by default) +# This disables the info bar that warns: "Google API keys are missing". +# With some builds, missing API keys are considered OK, so the bar needs +# to go. # -# * disable-api-keys-info-bar : This disables the info bar that warns: "Google API keys are missing". With some -# builds, missing API keys are considered OK, so the bar needs to go. -# Off by default. +# * component-build: (off by default) +# Enables component build mode. By default, all of Chromium (with the +# exception of FFmpeg) is linked into one big binary. The linker step +# requires at least 8 GB RAM. Component mode was created to facilitate +# development and testing, since with it, there is not one big binary; +# instead, each component is linked to a separate shared object. Use +# component mode for development, testing, and in case the build machine +# is not a 64-bit one, or has less than 8 GB RAM. # -# * component-build : Enables component build mode. By default, all of Chromium (with the exception of FFmpeg) -# is linked into one big binary. The linker step requires at least 8 GB RAM. Component mode -# was created to facilitate development and testing, since with it, there is not one big -# binary; instead, each component is linked to a separate shared object. -# Use component mode for development, testing, and in case the build machine is not a 64-bit -# one, or has less than 8 GB RAM. Off by default. +# * ignore-lost-context: (off by default) +# There is a flaw in the HTML Canvas specification. When the canvas' +# backing store is some kind of hardware resource like an OpenGL +# texture, this resource might get lost. In case of OpenGL textures, +# this happens when the OpenGL context gets lost. The canvas should then +# be repainted, but nothing in the Canvas standard reflects that. This +# packageconfig is to be used if the underlying OpenGL (ES) drivers do +# not lose the context, or if losing the context is considered okay +# (note that canvas contents can vanish then). # -# * ignore-lost-context : There is a flaw in the HTML Canvas specification. When the canvas' backing store is -# some kind of hardware resource like an OpenGL texture, this resource might get lost. -# In case of OpenGL textures, this happens when the OpenGL context gets lost. The canvas -# should then be repainted, but nothing in the Canvas standard reflects that. -# This packageconfig is to be used if the underlying OpenGL (ES) drivers do not lose -# the context, or if losing the context is considered okay (note that canvas contents can -# vanish then). Off by default. -# -# * impl-side-painting : This is a new painting mechanism. Still in development stages, it can improve performance. -# See http://www.chromium.org/developers/design-documents/impl-side-painting for more. -# Off by default. +# * impl-side-painting: (off by default) +# This is a new painting mechanism. Still in +# development stages, it can improve performance See +# http://www.chromium.org/developers/design-documents/impl-side-painting +# for more. +SRC_URI += "\ + ${@bb.utils.contains('PACKAGECONFIG', 'ignore-lost-context', 'file://chromium-40/0001-Remove-accelerated-Canvas-support-from-blacklist.patch', '', d)} \ + ${@bb.utils.contains('PACKAGECONFIG', 'impl-side-painting', 'file://chromium-40/0002-Add-Linux-to-impl-side-painting-whitelist.patch', '', d)} \ + ${@bb.utils.contains('PACKAGECONFIG', 'disable-api-keys-info-bar', 'file://chromium-40/0003-Disable-API-keys-info-bar.patch', '', d)} \ +" +CHROMIUM_EXTRA_ARGS ?= " \ + ${@bb.utils.contains('PACKAGECONFIG', 'use-egl', '--use-gl=egl', '', d)} \ + ${@bb.utils.contains('PACKAGECONFIG', 'ignore-lost-context', '--gpu-no-context-lost', '', d)} \ + ${@bb.utils.contains('PACKAGECONFIG', 'impl-side-painting', '--enable-gpu-rasterization --enable-impl-side-painting', '', d)} \ +" # Conditionally add ozone-wayland and its patches to the Chromium sources # You can override this by setting CHROMIUM_ENABLE_WAYLAND=1 or CHROMIUM_ENABLE_WAYLAND=0 in local.conf
@@ -97,13 +119,6 @@ do_unpack[postfuncs] += "${@base_conditional('CHROMIUM_ENABLE_WAYLAND', '1', 'co do_patch[prefuncs] += "${@base_conditional('CHROMIUM_ENABLE_WAYLAND', '1', 'add_ozone_wayland_patches', '', d)}" LIC_FILES_CHKSUM = "file://LICENSE;md5=537e0b52077bf0a616d0a0c8a79bc9d5" -SRC_URI += "\ - ${@bb.utils.contains('PACKAGECONFIG', 'ignore-lost-context', 'file://chromium-40/0001-Remove-accelerated-Canvas-support-from-blacklist.patch', '', d)} \ - ${@bb.utils.contains('PACKAGECONFIG', 'impl-side-painting', 'file://chromium-40/0002-Add-Linux-to-impl-side-painting-whitelist.patch', '', d)} \ - ${@bb.utils.contains('PACKAGECONFIG', 'disable-api-keys-info-bar', 'file://chromium-40/0003-Disable-API-keys-info-bar.patch', '', d)} \ - file://chromium-40/0004-Remove-hard-coded-values-for-CC-and-CXX.patch \ - file://unistd-2.patch \ -" SRC_URI[md5sum] = "1f5093bd7e435fdebad070e74bfb3438" SRC_URI[sha256sum] = "f72fda9ff1ea256ab911610ee532eadf8303137d431f2481d01d3d60e5e64149"
@@ -164,12 +179,6 @@ EXTRA_OEGYP = " \ " ARMFPABI_armv7a = "${@bb.utils.contains('TUNE_FEATURES', 'callconvention-hard', 'arm_float_abi=hard', 'arm_float_abi=softfp', d)}" -CHROMIUM_EXTRA_ARGS ?= " \ - ${@bb.utils.contains('PACKAGECONFIG', 'use-egl', '--use-gl=egl', '', d)} \ - ${@bb.utils.contains('PACKAGECONFIG', 'ignore-lost-context', '--gpu-no-context-lost', '', d)} \ - ${@bb.utils.contains('PACKAGECONFIG', 'impl-side-painting', '--enable-gpu-rasterization --enable-impl-side-painting', '', d)} \ -" - GYP_DEFINES += "${ARMFPABI} release_extra_cflags='-Wno-error=unused-local-typedefs' sysroot=''" # These are present as their own variables, since they have changed between versions
Signature · 1 line
2.7.0.rc3
RFC PATCH 3/4 chromium_40.0.2214.91: API keys update
In reply to Trevor WoernerAdd more information to the "disable-api-keys-info-bar" PACKAGECONFIG description regarding another way to disable the "Google API keys are missing" warning.
--- recipes-browser/chromium/chromium_40.0.2214.91.bb | 8 +- recipes-browser/chromium/chromium_49.0.2607.0.bb | 233 ++++++++++++++++++++++ 2 files changed, 240 insertions(+), 1 deletion(-) create mode 100644 recipes-browser/chromium/chromium_49.0.2607.0.bb
recipes-browser/chromium/chromium_40.0.2214.91.bb +7 -1
@@ -45,7 +45,13 @@ SRC_URI = "\ # * disable-api-keys-info-bar: (off by default) # This disables the info bar that warns: "Google API keys are missing". # With some builds, missing API keys are considered OK, so the bar needs -# to go. +# to go. Conversely, if Chromium is compiled with this option off and +# the user wishes to disable the warning, the following lines can be +# added to the "google-chrome" binary (see patchset) before the +# chromium binary is called: +# export GOOGLE_API_KEY="no" +# export GOOGLE_DEFAULT_CLIENT_ID="no" +# export GOOGLE_DEFAULT_CLIENT_SECRET="no" # # * component-build: (off by default) # Enables component build mode. By default, all of Chromium (with the
recipes-browser/chromium/chromium_49.0.2607.0.bb new file +233 -0
233 lines not on this page · raw message
Signature · 1 line
2.7.0.rc3
Re: [meta-browser][RFC PATCH v1 3/4] chromium_40.0.2214.91: API keys update
Oops, looks like this patch got messed up. My git rebase foo isn't as good as it should be ;-)
recipes-browser/chromium/chromium_49.0.2607.0.bb
Quoted 6 lines · Trevor Woerner
recipes-browser/chromium/chromium_49.0.2607.0.bb new file +0
-0
[snip]
this shouldn't have appeared yet
Re: [meta-browser][RFC PATCH v1 3/4] chromium_40.0.2214.91: API keys update
Quoted 2 lines · Trevor Woerner
Oops, looks like this patch got messed up. My git rebase foo isn't as good as it should be ;-)
Please rebase and prepare a v2 of this.
I applied the first two patches of this serie.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Re: [meta-browser][RFC PATCH v1 3/4] chromium_40.0.2214.91: API keys update
Hi Otavio,
Quoted 1 line · Otavio Salvador
I applied the first two patches of this serie.
Awesome, thanks! I'm working on v2 now.
RFC PATCH 4/4 chromium: upgrade 40.0.2214.91 to 49.0.2607.0
In reply to Trevor WoernerUpgrade chromium to the latest version. Cleanup the recipe somewhat and cleanup the patches. The only change in the LICENSE is the copyright year.
---
...4-Remove-hard-coded-values-for-CC-and-CXX.patch | 0
...4-Remove-hard-coded-values-for-CC-and-CXX.patch | 43 ++++
...0001-bignum.cc-disable-warning-from-gcc-5.patch | 39 ----
...-image_util.cc-disable-warning-from-gcc-5.patch | 40 ----
.../chromium-40/add_missing_stat_h_include.patch | 39 ----
.../fix-build-error-with-GCC-in-Debug-mode.patch | 32 ---
...accelerated-Canvas-support-from-blacklist.patch | 0
...Add-Linux-to-impl-side-painting-whitelist.patch | 0
.../0003-Disable-API-keys-info-bar.patch | 0
.../0005-Remove-X-libraries-from-GYP-files.patch | 0
.../0010-systemd-218.patch | 0
.../chromium-49/create-file-for-configure.patch | 3 +
.../chromium-49/fix-compile-warnings.patch | 45 ++++
.../chromium-49/v8-internal-startup-data.patch | 13 ++
recipes-browser/chromium/chromium/unistd-2.patch | 27 ---
recipes-browser/chromium/chromium_40.0.2214.91.bb | 230 ---------------------
recipes-browser/chromium/chromium_49.0.2607.0.bb | 15 +-
17 files changed, 108 insertions(+), 418 deletions(-)
rename recipes-browser/chromium/chromium/{chromium-40 => armv6}/0004-Remove-hard-coded-values-for-CC-and-CXX.patch (100%)
create mode 100644 recipes-browser/chromium/chromium/armv7a/0004-Remove-hard-coded-values-for-CC-and-CXX.patch
delete mode 100644 recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-disable-warning-from-gcc-5.patch
delete mode 100644 recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch
delete mode 100644 recipes-browser/chromium/chromium/chromium-40/add_missing_stat_h_include.patch
delete mode 100644 recipes-browser/chromium/chromium/chromium-40/fix-build-error-with-GCC-in-Debug-mode.patch
rename recipes-browser/chromium/chromium/{chromium-40 => chromium-49}/0001-Remove-accelerated-Canvas-support-from-blacklist.patch (100%)
rename recipes-browser/chromium/chromium/{chromium-40 => chromium-49}/0002-Add-Linux-to-impl-side-painting-whitelist.patch (100%)
rename recipes-browser/chromium/chromium/{chromium-40 => chromium-49}/0003-Disable-API-keys-info-bar.patch (100%)
rename recipes-browser/chromium/chromium/{chromium-40 => chromium-49}/0005-Remove-X-libraries-from-GYP-files.patch (100%)
rename recipes-browser/chromium/chromium/{chromium-40 => chromium-49}/0010-systemd-218.patch (100%)
create mode 100644 recipes-browser/chromium/chromium/chromium-49/create-file-for-configure.patch
create mode 100644 recipes-browser/chromium/chromium/chromium-49/fix-compile-warnings.patch
create mode 100644 recipes-browser/chromium/chromium/chromium-49/v8-internal-startup-data.patch
delete mode 100644 recipes-browser/chromium/chromium/unistd-2.patch
delete mode 100644 recipes-browser/chromium/chromium_40.0.2214.91.bbrecipes-browser/chromium/chromium/armv6/0004-Remove-hard-coded-values-for-CC-and-CXX.patch renamed from recipes-browser/chromium/chromium/chromium-40/0004-Remove-hard-coded-values-for-CC-and-CXX.patch +0 -0
recipes-browser/chromium/chromium/armv7a/0004-Remove-hard-coded-values-for-CC-and-CXX.patch new file +43 -0
43 lines not on this page · raw message
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-disable-warning-from-gcc-5.patch deleted +0 -39
@@ -1,39 +0,0 @@ -From 5b8c53a6bb11c8aa9b575b5a8155c25c5085f349 Mon Sep 17 00:00:00 2001 -From: Max Krummenacher <[email protected]> -Date: Fri, 6 Nov 2015 12:22:35 +0100 -Subject: [PATCH] bignum.cc: disable warning from gcc 5 - -addresses: - ../../third_party/WebKit/Source/wtf/dtoa/bignum.cc:105:10: error: assuming - signed overflow does not occur when assuming that (X + c) < X is always - false [-Werror=strict-overflow] - void Bignum::AssignDecimalString(Vector<const char> value) { - ^ - -Signed-off-by: Max Krummenacher <[email protected]> - -Upstream-Status: Pending -See the discussion on the issue in Chromium upstream: -https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/3uwBwunIa7g ---- - third_party/WebKit/Source/wtf/dtoa/bignum.cc | 3 +++ - 1 file changed, 3 insertions(+) - -diff --git a/third_party/WebKit/Source/wtf/dtoa/bignum.cc b/third_party/WebKit/Source/wtf/dtoa/bignum.cc -index a000b46..6c6d336 100644 ---- a/third_party/WebKit/Source/wtf/dtoa/bignum.cc -+++ b/third_party/WebKit/Source/wtf/dtoa/bignum.cc -@@ -109,7 +109,10 @@ namespace double_conversion { - int length = value.length(); - int pos = 0; - // Let's just say that each digit needs 4 bits. -+#pragma GCC diagnostic push -+#pragma GCC diagnostic warning "-Wstrict-overflow" - while (length >= kMaxUint64DecimalDigits) { -+#pragma GCC diagnostic pop - uint64_t digits = ReadUInt64(value, pos, kMaxUint64DecimalDigits); - pos += kMaxUint64DecimalDigits; - length -= kMaxUint64DecimalDigits; --- -1.8.4.5 -
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch deleted +0 -40
@@ -1,40 +0,0 @@ -From 2f674d980a116075dc7123a3e243b1451e4a732d Mon Sep 17 00:00:00 2001 -From: Max Krummenacher <[email protected]> -Date: Tue, 3 Nov 2015 22:13:40 +0100 -Subject: [PATCH] image_util.cc: disable warning from gcc 5 - -addresses: - ../../ui/gfx/image/image_util.cc:50:6: error: assuming signed overflow does - not occur when assuming that (X - c) <= X is always true - [-Werror=strict-overflow] - bool VisibleMargins(const ImageSkia& image, int* leading, int* trailing) { - ^ - -Signed-off-by: Max Krummenacher <[email protected]> - -Upstream-Status: Pending -See the discussion on the issue in Chromium upstream: -https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/3uwBwunIa7g - ---- - ui/gfx/image/image_util.cc | 3 +++ - 1 file changed, 3 insertions(+) - -diff --git a/ui/gfx/image/image_util.cc b/ui/gfx/image/image_util.cc -index 89a3f8c..d595da3 100644 ---- a/ui/gfx/image/image_util.cc -+++ b/ui/gfx/image/image_util.cc -@@ -68,7 +68,10 @@ bool VisibleMargins(const ImageSkia& image, int* leading, int* trailing) { - int inner_min = bitmap.width(); - for (int x = 0; x < bitmap.width(); ++x) { - for (int y = 0; y < bitmap.height(); ++y) { -+#pragma GCC diagnostic push -+#pragma GCC diagnostic warning "-Wstrict-overflow" - if (SkColorGetA(bitmap.getColor(x, y)) > kMinimumVisibleOpacity) { -+#pragma GCC diagnostic pop - inner_min = x; - break; - } --- -1.8.4.5 -
recipes-browser/chromium/chromium/chromium-40/add_missing_stat_h_include.patch deleted +0 -39
@@ -1,39 +0,0 @@ -sys/stat.h used to be indirectly included through -device/udev_linux/scoped_udev.h -> libudev.h -> sys/stat.h -but libudev.h in jethro no longer includes sys/stat.h resulting in the -following compile time errors: - -arm-angstrom-linux-gnueabi-g++ ... ../../components/storage_monitor/storage_monitor_linux.cc -o obj/components/storage_monitor/storage_monitor.storage_monitor_linux.o -../../components/storage_monitor/storage_monitor_linux.cc: In function 'scoped_ptr<storage_monitor::StorageInfo> storage_monitor::{anonymous}::GetDeviceInfo(const base::FilePath&, const base::FilePath&)': -../../components/storage_monitor/storage_monitor_linux.cc:132:15: error: aggregate 'storage_monitor::{anonymous}::GetDeviceInfo(const base::FilePath&, const base::FilePath&)::stat device_stat' has incomplete type and cannot be defined - struct stat device_stat; - ^ -../../components/storage_monitor/storage_monitor_linux.cc:133:53: error: invalid use of incomplete type 'struct storage_monitor::{anonymous}::GetDeviceInfo(const base::FilePath&, const base::FilePath&)::stat' - if (stat(device_path.value().c_str(), &device_stat) < 0) - ^ -../../components/storage_monitor/storage_monitor_linux.cc:132:10: error: forward declaration of 'struct storage_monitor::{anonymous}::GetDeviceInfo(const base::FilePath&, const base::FilePath&)::stat' - struct stat device_stat; - ^ -../../components/storage_monitor/storage_monitor_linux.cc:137:34: error: 'S_ISCHR' was not declared in this scope - if (S_ISCHR(device_stat.st_mode)) - ^ -../../components/storage_monitor/storage_monitor_linux.cc:139:39: error: 'S_ISBLK' was not declared in this scope - else if (S_ISBLK(device_stat.st_mode)) - ^ - -As the code makes use of stat systemcalls include the file explicitely. -Tested with ARCH armv7. - -Signed-off-by: Max Krummenacher <max.oss.09 at gmail.com> -Upstream-Status: Pending - ---- chromium-40.0.2214.91/components/storage_monitor/storage_monitor_linux.cc~ 2015-01-21 21:28:16.000000000 +0100 -+++ chromium-40.0.2214.91/components/storage_monitor/storage_monitor_linux.cc 2015-10-27 13:21:08.405655894 +0100 -@@ -8,6 +8,7 @@ - - #include <mntent.h> - #include <stdio.h> -+#include <sys/stat.h> - - #include <list> -
recipes-browser/chromium/chromium/chromium-40/fix-build-error-with-GCC-in-Debug-mode.patch deleted +0 -32
@@ -1,32 +0,0 @@ -From bfe80ed5227fccf8ab13df714702fc77e5e3d657 Mon Sep 17 00:00:00 2001 -From: Carlos Alberto Lopez Perez <[email protected]> -Date: Thu, 27 Aug 2015 09:54:06 +0200 -Subject: [PATCH] Fix build error with GCC in Debug mode: - - http://code.google.com/p/chromium/issues/detail?id=525428 ---- - components/invalidation/invalidator_storage.cc | 7 +++++++ - 1 file changed, 7 insertions(+) - -diff --git a/components/invalidation/invalidator_storage.cc b/components/invalidation/invalidator_storage.cc -index 13ba4b1..3d567c1 100644 ---- a/components/invalidation/invalidator_storage.cc -+++ b/components/invalidation/invalidator_storage.cc -@@ -2,7 +2,14 @@ - // Use of this source code is governed by a BSD-style license that can be - // found in the LICENSE file. - -+#if !defined(NDEBUG) -+#pragma GCC diagnostic push -+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized" -+#endif // !defined(NDEBUG) - #include "components/invalidation/invalidator_storage.h" -+#if !defined(NDEBUG) -+#pragma GCC diagnostic pop -+#endif // !defined(NDEBUG) - - #include <string> - #include <utility> --- -2.1.4 -
recipes-browser/chromium/chromium/chromium-49/0001-Remove-accelerated-Canvas-support-from-blacklist.patch renamed from recipes-browser/chromium/chromium/chromium-40/0001-Remove-accelerated-Canvas-support-from-blacklist.patch +0 -0
recipes-browser/chromium/chromium/chromium-49/0002-Add-Linux-to-impl-side-painting-whitelist.patch renamed from recipes-browser/chromium/chromium/chromium-40/0002-Add-Linux-to-impl-side-painting-whitelist.patch +0 -0
recipes-browser/chromium/chromium/chromium-49/0003-Disable-API-keys-info-bar.patch renamed from recipes-browser/chromium/chromium/chromium-40/0003-Disable-API-keys-info-bar.patch +0 -0
recipes-browser/chromium/chromium/chromium-49/0005-Remove-X-libraries-from-GYP-files.patch renamed from recipes-browser/chromium/chromium/chromium-40/0005-Remove-X-libraries-from-GYP-files.patch +0 -0
recipes-browser/chromium/chromium/chromium-49/0010-systemd-218.patch renamed from recipes-browser/chromium/chromium/chromium-40/0010-systemd-218.patch +0 -0
recipes-browser/chromium/chromium/chromium-49/create-file-for-configure.patch new file +3 -0
@@ -0,0 +1,3 @@ +diff --git a/chrome/test/data/webui/i18n_process_css_test.html b/chrome/test/data/webui/i18n_process_css_test.html +new file mode 100644 +index 0000000..e69de29
recipes-browser/chromium/chromium/chromium-49/fix-compile-warnings.patch new file +45 -0
45 lines not on this page · raw message
recipes-browser/chromium/chromium/chromium-49/v8-internal-startup-data.patch new file +13 -0
@@ -0,0 +1,13 @@ +Index: chromium-49.0.2607.0/build/common.gypi +=================================================================== +--- chromium-49.0.2607.0.orig/build/common.gypi ++++ chromium-49.0.2607.0/build/common.gypi +@@ -1046,7 +1046,7 @@ + + # Setting this to '0' will cause V8's startup snapshot to be + # embedded in the binary instead of being a external files. +- 'v8_use_external_startup_data%': 1, ++ 'v8_use_external_startup_data%': 0, + + # Set this to 1 to enable use of concatenated impulse responses + # for the HRTF panner in WebAudio.
recipes-browser/chromium/chromium/unistd-2.patch deleted +0 -27
@@ -1,27 +0,0 @@ -diff --git a/chrome/browser/memory_details_linux.cc b/chrome/browser/memory_details_linux.cc -index bee24ce..299f237 100644 ---- a/chrome/browser/memory_details_linux.cc -+++ b/chrome/browser/memory_details_linux.cc -@@ -7,6 +7,10 @@ - #include <map> - #include <set> - -+#if defined(OS_POSIX) -+#include <unistd.h> -+#endif -+ - #include "base/bind.h" - #include "base/process_util.h" - #include "base/string_util.h" -diff --git a/ipc/ipc_channel.h b/ipc/ipc_channel.h -index 14c375b..345f9eb 100644 ---- a/ipc/ipc_channel.h -+++ b/ipc/ipc_channel.h -@@ -10,6 +10,7 @@ - - #if defined(OS_POSIX) - #include <sys/types.h> -+#include <unistd.h> - #endif - - #include "base/compiler_specific.h"
recipes-browser/chromium/chromium_40.0.2214.91.bb deleted +0 -230
230 lines not on this page · raw message
recipes-browser/chromium/chromium_49.0.2607.0.bb +4 -11
@@ -1,10 +1,9 @@ # Recipe files have to perform the following tasks after including this file: # 1) Add patches to SRC_URI. Version specific patches should be contained in a # "chromium-XX" subdirectory, where XX is the major version. There are also -# patches that are shared amongst versions but may one day no longer be -# needed (like unistd2.patch). These do not belong in such a subdirectory, -# but still need to be explicitely be added. Do NOT add ozone-wayland patches -# to SRC_URI here! +# patches that are shared amongst versions, these do not belong in such +# a subdirectory, but still need to be explicitely be added. Do NOT add +# ozone-wayland patches to SRC_URI here! # 2) Add md5sum and sha256sum hashes of the tarball. # 3) Add ozone-wayland patches to the OZONE_WAYLAND_EXTRA_PATCHES variable. # The rule with the chromium-XX subdirectory also applies here.
@@ -26,17 +25,11 @@ SRC_URI = "\ ${@bb.utils.contains('PACKAGECONFIG', 'component-build', 'file://component-build.gypi', '', d)} \ file://google-chrome \ file://google-chrome.desktop \ - ${@bb.utils.contains('TARGET_ARCH', 'arm', 'file://0004-Remove-hard-coded-values-for-CC-and-CXX.patch', '', d)} \ + ${@bb.utils.contains('TARGET_ARCH', 'armv?', 'file://0004-Remove-hard-coded-values-for-CC-and-CXX.patch', '', d)} \ file://chromium-49/create-file-for-configure.patch \ file://chromium-49/fix-compile-warnings.patch \ file://chromium-49/v8-internal-startup-data.patch \ " -# file://unistd-2.patch \ -# file://chromium-40/fix-build-error-with-GCC-in-Debug-mode.patch \ -# file://chromium-40/add_missing_stat_h_include.patch \ -# file://chromium-40/0001-bignum.cc-disable-warning-from-gcc-5.patch \ -# file://chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch - LIC_FILES_CHKSUM = "file://LICENSE;md5=0fca02217a5d49a14dfe2d11837bb34d" SRC_URI[md5sum] = "faf57865c2b0a752d098c071dec369fb" SRC_URI[sha256sum] = "edaee01924c15a945c13ae166a40536f57c19d26b4def0c3436230fc43394a07"
Signature · 1 line
2.7.0.rc3
Re: [meta-browser][RFC PATCH v1 4/4] chromium: upgrade 40.0.2214.91 to 49.0.2607.0
Carlos,
I need to understand the intent of the patch "0001-Remove-accelerated-Canvas-support-from-blacklist.patch" you created for chromium-40. Back then the json block you wanted to remove for your builds was:
{
"id": 24,
"description": "Accelerated 2d canvas is unstable in Linux at the
moment",
"os": {
"type": "linux"
},
"features": [
"accelerated_2d_canvas"
]
},In chromium-49 that block looks like:
{
"id": 24,
"description": "Accelerated 2d canvas is unstable in Linux at the
moment",
"os": {
"type": "linux"
},
"exceptions": [
{
"gl_vendor": "Vivante Corporation",
"gl_renderer": "Vivante GC1000"
}
],
"features": [
"accelerated_2d_canvas"
]
},Since you do a lot of work with Freescale, Freescale (mostly?) has Vivante, and the latest code has an exception for Vivante specifically, are you (or anyone) still interested in carrying this patch forward?
Best regards,
Trevor