Skip to contentSkip to conversation

drm/amdgpu: add one rlc version into gfxoff blacklist

PATCH In review Huang Rui 3 participants 3 messages Mar 19, 2019 – Mar 20, 2019 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Huang Rui

author
#0 lore raw

PATCH 1/1 drm/amdgpu: add one rlc version into gfxoff blacklist

RLC #53815 ucode has the noise issue on 4k playback while gfxoff enabled.

---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +1 -0
index 6b48d4c..3765d97 100644
@@ -589,6 +589,7 @@ static void gfx_v9_0_check_if_need_gfxoff(struct amdgpu_device *adev)
 		if (adev->rev_id >= 0x8 || adev->pdev->device == 0x15d8)
 			break;
 		if ((adev->gfx.rlc_fw_version < 531) ||
+		    (adev->gfx.rlc_fw_version == 53815) ||
 		    (adev->gfx.rlc_feature_version < 1) ||
 		    !adev->gfx.rlc.is_rlc_v2_1)
 			adev->pm.pp_feature &= ~PP_GFXOFF_MASK;
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1553002293-8565-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org

Acked-by
#2 lore raw
Quoted 4 lines · Huang Rui

RLC #53815 ucode has the noise issue on 4k playback while gfxoff enabled.

Quoted 19 lines
---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +1 -1
index 6b48d4c..3765d97 100644
@@ -589,6 +589,7 @@ static void gfx_v9_0_check_if_need_gfxoff(struct amdgpu_device *adev)
                if (adev->rev_id >= 0x8 || adev->pdev->device == 0x15d8)
                        break;
                if ((adev->gfx.rlc_fw_version < 531) ||
+                   (adev->gfx.rlc_fw_version == 53815) ||
                    (adev->gfx.rlc_feature_version < 1) ||
                    !adev->gfx.rlc.is_rlc_v2_1)
                        adev->pm.pp_feature &= ~PP_GFXOFF_MASK;
--

2.7.4

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Tested-by Tom St Denis
#3 lore raw
In reply to a message not in the archive

FWIW when I manually apply this to my drm-next kernel on my raven1 devel box it works fine.

Tom

Quoted 12 lines · Huang Rui

RLC #53815 ucode has the noise issue on 4k playback while gfxoff enabled.

---
  drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +0 -0
index 6b48d4c..3765d97 100644

drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c static void gfx_v9_0_check_if_need_gfxoff(struct amdgpu_device *adev) · line 595

Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +1 -0
@@ -589,6 +589,7 @@ static void gfx_v9_0_check_if_need_gfxoff(struct amdgpu_device *adev)
  		if (adev->rev_id >= 0x8 || adev->pdev->device == 0x15d8)
  			break;
  		if ((adev->gfx.rlc_fw_version < 531) ||
+		    (adev->gfx.rlc_fw_version == 53815) ||
  		    (adev->gfx.rlc_feature_version < 1) ||
  		    !adev->gfx.rlc.is_rlc_v2_1)
  			adev->pm.pp_feature &= ~PP_GFXOFF_MASK;

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx