Skip to contentSkip to conversation

Nokia N900: Adjust MPU OPP values

DISCUSSION Pali Rohár 3 participants 4 messages Jan 2, 2016 – Jan 5, 2016

lore
Share & tools
lore
#1 lore raw
Quoted 10 lines · Pali Rohár

Hello,

MPU OPP table table (omap36xx_vddcore_volt_data) defined in opp3xxx_data.c does not match Nokia N900 phone. For a long time we have dirty patch in linux-n900 tree for it, see:

https://github.com/pali/linux-n900/commit/4644c5801d7469e2be01d847c61df3d934dadd8c

Now when doing transition to device tree, is there any way how correct MPU OOP table for Nokia N900 could be defined in DT file?

Hmm I'd assume we can just define this in the dts.. Nishanth, got any comments on this one?

Regards,

Tony

#2 lore raw
Quoted 7 lines · Tony Lindgren
Quoted 6 lines · Pali Rohár

Hello,

MPU OPP table table (omap36xx_vddcore_volt_data) defined in opp3xxx_data.c does not match Nokia N900 phone. For a long time we have dirty patch in linux-n900 tree for it, see:

Quoted 8 lines
Quoted 4 lines

https://github.com/pali/linux-n900/commit/4644c5801d7469e2be01d847c61df3d934dadd8c

Now when doing transition to device tree, is there any way how correct MPU OOP table for Nokia N900 could be defined in DT file?

Hmm I'd assume we can just define this in the dts.. Nishanth, got any comments on this one?

We already have definitions in dtb for omap3 OPPs. I think we should start using device tree as default. the oppxx_data.c is sticking around waiting for legacy boot to go away, then those files should be deleted.

Signature · 2 lines
Regards,
Nishanth Menon
#3 lore raw
Quoted 13 lines · On Saturday 02 January 2016 14:38:36 Nishanth Menon wrote:
Quoted 12 lines · Tony Lindgren
Quoted 10 lines · Pali Rohár

Hello,

MPU OPP table table (omap36xx_vddcore_volt_data) defined in opp3xxx_data.c does not match Nokia N900 phone. For a long time we have dirty patch in linux-n900 tree for it, see:

https://github.com/pali/linux-n900/commit/4644c5801d7469e2be01d847c61df3d934dadd8c

Now when doing transition to device tree, is there any way how correct MPU OOP table for Nokia N900 could be defined in DT file?

Quoted 8 lines
Quoted 3 lines

Hmm I'd assume we can just define this in the dts.. Nishanth, got any comments on this one?

We already have definitions in dtb for omap3 OPPs. I think we should start using device tree as default. the oppxx_data.c is sticking around waiting for legacy boot to go away, then those files should be deleted.

Freemangordon, maybe... would it be possible to add (now stable and tested by lot of users) OPP table from Maemo kernel-power to DTS?

Signature · 2 lines
Pali Rohár
[email protected]