mfd: qcom-spmi-pmic: Don't access non-existing registers
Subsystems (2)
PATCH 1/1 mfd: qcom-spmi-pmic: Don't access non-existing registers
From: "Ivan T. Ivanov" <[email protected]>
Revision ID registers are available only on devices with Slave IDs that are even, so don't make access to unavailable registers.
Signed-off-by Ivan T. Ivanov <[email protected]>
[sboyd at codeaurora.org: Consider all slave ids that are even]
Signed-off-by Stephen Boyd <[email protected]>
--- drivers/mfd/qcom-spmi-pmic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/mfd/qcom-spmi-pmic.c +3 -1
@@ -127,7 +127,9 @@ static int pmic_spmi_probe(struct spmi_device *sdev)if (IS_ERR (regmap))return PTR_ERR (regmap); -pmic_spmi_show_revid (regmap, &sdev->dev); +/* Only the first slave id for a PMIC contains this information */ +if (sdev->usid %2 ==0 ) +pmic_spmi_show_revid (regmap, &sdev->dev);return of_platform_populate (root,NULL ,NULL , &sdev->dev); }
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 10 lines · Stephen Boyd
From: "Ivan T. Ivanov" <[email protected]>
Revision ID registers are available only on devices with Slave IDs that are even, so don't make access to unavailable registers.
Signed-off-by Ivan T. Ivanov <[email protected]>[sboyd at codeaurora.org: Consider all slave ids that are even]Signed-off-by Stephen Boyd <[email protected]>---
Ping?
Quoted 18 lines
drivers/mfd/qcom-spmi-pmic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/mfd/qcom-spmi-pmic.c +3
-1@@ -127,7 +127,9 @@ static int pmic_spmi_probe(struct spmi_device *sdev)if (IS_ERR (regmap))return PTR_ERR (regmap); -pmic_spmi_show_revid (regmap, &sdev->dev); +/* Only the first slave id for a PMIC contains this information */ +if (sdev->usid %2 ==0 ) +pmic_spmi_show_revid (regmap, &sdev->dev);return of_platform_populate (root,NULL ,NULL , &sdev->dev); }
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Lee Jones
AppliedQuoted 6 lines · Stephen Boyd
From: "Ivan T. Ivanov" <[email protected]>
Revision ID registers are available only on devices with Slave IDs that are even, so don't make access to unavailable registers.
Quoted 6 lines
Signed-off-by Ivan T. Ivanov <[email protected]>[sboyd at codeaurora.org: Consider all slave ids that are even]Signed-off-by Stephen Boyd <[email protected]>--- drivers/mfd/qcom-spmi-pmic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Applied, thanks.
Quoted 15 lines
drivers/mfd/qcom-spmi-pmic.c +3
-1@@ -127,7 +127,9 @@ static int pmic_spmi_probe(struct spmi_device *sdev)if (IS_ERR (regmap))return PTR_ERR (regmap); -pmic_spmi_show_revid (regmap, &sdev->dev); +/* Only the first slave id for a PMIC contains this information */ +if (sdev->usid %2 ==0 ) +pmic_spmi_show_revid (regmap, &sdev->dev);return of_platform_populate (root,NULL ,NULL , &sdev->dev); }
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog