Skip to contentSkip to conversation

ANN: SELinux Userspace Release 20160107-rc1

DISCUSSION Steve Lawrence 3 participants 4 messages Jan 7, 2016 – Jan 11, 2016 SELinux security module

lore
Share & tools
lore
#1 lore raw
Quoted 10 lines · Steve Lawrence

A release candidate for SELinux Userspace is now available at:

https://github.com/SELinuxProject/selinux/wiki/Releases

This has been tagged as 20160107-rc1 in the git repository.

Please give at a test and let us know if there are any issues.

Thanks,
- Steve

Hello,

As I am updating my packages to test this -rc1, I encountered three very minor problems with secilc:

1. The README says "libsepol >= 2.4", which seems not to be true. I get this error when compiling secilc with libsepol 2.4:

secilc.c:298:7: error: too few arguments to function ‘cil_filecons_to_string’

    rc = cil_filecons_to_string(db, &fc_buf, &fc_size);
         ^
  In file included from secilc.c:40:0:
  /usr/include/sepol/cil/cil.h:47:12: note: declared here
    extern int cil_filecons_to_string(cil_db_t *db, sepol_policydb_t
  *sepol_db, char **o
              ^

<builtin>: recipe for target 'secilc.o' failed
make: *** [secilc.o] Error 1

The build is fine with libsepol 2.5-rc1, so I guess the dependency only needs to be updated in the README file.

2. "make" does not build the man page. This is because it defaults to the first defined target in the Makefile, which is secilc, not "all", unlike the other SELinux projects. I was a little bit surprised that "make" did not behave like "make all" but I guess this is not a big deal. Feel free not to "fix" this.

3. While reading the Makefile, I found that "man" target was missing from the .PHONY line [2] and I do not know the precise consequences of an incomplete .PHONY target. Anyway "make all && make install" works fine.

Thanks,
Nicolas

[1]
https://github.com/SELinuxProject/selinux/blob/secilc-2.5-rc1/secilc/README#L14
[2]
https://github.com/SELinuxProject/selinux/blob/secilc-2.5-rc1/secilc/Makefile#L49

#2 lore raw
Quoted 45 lines · Nicolas Iooss
Quoted 10 lines · Steve Lawrence

A release candidate for SELinux Userspace is now available at:

https://github.com/SELinuxProject/selinux/wiki/Releases

This has been tagged as 20160107-rc1 in the git repository.

Please give at a test and let us know if there are any issues.

Thanks,
- Steve

Hello,

As I am updating my packages to test this -rc1, I encountered three very minor problems with secilc:

1. The README says "libsepol >= 2.4", which seems not to be true. I get this error when compiling secilc with libsepol 2.4:

secilc.c:298:7: error: too few arguments to function ‘cil_filecons_to_string’

    rc = cil_filecons_to_string(db, &fc_buf, &fc_size);
         ^
  In file included from secilc.c:40:0:
  /usr/include/sepol/cil/cil.h:47:12: note: declared here
    extern int cil_filecons_to_string(cil_db_t *db, sepol_policydb_t
  *sepol_db, char **o
              ^

<builtin>: recipe for target 'secilc.o' failed
make: *** [secilc.o] Error 1

The build is fine with libsepol 2.5-rc1, so I guess the dependency only needs to be updated in the README file.

2. "make" does not build the man page. This is because it defaults to the first defined target in the Makefile, which is secilc, not "all", unlike the other SELinux projects. I was a little bit surprised that "make" did not behave like "make all" but I guess this is not a big deal. Feel free not to "fix" this.

3. While reading the Makefile, I found that "man" target was missing from the .PHONY line [2] and I do not know the precise consequences of an incomplete .PHONY target. Anyway "make all && make install" works fine.

Quoted 8 lines

Thanks,
Nicolas

[1]
https://github.com/SELinuxProject/selinux/blob/secilc-2.5-rc1/secilc/README#L14
[2]
https://github.com/SELinuxProject/selinux/blob/secilc-2.5-rc1/secilc/Makefile#L49

Thanks for testing. You're correct on all counts. I'll send a patch to fix these issues shortly.

Thanks,
- Steve

#3 lore raw
In reply to Steve Lawrence
Quoted 8 lines · Steve Lawrence

A release candidate for SELinux Userspace is now available at:

https://github.com/SELinuxProject/selinux/wiki/Releases

This has been tagged as 20160107-rc1 in the git repository.

Please give at a test and let us know if there are any issues.

I've built two testing set of packages for Fedora and both looks good so far.

* http://copr.fedoraproject.org/coprs/plautrba/selinux-master/

It's built from SELinuxProject/selinux tree without any Fedora modifications.

* http://copr.fedoraproject.org/coprs/plautrba/selinux/

Builds are based on 20160107-rc1 release with Fedora modifications tracked in fedora-selinux/selinux repository. The modifications are above all:

* python scripts defaults to /usr/bin/python3
* sepolicy is patched to be usable with python 3
* other changes not-accepted by upstream

I'm going to push this one to Fedora Rawhide during this week.

Feel free to use and test both sets.

Petr

Signature · 1 line
Petr Lautrbach