Skip to contentSkip to conversation

uboot: remove unused helper function insert_define

PATCH New Thomas De Schampheleire 3 participants 3 messages Jan 6, 2016 – Jan 18, 2016

lore
Share & tools
lore

Thomas De Schampheleire

author
#0 lore raw

PATCH 1/1 uboot: remove unused helper function insert_define

From: Thomas De Schampheleire <[email protected]>

Commit 16b8e813c810fde2fe3655c696edf1e76a7d27ba removed all remaining users of helper function insert_define.

Signed-off-by Thomas De Schampheleire <[email protected]>
---
 boot/uboot/uboot.mk | 12 ------------
 1 file changed, 12 deletions(-)
boot/uboot/uboot.mk +0 -12
index c8c50f0..d539b31 100644
@@ -89,18 +89,6 @@ ifeq ($(BR2_TARGET_UBOOT_NEEDS_DTC),y)
 UBOOT_DEPENDENCIES += host-dtc
 endif
 
-# Helper function to fill the U-Boot config.h file.
-# Argument 1: option name
-# Argument 2: option value
-# If the option value is empty, this function does nothing.
-define insert_define
-$(if $(call qstrip,$(2)),
-	@echo "#ifdef $(strip $(1))" >> $(@D)/include/config.h
-	@echo "#undef $(strip $(1))" >> $(@D)/include/config.h
-	@echo "#endif" >> $(@D)/include/config.h
-	@echo '#define $(strip $(1)) $(call qstrip,$(2))' >> $(@D)/include/config.h)
-endef
-
 # prior to u-boot 2013.10 the license info was in COPYING. Copy it so
 # legal-info finds it
 define UBOOT_COPY_OLD_LICENSE_FILE
Signature · 1 line
1.9.5
#1 lore raw

PATCH 1/1 uboot: remove unused helper function insert_define

Quoted 6 lines · Thomas De Schampheleire

From: Thomas De Schampheleire <[email protected]>

Commit 16b8e813c810fde2fe3655c696edf1e76a7d27ba removed all remaining users of helper function insert_define.

Signed-off-by Thomas De Schampheleire <[email protected]>
Acked-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 28 lines
---
 boot/uboot/uboot.mk | 12 ------------
 1 file changed, 12 deletions(-)
boot/uboot/uboot.mk +0 -12
index c8c50f0..d539b31 100644
@@ -89,18 +89,6 @@ ifeq ($(BR2_TARGET_UBOOT_NEEDS_DTC),y)
 UBOOT_DEPENDENCIES += host-dtc
 endif
 
-# Helper function to fill the U-Boot config.h file.
-# Argument 1: option name
-# Argument 2: option value
-# If the option value is empty, this function does nothing.
-define insert_define
-$(if $(call qstrip,$(2)),
-	@echo "#ifdef $(strip $(1))" >> $(@D)/include/config.h
-	@echo "#undef $(strip $(1))" >> $(@D)/include/config.h
-	@echo "#endif" >> $(@D)/include/config.h
-	@echo '#define $(strip $(1)) $(call qstrip,$(2))' >> $(@D)/include/config.h)
-endef
-
 # prior to u-boot 2013.10 the license info was in COPYING. Copy it so
 # legal-info finds it
 define UBOOT_COPY_OLD_LICENSE_FILE
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#2 lore raw

PATCH 1/1 uboot: remove unused helper function insert_define

In reply to Thomas De Schampheleire
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas De Schampheleire <[email protected]> writes:

From: Thomas De Schampheleire <[email protected]> Commit 16b8e813c810fde2fe3655c696edf1e76a7d27ba removed all remaining users of helper function insert_define.

Signed-off-by Thomas De Schampheleire <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard