Correct place for USB PHY driver

DISCUSSION Mason 3 participants 4 messages Jan 11, 2016

lore

Share & tools

lore

Mason

author

2016-01-11 10:07 UTC #0 lore raw

Hello,

I have a board with a Chipidea controller.
I use a custom PHY driver for it.

Should the PHY driver live in drivers/phy or in drivers/usb/phy ?

I was playing with a modular build and hit this problem:
ERROR: "of_usb_get_phy_mode" [drivers/usb/chipidea/ci_hdrc.ko] undefined!

I'm currently using v4.1.13 and I saw that Arnd fixed something related probably in a later version:

http://thread.gmane.org/gmane.linux.ports.arm.kernel/457561

Was this patch accepted upstream?

Regards.

Kishon Vijay Abraham I

2016-01-11 10:28 UTC #1 lore raw

hI,

Quoted 6 lines · Mason

Hello,
I have a board with a Chipidea controller.
I use a custom PHY driver for it.
Should the PHY driver live in drivers/phy or in drivers/usb/phy ?

All new phy drivers should be in drivers/phy using the generic PHY framework.

Quoted 10 lines

I was playing with a modular build and hit this problem:
ERROR: "of_usb_get_phy_mode" [drivers/usb/chipidea/ci_hdrc.ko] undefined!
I'm currently using v4.1.13 and I saw that Arnd fixed something related probably in a later version:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/457561
Was this patch accepted upstream?

I think no.

Thanks
Kishon

Mason

author

2016-01-11 11:56 UTC #2 lore raw

Quoted 12 lines · Kishon Vijay Abraham I

Quoted 4 lines · Mason
I have a board with a Chipidea controller.
I use a custom PHY driver for it.
Should the PHY driver live in drivers/phy or in drivers/usb/phy ?
All new phy drivers should be in drivers/phy using the generic PHY framework.
Quoted 3 lines
I was playing with a modular build and hit this problem:
ERROR: "of_usb_get_phy_mode" [drivers/usb/chipidea/ci_hdrc.ko] undefined!

Quoted 8 lines

Quoted 6 lines
I'm currently using v4.1.13 and I saw that Arnd fixed something related probably in a later version:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/457561
Was this patch accepted upstream?
I think no.

The driver I use is in drivers/phy and my config has

CONFIG_GENERIC_PHY=y
# CONFIG_USB_PHY is not set

But I do hit the "of_usb_get_phy_mode undefined" error when I set all of USB to m.

Arnd, do you think your patch needs to be carried over to generic PHY?

Regards.

Arnd Bergmann

2016-01-11 13:55 UTC #3 lore raw

Quoted 25 lines · On Monday 11 January 2016 12:56:27 Mason wrote:

Quoted 12 lines · Kishon Vijay Abraham I
Quoted 4 lines · Mason
I have a board with a Chipidea controller.
I use a custom PHY driver for it.
Should the PHY driver live in drivers/phy or in drivers/usb/phy ?
All new phy drivers should be in drivers/phy using the generic PHY framework.
Quoted 3 lines
I was playing with a modular build and hit this problem:
ERROR: "of_usb_get_phy_mode" [drivers/usb/chipidea/ci_hdrc.ko] undefined!
Quoted 8 lines
Quoted 6 lines
I'm currently using v4.1.13 and I saw that Arnd fixed something related probably in a later version:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/457561
Was this patch accepted upstream?
I think no.
The driver I use is in drivers/phy and my config has

Quoted 7 lines

CONFIG_GENERIC_PHY=y
# CONFIG_USB_PHY is not set
But I do hit the "of_usb_get_phy_mode undefined" error when I set all of USB to m.
Arnd, do you think your patch needs to be carried over to generic PHY?

I think my patch is still needed, I will resubmit it if it doesn't make it into 4.5-rc1.

In the meantime you can work around the problem by setting CONFIG_USB=y instead of CONFIG_USB=m.

Arnd