test/fs: error case fixes/enhancements
PATCH 1/1 test/fs: error case fixes/enhancements
From: Stephen Warren <[email protected]>
- Use "mkdir -p" to avoid errors when intermediate directories are missing.
- Fall back to "dd" when "fallocate" fails. For example, fallocate isn't supported on ext4.
- Add error checking for test image generation. Without this, the test simply plows on spewing all kinds of errors which are hard to immediately root-cause.
--- test/fs/fs-test.sh | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
test/fs/fs-test.sh +13 -1
@@ -100,7 +100,7 @@ function compile_sandbox() { # We save time by not deleting and recreating the file system images function prepare_env() { rm -f ${MD5_FILE}.* ${OUT}.* - mkdir ${OUT_DIR} + mkdir -p ${OUT_DIR} } # 1st parameter is the name of the image file to be created
@@ -115,11 +115,23 @@ function create_image() { fi if [ ! -f "$1" ]; then fallocate -l 3G "$1" &> /dev/null + if [ $? -ne 0 ]; then + echo fallocate failed - using dd instead + dd if=/dev/zero of=$1 bs=1024 count=$((3 * 1024 * 1024)) + if [ $? -ne 0 ]; then + echo Could not create empty disk image + exit $? + fi + fi mkfs -t "$2" $MKFS_OPTION "$1" &> /dev/null if [ $? -ne 0 -a "$2" = "fat" ]; then # If we fail and we did fat, try vfat. mkfs -t vfat $MKFS_OPTION "$1" &> /dev/null fi + if [ $? -ne 0 ]; then + echo Could not create filesystem + exit $? + fi fi }
Signature · 1 line
2.6.4
PATCH 1/1 test/fs: error case fixes/enhancements
Quoted 9 lines · Stephen Warren
From: Stephen Warren <[email protected]>
- Use "mkdir -p" to avoid errors when intermediate directories are missing.
- Fall back to "dd" when "fallocate" fails. For example, fallocate isn't supported on ext4.
- Add error checking for test image generation. Without this, the test simply plows on spewing all kinds of errors which are hard to immediately root-cause.
Tom,
Any thoughts on this patch?
Quoted 11 lines · Stephen Warren
From: Stephen Warren <[email protected]>
- Use "mkdir -p" to avoid errors when intermediate directories are missing.
- Fall back to "dd" when "fallocate" fails. For example, fallocate isn't supported on ext4.
- Add error checking for test image generation. Without this, the test simply plows on spewing all kinds of errors which are hard to immediately root-cause.Signed-off-by Stephen Warren <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160114/28eb5059/attachment.sig>