Skip to contentSkip to conversation

package/libbroadvoice: Broken on BR2_arc with gcc <= 4.8

PATCH Superseded Bernd Kuhls 3 participants 5 messages Jan 17, 2016 – Jan 19, 2016

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH v2 1/1 package/libbroadvoice: Broken on BR2_arc with gcc <= 4.8

Please read this bug report for details:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59049

Fixes
http://autobuild.buildroot.net/results/4a1/4a1fd92d1ce4963d3e282ea2dc8f0f6c5db4f1e1/
http://autobuild.buildroot.net/results/ce3/ce3be7d27489647a98d8932c5bcabd08c845187b/
http://autobuild.buildroot.net/results/988/988bd189bab37a03c037160d6758774d4aa6c8a0/
and many others

Signed-off-by Bernd Kuhls <[email protected]>

---
v2: changed logic to "material implication" (Arnout, Mason)

 package/libbroadvoice/Config.in | 3 +++
 1 file changed, 3 insertions(+)
package/libbroadvoice/Config.in +3 -0
index d695df0..3301ba8 100644
@@ -1,5 +1,8 @@
 config BR2_PACKAGE_LIBBROADVOICE
 	bool "libbroadvoice"
+	# broken with gcc <= 4.8 on arc
+	# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59049
+	depends on !BR2_arc || BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
 	help
 	  broadvoice - a library for the BroadVoice 16 and 32 speech
 	  codecs
Signature · 1 line
2.7.0.rc3
#1 lore raw

PATCH v2 1/1 package/libbroadvoice: Broken on BR2_arc with gcc <= 4.8

Bernd,

package/libbroadvoice/Config.in line 5

Quoted 10 lines · Bernd Kuhls
package/libbroadvoice/Config.in +3 -0
index d695df0..3301ba8 100644
@@ -1,5 +1,8 @@
 config BR2_PACKAGE_LIBBROADVOICE
 	bool "libbroadvoice"
+	# broken with gcc <= 4.8 on arc
+	# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59049
+	depends on !BR2_arc || BR2_TOOLCHAIN_GCC_AT_LEAST_4_9

If the bug affects gcc 4.8, and ARC currently uses gcc 4.8, why do you need the "!BR2_arc" part of the condition ?

Doing:

depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9

is sufficient, and will ensure that this package will be built again once ARC is moved to a gcc 4.9 based toolchain.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH v2 1/1 package/libbroadvoice: Broken on BR2_arc with gcc <= 4.8

Am Sun, 17 Jan 2016 15:38:06 +0100 schrieb Thomas Petazzoni:

Quoted 9 lines

If the bug affects gcc 4.8, and ARC currently uses gcc 4.8, why do you need the "!BR2_arc" part of the condition ?

Doing:

depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9

is sufficient, and will ensure that this package will be built again once ARC is moved to a gcc 4.9 based toolchain.

Hi Thomas,

libbroadvoice will compile with gcc 4.8 or older on all archs except arc, the gcc bug exists only on arc.

Regards, Bernd

#3 lore raw

PATCH v2 1/1 package/libbroadvoice: Broken on BR2_arc with gcc <= 4.8

In reply to Bernd Kuhls
Quoted 10 lines · Bernd Kuhls

Please read this bug report for details:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59049

Fixes
http://autobuild.buildroot.net/results/4a1/4a1fd92d1ce4963d3e282ea2dc8f0f6c5db4f1e1/
http://autobuild.buildroot.net/results/ce3/ce3be7d27489647a98d8932c5bcabd08c845187b/
http://autobuild.buildroot.net/results/988/988bd189bab37a03c037160d6758774d4aa6c8a0/
and many others

Signed-off-by Bernd Kuhls <[email protected]>
Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

ThomasP: this really is the intended condition.

Note that we could add a comment saying that it needs gcc 4.9 on ARC, but that
would be pointless since you can't currently select gcc 4.9 on ARC...

Regards,
Arnout

Quoted 20 lines

---
v2: changed logic to "material implication" (Arnout, Mason)

 package/libbroadvoice/Config.in | 3 +++
 1 file changed, 3 insertions(+)
package/libbroadvoice/Config.in +3 -0
index d695df0..3301ba8 100644
@@ -1,5 +1,8 @@
 config BR2_PACKAGE_LIBBROADVOICE
 	bool "libbroadvoice"
+	# broken with gcc <= 4.8 on arc
+	# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59049
+	depends on !BR2_arc || BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
 	help
 	  broadvoice - a library for the BroadVoice 16 and 32 speech
 	  codecs
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Applied
#4 lore raw

PATCH v2 1/1 package/libbroadvoice: Broken on BR2_arc with gcc <= 4.8

In reply to Bernd Kuhls

Dear Bernd Kuhls,

Quoted 9 lines · Bernd Kuhls

Please read this bug report for details:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59049

Fixes
http://autobuild.buildroot.net/results/4a1/4a1fd92d1ce4963d3e282ea2dc8f0f6c5db4f1e1/
http://autobuild.buildroot.net/results/ce3/ce3be7d27489647a98d8932c5bcabd08c845187b/
http://autobuild.buildroot.net/results/988/988bd189bab37a03c037160d6758774d4aa6c8a0/
and many others

Quoted 3 lines
Signed-off-by Bernd Kuhls <[email protected]>

---
v2: changed logic to "material implication" (Arnout, Mason)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com