watchdog: tango: rename ARCH_TANGOX to ARCH_TANGO

From: Marc Gonzalez <[email protected]>

Requested by arm-soc maintainer Kevin Hilman in v9 review.
http://article.gmane.org/gmane.linux.ports.arm.kernel/456331

Signed-off-by Marc Gonzalez <[email protected]>

---
Can this fix be pushed into 4.5 ?

(The 'x' in tangox is a wild-card; tango3 is legacy, tango4 is current, tango5 is next.)

---
  drivers/watchdog/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

drivers/watchdog/Kconfig +1 -2

index 4f0e7be0da34..e723e0169f88 100644
@@ -145,7 +145,7 @@ config MENF21BMC_WATCHDOG
  config TANGOX_WATCHDOG
  	tristate "Sigma Designs SMP86xx/SMP87xx watchdog"
  	select WATCHDOG_CORE
-	depends on ARCH_TANGOX || COMPILE_TEST
+	depends on ARCH_TANGO || COMPILE_TEST
  	help
  	  Support for the watchdog in Sigma Designs SMP86xx (tango3)
  	  and SMP87xx (tango4) family chips.
 
--

To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 2 lines · Mason

Requested by arm-soc maintainer Kevin Hilman in v9 review.
http://article.gmane.org/gmane.linux.ports.arm.kernel/456331

The reference should be after the '---' (it doesn't explain the changes, but provides a reference to the change request), and the explanation should be what you have after '---' below, ie that the architecture is tango, that the 'x' is a wildcard, and that it therefore makes more sense to use ARCH_TANGO instead of ARCH_TANGOX.

Quoted 1 line

Can this fix be pushed into 4.5 ?

Depends. Is the definition of ARCH_TANGO going to make it in ?

Hello again,

While I'm at it, should I also rename TANGOX_WATCHDOG ? Or should it be left as is, to minimize churn?

Quoted 4 lines · Mason

Hello again,

While I'm at it, should I also rename TANGOX_WATCHDOG ? Or should it be left as is, to minimize churn?

I don't really care either way.

Quoted 11 lines · Guenter Roeck

Quoted 2 lines · Mason

Requested by arm-soc maintainer Kevin Hilman in v9 review.
http://article.gmane.org/gmane.linux.ports.arm.kernel/456331

The reference should be after the '---' (it doesn't explain the changes, but provides a reference to the change request), and the explanation should be what you have after '---' below, ie that the architecture is tango, that the 'x' is a wildcard, and that it therefore makes more sense to use ARCH_TANGO instead of ARCH_TANGOX.

Hello Guenter,

Thanks for the review.

For the commit message, I am just following Michael's advice:
(one of the clk maintainers)

"Just a single line explaining that the change was requested by the arm-soc devs in the commit log is helpful. I typically reference these discussions in the commit log with a link"

Note, I submitted the same patch to clk.
http://article.gmane.org/gmane.linux.kernel.clk/3164

I'd rather have the same commit message for all these trivial fixups.

Quoted 3 lines

Quoted 1 line

Can this fix be pushed into 4.5 ?

Depends. Is the definition of ARCH_TANGO going to make it in ?

Indeed.

https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/arch/arm/mach-tango/Kconfig

Regards.

Quoted 21 lines · Mason

Quoted 11 lines · Guenter Roeck

Quoted 2 lines · Mason

Requested by arm-soc maintainer Kevin Hilman in v9 review.
http://article.gmane.org/gmane.linux.ports.arm.kernel/456331

The reference should be after the '---' (it doesn't explain the changes, but provides a reference to the change request), and the explanation should be what you have after '---' below, ie that the architecture is tango, that the 'x' is a wildcard, and that it therefore makes more sense to use ARCH_TANGO instead of ARCH_TANGOX.

Hello Guenter,

Thanks for the review.

For the commit message, I am just following Michael's advice:
(one of the clk maintainers)

Quoted 3 lines

"Just a single line explaining that the change was requested by the arm-soc devs in the commit log is helpful. I typically reference these discussions in the commit log with a link"

I'd have expected that as a comment, not in the commit log.

Michael, is that something new ? It isn't really obvious in the drivers/clk logs and appears to be quite unusual.