Convert lpuart serial driver to driver model

PATCH New Bhuvanchandra DV 3 participants 15 messages Jan 12, 2016 – Jan 22, 2016 Arm (32-bit)

Share & tools

Bhuvanchandra DV

author

2016-01-12 04:28 UTC #0 lore raw

cover Convert lpuart serial driver to driver model

- Convert lpuart driver to driver model and remove the legacy code.
- Update Toradex Colibri VF50/VF61 serial support with driver model.
- Update Freescale vf610twr serial support with driver model.
- Update Freescale ls1021atwr serial support with driver model.
- Update Phytec pcm052 serial support with driver model.
- Tested the driver on Toradex Colibri VF50/VF61 hardware.
- Compile checked board files for vf610twr, ls1021atwr and pcm052 since I don't have access to such hardware at my end. Reviewers and testers welcome!

Bhuvanchandra DV (8):
dm: lpuart: Add driver model support for the serial driver
colibri_vf: Update enabling lpuart support with driver model
arm: vf610twr: Add driver model support
vf610twr: Update enabling lpuart with driver model
arm: ls102xa: Add driver model support
ls1021x: Update enabling lpuart with driver model
arm: pcm052: Enable driver model support
pcm052: Update enabling lpuart support with driver model

 arch/arm/include/asm/arch-ls102xa/serial.h |  16 ++++
 arch/arm/include/asm/arch-vf610/serial.h   |  16 ++++
 board/freescale/ls1021atwr/ls1021atwr.c    |  15 ++-
 board/freescale/vf610twr/vf610twr.c        |  13 +++
 board/phytec/pcm052/pcm052.c               |  13 +++
 board/toradex/colibri_vf/colibri_vf.c      |  13 +++
 configs/ls1021atwr_nor_lpuart_defconfig    |   1 +
 configs/pcm052_defconfig                   |   1 +
 configs/vf610twr_defconfig                 |   1 +
 configs/vf610twr_nand_defconfig            |   1 +
 drivers/serial/Kconfig                     |   6 ++
 drivers/serial/serial_lpuart.c             | 148 +++++++++++++++--------------
 include/configs/colibri_vf.h               |   6 +-
 include/configs/ls1021atwr.h               |   1 +
 include/configs/pcm052.h                   |   6 +-
 include/configs/vf610twr.h                 |   6 +-
 16 files changed, 180 insertions(+), 83 deletions(-)
 create mode 100644 arch/arm/include/asm/arch-ls102xa/serial.h
 create mode 100644 arch/arm/include/asm/arch-vf610/serial.h

Signature · 1 line

2.7.0

Bhuvanchandra DV

author

2016-01-12 04:28 UTC #1 lore raw

PATCH 1/8 dm: lpuart: Add driver model support for the serial driver

Convert lpuart driver to driver model and remove the legacy code.

Signed-off-by Bhuvanchandra DV <[email protected]>

---
 arch/arm/include/asm/arch-vf610/serial.h |  16 ++++
 drivers/serial/Kconfig                   |   6 ++
 drivers/serial/serial_lpuart.c           | 148 ++++++++++++++++---------------
 3 files changed, 97 insertions(+), 73 deletions(-)
 create mode 100644 arch/arm/include/asm/arch-vf610/serial.h

arch/arm/include/asm/arch-vf610/serial.h new file +16 -0

new file mode 100644
index 0000000..e9ab552
@@ -0,0 +1,16 @@
+/*
+ * Copyright (C) 2016 Toradex, Inc.
+ *
+ * Author: Bhuvanchandra DV <[email protected]>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#ifndef _LPUART_SERIAL_H
+#define _LPUART_SERIAL_H
+
+struct lpuart_serial_platdata {
+	uint32_t base_addr;
+};
+
+#endif

drivers/serial/Kconfig +6 -0

index 1fc287e..56a06a7 100644
@@ -223,4 +223,10 @@ config UNIPHIER_SERIAL
 	  If you have a UniPhier based board and want to use the on-chip
 	  serial ports, say Y to this option. If unsure, say N.
 
+config FSL_LPUART
+	bool "Freescale lpuart serial port support"
+	depends on DM_SERIAL
+	help
+	  Support for the on-chip lpuart on some Freescale SOCs.
+
 endmenu

drivers/serial/serial_lpuart.c +75 ~~-73~~

257 lines not on this page · raw message

Signature · 1 line

2.7.0

Bhuvanchandra DV

author

2016-01-12 04:28 UTC #2 lore raw

PATCH 2/8 colibri_vf: Update enabling lpuart support with driver model

In reply to Bhuvanchandra DV

Signed-off-by Bhuvanchandra DV <[email protected]>

---
 board/toradex/colibri_vf/colibri_vf.c | 13 +++++++++++++
 include/configs/colibri_vf.h          |  6 +++---
 2 files changed, 16 insertions(+), 3 deletions(-)

board/toradex/colibri_vf/colibri_vf.c +13 -0

index c65ccb3..76bc51c 100644
@@ -8,12 +8,14 @@
  */
 
 #include <common.h>
+#include <dm.h>
 #include <asm/io.h>
 #include <asm/arch/imx-regs.h>
 #include <asm/arch/iomux-vf610.h>
 #include <asm/arch/ddrmc-vf610.h>
 #include <asm/arch/crm_regs.h>
 #include <asm/arch/clock.h>
+#include <asm/arch/serial.h>
 #include <mmc.h>
 #include <fsl_esdhc.h>
 #include <miiphy.h>

@@ -586,3 +588,14 @@ int board_usb_phy_mode(int port)
 	}
 }
 #endif
+
+#ifdef CONFIG_FSL_LPUART
+static struct lpuart_serial_platdata lpuart_serial_plat = {
+	.base_addr = UART0_BASE,
+};
+
+U_BOOT_DEVICE(lpuart_serial) = {
+	.name	= "serial_lpuart",
+	.platdata = &lpuart_serial_plat,
+};
+#endif

include/configs/colibri_vf.h +3 -3

index 708c79a..6ecfdb2 100644
@@ -36,15 +36,15 @@
 
 #define CONFIG_BOARD_EARLY_INIT_F
 
+/* UART support */
+#define CONFIG_DM_SERIAL
 #define CONFIG_FSL_LPUART
-#define LPUART_BASE			UART0_BASE
+#define CONFIG_BAUDRATE			115200
 
 /* Allow to overwrite serial and ethaddr */
 #define CONFIG_ENV_OVERWRITE
 #define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
 #define CONFIG_VERSION_VARIABLE
-#define CONFIG_SYS_UART_PORT		(0)
-#define CONFIG_BAUDRATE			115200
 #define CONFIG_CMD_ASKENV
 
 /* NAND support */

Signature · 1 line

2.7.0

Bhuvanchandra DV

author

2016-01-12 04:28 UTC #3 lore raw

PATCH 3/8 arm: vf610twr: Enable driver model support

In reply to Bhuvanchandra DV

Signed-off-by Bhuvanchandra DV <[email protected]>

---
 configs/vf610twr_defconfig      | 1 +
 configs/vf610twr_nand_defconfig | 1 +
 2 files changed, 2 insertions(+)

configs/vf610twr_defconfig +1 -0

index dc8df5c..46b4e00 100644
@@ -3,6 +3,7 @@ CONFIG_TARGET_VF610TWR=y
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/vf610twr/imximage.cfg,ENV_IS_IN_MMC"
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_DM=y
 CONFIG_NAND_VF610_NFC=y
 CONFIG_SYS_NAND_BUSWIDTH_16BIT=y
 CONFIG_SPI_FLASH=y

configs/vf610twr_nand_defconfig +1 -0

index 98880f3..d244459 100644
@@ -3,6 +3,7 @@ CONFIG_TARGET_VF610TWR=y
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/vf610twr/imximage.cfg,ENV_IS_IN_NAND"
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_DM=y
 CONFIG_NAND_VF610_NFC=y
 CONFIG_SYS_NAND_BUSWIDTH_16BIT=y
 CONFIG_SPI_FLASH=y

Signature · 1 line

2.7.0

Bhuvanchandra DV

author

2016-01-12 04:28 UTC #4 lore raw

PATCH 4/8 vf610twr: Update enabling lpuart with driver model

In reply to Bhuvanchandra DV

Signed-off-by Bhuvanchandra DV <[email protected]>

---
 board/freescale/vf610twr/vf610twr.c | 13 +++++++++++++
 include/configs/vf610twr.h          |  6 +++---
 2 files changed, 16 insertions(+), 3 deletions(-)

board/freescale/vf610twr/vf610twr.c +13 -0

index 37b241d..3ca0094 100644
@@ -5,12 +5,14 @@
  */
 
 #include <common.h>
+#include <dm.h>
 #include <asm/io.h>
 #include <asm/arch/imx-regs.h>
 #include <asm/arch/iomux-vf610.h>
 #include <asm/arch/ddrmc-vf610.h>
 #include <asm/arch/crm_regs.h>
 #include <asm/arch/clock.h>
+#include <asm/arch/serial.h>
 #include <mmc.h>
 #include <fsl_esdhc.h>
 #include <miiphy.h>

@@ -385,3 +387,14 @@ int checkboard(void)
 
 	return 0;
 }
+
+#ifdef CONFIG_FSL_LPUART
+static struct lpuart_serial_platdata lpuart_serial_plat = {
+	.base_addr = UART1_BASE,
+};
+
+U_BOOT_DEVICE(lpuart_serial) = {
+	.name	= "serial_lpuart",
+	.platdata = &lpuart_serial_plat,
+};
+#endif

include/configs/vf610twr.h +3 -3

index 34df6f0..fd898c0 100644
@@ -34,13 +34,13 @@
 
 #define CONFIG_BOARD_EARLY_INIT_F
 
+/* UART support */
+#define CONFIG_DM_SERIAL
 #define CONFIG_FSL_LPUART
-#define LPUART_BASE			UART1_BASE
+#define CONFIG_BAUDRATE			115200
 
 /* Allow to overwrite serial and ethaddr */
 #define CONFIG_ENV_OVERWRITE
-#define CONFIG_SYS_UART_PORT		(1)
-#define CONFIG_BAUDRATE			115200
 
 /* NAND support */
 #define CONFIG_CMD_NAND

Signature · 1 line

2.7.0

Bhuvanchandra DV

author

2016-01-12 04:28 UTC #5 lore raw

PATCH 5/8 arm: ls102xa: Enable driver model support

In reply to Bhuvanchandra DV

Signed-off-by Bhuvanchandra DV <[email protected]>

---
 configs/ls1021atwr_nor_lpuart_defconfig | 1 +
 1 file changed, 1 insertion(+)

configs/ls1021atwr_nor_lpuart_defconfig +1 -0

index d7afca9..d52181b 100644
@@ -2,5 +2,6 @@ CONFIG_ARM=y
 CONFIG_TARGET_LS1021ATWR=y
 CONFIG_SYS_EXTRA_OPTIONS="LPUART"
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_DM=y
 CONFIG_NETDEVICES=y
 CONFIG_E1000=y

Signature · 1 line

2.7.0

Bhuvanchandra DV

author

2016-01-12 04:28 UTC #6 lore raw

PATCH 6/8 ls1021x: Update enabling lpuart with driver model

In reply to Bhuvanchandra DV

Signed-off-by Bhuvanchandra DV <[email protected]>

---
 arch/arm/include/asm/arch-ls102xa/serial.h | 16 ++++++++++++++++
 board/freescale/ls1021atwr/ls1021atwr.c    | 15 ++++++++++++++-
 include/configs/ls1021atwr.h               |  1 +
 3 files changed, 31 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/include/asm/arch-ls102xa/serial.h

arch/arm/include/asm/arch-ls102xa/serial.h new file +16 -0

new file mode 100644
index 0000000..8a99149
@@ -0,0 +1,16 @@
+/*
+ * Copyright (C) 2016 Toradex, Inc.
+ *
+ * Author: Bhuvanchandra DV <[email protected]>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#ifndef _LPUART32_SERIAL_H
+#define _LPUART32_SERIAL_H
+
+struct lpuart_serial_platdata {
+	uint32_t base_addr;
+};
+
+#endif

board/freescale/ls1021atwr/ls1021atwr.c +14 -1

index 8eaff5f..6d3977f 100644
@@ -5,10 +5,13 @@
  */
 
 #include <common.h>
+#include <dm.h>
 #include <i2c.h>
 #include <asm/io.h>
 #include <asm/arch/immap_ls102xa.h>
 #include <asm/arch/clock.h>
+#include <asm/arch/config.h>
+#include <asm/arch/serial.h>
 #include <asm/arch/fsl_serdes.h>
 #include <asm/arch/ls102xa_stream_id.h>
 #include <asm/arch/ls102xa_devdis.h>

@@ -31,7 +34,6 @@
 #include "../../../drivers/qe/qe.h"
 #endif
 
-
 DECLARE_GLOBAL_DATA_PTR;
 
 #define VERSION_MASK		0x00FF

@@ -793,3 +795,14 @@ U_BOOT_CMD(
 	"\nWARNING: If you aren't familiar with the setting of serdes, don't try to change anything!\n"
 );
 #endif
+
+#ifdef CONFIG_FSL_LPUART
+static struct lpuart_serial_platdata lpuart_serial_plat = {
+	.base_addr = LPUART_BASE,
+};
+
+U_BOOT_DEVICE(lpuart_serial) = {
+	.name	= "serial_lpuart32",
+	.platdata = &lpuart_serial_plat,
+};
+#endif

include/configs/ls1021atwr.h +1 -0

index c12ba3a..896c419 100644
@@ -266,6 +266,7 @@
  * Serial Port
  */
 #ifdef CONFIG_LPUART
+#define CONFIG_DM_SERIAL
 #define CONFIG_FSL_LPUART
 #define CONFIG_LPUART_32B_REG
 #else

Signature · 1 line

2.7.0

Bhuvanchandra DV

author

2016-01-12 04:28 UTC #7 lore raw

PATCH 7/8 arm: pcm052: Enable driver model support

In reply to Bhuvanchandra DV

Signed-off-by Bhuvanchandra DV <[email protected]>

---
 configs/pcm052_defconfig | 1 +
 1 file changed, 1 insertion(+)

configs/pcm052_defconfig +1 -0

index 9125645..12fdc0c 100644
@@ -1,5 +1,6 @@
 CONFIG_ARM=y
 CONFIG_TARGET_PCM052=y
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/phytec/pcm052/imximage.cfg,ENV_IS_IN_NAND"
+CONFIG_DM=y
 CONFIG_NAND_VF610_NFC=y
 CONFIG_SYS_NAND_BUSWIDTH_16BIT=y

Signature · 1 line

2.7.0

Bhuvanchandra DV

author

2016-01-12 04:28 UTC #8 lore raw

PATCH 8/8 pcm052: Update enabling lpuart support with driver model

In reply to Bhuvanchandra DV

Signed-off-by Bhuvanchandra DV <[email protected]>

---
 board/phytec/pcm052/pcm052.c | 13 +++++++++++++
 include/configs/pcm052.h     |  6 +++---
 2 files changed, 16 insertions(+), 3 deletions(-)

board/phytec/pcm052/pcm052.c +13 -0

index e4f61e1..3f2ed38 100644
@@ -5,12 +5,14 @@
  */
 
 #include <common.h>
+#include <dm.h>
 #include <asm/io.h>
 #include <asm/arch/imx-regs.h>
 #include <asm/arch/iomux-vf610.h>
 #include <asm/arch/ddrmc-vf610.h>
 #include <asm/arch/crm_regs.h>
 #include <asm/arch/clock.h>
+#include <asm/arch/serial.h>
 #include <mmc.h>
 #include <fsl_esdhc.h>
 #include <miiphy.h>

@@ -513,3 +515,14 @@ int checkboard(void)
 
 	return 0;
 }
+
+#ifdef CONFIG_FSL_LPUART
+static struct lpuart_serial_platdata lpuart_serial_plat = {
+	.base_addr = UART1_BASE,
+};
+
+U_BOOT_DEVICE(lpuart_serial) = {
+	.name	= "serial_lpuart",
+	.platdata = &lpuart_serial_plat,
+};
+#endif

include/configs/pcm052.h +3 -3

index b851bba..bd3992f 100644
@@ -27,13 +27,13 @@
 
 #define CONFIG_BOARD_EARLY_INIT_F
 
+/* UART support */
+#define CONFIG_DM_SERIAL
 #define CONFIG_FSL_LPUART
-#define LPUART_BASE			UART1_BASE
+#define CONFIG_BAUDRATE			115200
 
 /* Allow to overwrite serial and ethaddr */
 #define CONFIG_ENV_OVERWRITE
-#define CONFIG_SYS_UART_PORT		(1)
-#define CONFIG_BAUDRATE			115200
 
 #undef CONFIG_CMD_IMLS

Signature · 1 line

2.7.0

Bin Meng

2016-01-12 05:35 UTC #9 lore raw

cover Convert lpuart serial driver to driver model

In reply to Bhuvanchandra DV

Hi Bhuvanchandra,

Quoted 40 lines · Bhuvanchandra DV

- Convert lpuart driver to driver model and remove the legacy code.
- Update Toradex Colibri VF50/VF61 serial support with driver model.
- Update Freescale vf610twr serial support with driver model.
- Update Freescale ls1021atwr serial support with driver model.
- Update Phytec pcm052 serial support with driver model.
- Tested the driver on Toradex Colibri VF50/VF61 hardware.
- Compile checked board files for vf610twr, ls1021atwr and pcm052 since I don't have access to such hardware at my end. Reviewers and testers welcome!
Bhuvanchandra DV (8):
dm: lpuart: Add driver model support for the serial driver
colibri_vf: Update enabling lpuart support with driver model
arm: vf610twr: Add driver model support
vf610twr: Update enabling lpuart with driver model
arm: ls102xa: Add driver model support
ls1021x: Update enabling lpuart with driver model
arm: pcm052: Enable driver model support
pcm052: Update enabling lpuart support with driver model
 arch/arm/include/asm/arch-ls102xa/serial.h |  16 ++++
 arch/arm/include/asm/arch-vf610/serial.h   |  16 ++++
 board/freescale/ls1021atwr/ls1021atwr.c    |  15 ++-
 board/freescale/vf610twr/vf610twr.c        |  13 +++
 board/phytec/pcm052/pcm052.c               |  13 +++
 board/toradex/colibri_vf/colibri_vf.c      |  13 +++
 configs/ls1021atwr_nor_lpuart_defconfig    |   1 +
 configs/pcm052_defconfig                   |   1 +
 configs/vf610twr_defconfig                 |   1 +
 configs/vf610twr_nand_defconfig            |   1 +
 drivers/serial/Kconfig                     |   6 ++
 drivers/serial/serial_lpuart.c             | 148 +++++++++++++++--------------
 include/configs/colibri_vf.h               |   6 +-
 include/configs/ls1021atwr.h               |   1 +
 include/configs/pcm052.h                   |   6 +-
 include/configs/vf610twr.h                 |   6 +-
 16 files changed, 180 insertions(+), 83 deletions(-)
 create mode 100644 arch/arm/include/asm/arch-ls102xa/serial.h
 create mode 100644 arch/arm/include/asm/arch-vf610/serial.h

Quoted 1 line

--

Please see existing patch series @
http://patchwork.ozlabs.org/patch/561855/. You can drop the ls102xa changes and rebase your patch series on top of that. Thanks!

Regards,
Bin

Bhuvanchandra DV

author

2016-01-12 06:43 UTC #10 lore raw

cover Convert lpuart serial driver to driver model

Hi Bin,

Quoted 44 lines · Bin Meng

Hi Bhuvanchandra,
Quoted 40 lines · Bhuvanchandra DV
- Convert lpuart driver to driver model and remove the legacy code.
- Update Toradex Colibri VF50/VF61 serial support with driver model.
- Update Freescale vf610twr serial support with driver model.
- Update Freescale ls1021atwr serial support with driver model.
- Update Phytec pcm052 serial support with driver model.
- Tested the driver on Toradex Colibri VF50/VF61 hardware.
- Compile checked board files for vf610twr, ls1021atwr and pcm052 since I don't have access to such hardware at my end. Reviewers and testers welcome!
Bhuvanchandra DV (8):
dm: lpuart: Add driver model support for the serial driver
colibri_vf: Update enabling lpuart support with driver model
arm: vf610twr: Add driver model support
vf610twr: Update enabling lpuart with driver model
arm: ls102xa: Add driver model support
ls1021x: Update enabling lpuart with driver model
arm: pcm052: Enable driver model support
pcm052: Update enabling lpuart support with driver model
  arch/arm/include/asm/arch-ls102xa/serial.h |  16 ++++
  arch/arm/include/asm/arch-vf610/serial.h   |  16 ++++
  board/freescale/ls1021atwr/ls1021atwr.c    |  15 ++-
  board/freescale/vf610twr/vf610twr.c        |  13 +++
  board/phytec/pcm052/pcm052.c               |  13 +++
  board/toradex/colibri_vf/colibri_vf.c      |  13 +++
  configs/ls1021atwr_nor_lpuart_defconfig    |   1 +
  configs/pcm052_defconfig                   |   1 +
  configs/vf610twr_defconfig                 |   1 +
  configs/vf610twr_nand_defconfig            |   1 +
  drivers/serial/Kconfig                     |   6 ++
  drivers/serial/serial_lpuart.c             | 148 +++++++++++++++--------------
  include/configs/colibri_vf.h               |   6 +-
  include/configs/ls1021atwr.h               |   1 +
  include/configs/pcm052.h                   |   6 +-
  include/configs/vf610twr.h                 |   6 +-
  16 files changed, 180 insertions(+), 83 deletions(-)
create mode 100644 arch/arm/include/asm/arch-ls102xa/serial.h create mode 100644 arch/arm/include/asm/arch-vf610/serial.h

Quoted 5 lines

Quoted 1 line
--
Please see existing patch series @
http://patchwork.ozlabs.org/patch/561855/. You can drop the ls102xa changes and rebase your patch series on top of that. Thanks!

We are not aware of this patch set, sorry! about that. You want me to drop only the ls102xa changes? How about the changes/updates to the lpuart driver? should i update them with your device tree support stuff and rebase the remaining patch set along with your Signed-off-by tag ? Any suggestions ?

Quoted 4 lines

Regards,
Bin

Signature · 2 lines

Best regards,
Bhuvan

Bin Meng

2016-01-12 06:51 UTC #11 lore raw

cover Convert lpuart serial driver to driver model

Hi Bhuvanchandra,

Quoted 59 lines · Bhuvanchandra DV

Hi Bin,
Quoted 47 lines · Bin Meng
Hi Bhuvanchandra,
Quoted 42 lines · Bhuvanchandra DV
- Convert lpuart driver to driver model and remove the legacy code.
- Update Toradex Colibri VF50/VF61 serial support with driver model.
- Update Freescale vf610twr serial support with driver model.
- Update Freescale ls1021atwr serial support with driver model.
- Update Phytec pcm052 serial support with driver model.
- Tested the driver on Toradex Colibri VF50/VF61 hardware.
- Compile checked board files for vf610twr, ls1021atwr and pcm052 since I don't have access to such hardware at my end. Reviewers and testers welcome!
Bhuvanchandra DV (8):
dm: lpuart: Add driver model support for the serial driver
colibri_vf: Update enabling lpuart support with driver model
arm: vf610twr: Add driver model support
vf610twr: Update enabling lpuart with driver model
arm: ls102xa: Add driver model support
ls1021x: Update enabling lpuart with driver model
arm: pcm052: Enable driver model support
pcm052: Update enabling lpuart support with driver model
  arch/arm/include/asm/arch-ls102xa/serial.h |  16 ++++
  arch/arm/include/asm/arch-vf610/serial.h   |  16 ++++
  board/freescale/ls1021atwr/ls1021atwr.c    |  15 ++-
  board/freescale/vf610twr/vf610twr.c        |  13 +++
  board/phytec/pcm052/pcm052.c               |  13 +++
  board/toradex/colibri_vf/colibri_vf.c      |  13 +++
  configs/ls1021atwr_nor_lpuart_defconfig    |   1 +
  configs/pcm052_defconfig                   |   1 +
  configs/vf610twr_defconfig                 |   1 +
  configs/vf610twr_nand_defconfig            |   1 +
  drivers/serial/Kconfig                     |   6 ++
  drivers/serial/serial_lpuart.c             | 148
+++++++++++++++--------------
  include/configs/colibri_vf.h               |   6 +-
  include/configs/ls1021atwr.h               |   1 +
  include/configs/pcm052.h                   |   6 +-
  include/configs/vf610twr.h                 |   6 +-
  16 files changed, 180 insertions(+), 83 deletions(-)
create mode 100644 arch/arm/include/asm/arch-ls102xa/serial.h create mode 100644 arch/arm/include/asm/arch-vf610/serial.h
Quoted 6 lines
Quoted 1 line
--
Please see existing patch series @
http://patchwork.ozlabs.org/patch/561855/. You can drop the ls102xa changes and rebase your patch series on top of that. Thanks!

Quoted 6 lines

We are not aware of this patch set, sorry! about that. You want me to drop only the ls102xa changes? How about the changes/updates to the lpuart driver? should i update them with your device tree support stuff and rebase the remaining patch set along with your Signed-off-by tag ?
Any suggestions ?

I believe you can:
- Drop the LPUART DM conversion patch in your series, which was already done
- Drop the ls1021atwr changes, which was already done
- Do the similar changes to all other boards in your series, by following ls1021atwr changes in my series
- There is no need to add my SOB tag in your series as I was actually not doing anything :)

Regards,
Bin

Bhuvanchandra DV

author

2016-01-12 09:30 UTC #12 lore raw

cover Convert lpuart serial driver to driver model

Hi Bin,

Quoted 70 lines · Bin Meng

Hi Bhuvanchandra,
Quoted 59 lines · Bhuvanchandra DV
Hi Bin,
Quoted 47 lines · Bin Meng
Hi Bhuvanchandra,
Quoted 42 lines · Bhuvanchandra DV
- Convert lpuart driver to driver model and remove the legacy code.
- Update Toradex Colibri VF50/VF61 serial support with driver model.
- Update Freescale vf610twr serial support with driver model.
- Update Freescale ls1021atwr serial support with driver model.
- Update Phytec pcm052 serial support with driver model.
- Tested the driver on Toradex Colibri VF50/VF61 hardware.
- Compile checked board files for vf610twr, ls1021atwr and pcm052 since I don't have access to such hardware at my end. Reviewers and testers welcome!
Bhuvanchandra DV (8):
dm: lpuart: Add driver model support for the serial driver
colibri_vf: Update enabling lpuart support with driver model
arm: vf610twr: Add driver model support
vf610twr: Update enabling lpuart with driver model
arm: ls102xa: Add driver model support
ls1021x: Update enabling lpuart with driver model
arm: pcm052: Enable driver model support
pcm052: Update enabling lpuart support with driver model
   arch/arm/include/asm/arch-ls102xa/serial.h |  16 ++++
   arch/arm/include/asm/arch-vf610/serial.h   |  16 ++++
   board/freescale/ls1021atwr/ls1021atwr.c    |  15 ++-
   board/freescale/vf610twr/vf610twr.c        |  13 +++
   board/phytec/pcm052/pcm052.c               |  13 +++
   board/toradex/colibri_vf/colibri_vf.c      |  13 +++
   configs/ls1021atwr_nor_lpuart_defconfig    |   1 +
   configs/pcm052_defconfig                   |   1 +
   configs/vf610twr_defconfig                 |   1 +
   configs/vf610twr_nand_defconfig            |   1 +
   drivers/serial/Kconfig                     |   6 ++
   drivers/serial/serial_lpuart.c             | 148
+++++++++++++++--------------
   include/configs/colibri_vf.h               |   6 +-
   include/configs/ls1021atwr.h               |   1 +
   include/configs/pcm052.h                   |   6 +-
   include/configs/vf610twr.h                 |   6 +-
   16 files changed, 180 insertions(+), 83 deletions(-)
create mode 100644 arch/arm/include/asm/arch-ls102xa/serial.h create mode 100644 arch/arm/include/asm/arch-vf610/serial.h
Quoted 6 lines
Quoted 1 line
--
Please see existing patch series @
http://patchwork.ozlabs.org/patch/561855/. You can drop the ls102xa changes and rebase your patch series on top of that. Thanks!
Quoted 6 lines
We are not aware of this patch set, sorry! about that. You want me to drop only the ls102xa changes? How about the changes/updates to the lpuart driver? should i update them with your device tree support stuff and rebase the remaining patch set along with your Signed-off-by tag ?
Any suggestions ?

Quoted 2 lines

I believe you can:
- Drop the LPUART DM conversion patch in your series, which was already done

I believe that the patch set[1] is now _only_ supporting device tree enabled boards, there are boards using lpuart which are not yet having device trees, boards like vf610twr and Phytec pcm052. Even with driver model enabled i guess these boards canont use lpuart via platform data with this patch set. I think it would be nice to have the support for both platform data and device tree so that we can use it with platform data via board files and device tree too.

Since only few boards are using lpuart driver we can update the driver completly to driver model, drop the legacy code and update the boards.

Seems the legacy code in lpuart driver is broken:
drivers/serial/serial_lpuart.c:148:9: error: too few arguments to function '_lpuart_serial_tstc'

I will test the patch set[1] atleast on Toradex Colibri VF50/VF61 h/w and will provide a detailed report of my observations.

[1] http://patchwork.ozlabs.org/patch/561855/

Quoted 9 lines

- Drop the ls1021atwr changes, which was already done
- Do the similar changes to all other boards in your series, by following ls1021atwr changes in my series
- There is no need to add my SOB tag in your series as I was actually not doing anything :)
Regards,
Bin

Signature · 2 lines

Best regards,
Bhuvan

Simon Glass

2016-01-22 03:16 UTC #13 lore raw

cover Convert lpuart serial driver to driver model

Hi,

Quoted 102 lines · Bhuvanchandra DV

Hi Bin,
Quoted 78 lines · Bin Meng
Hi Bhuvanchandra,
Quoted 64 lines · Bhuvanchandra DV
Hi Bin,
Quoted 49 lines · Bin Meng
Hi Bhuvanchandra,
Quoted 43 lines · Bhuvanchandra DV
- Convert lpuart driver to driver model and remove the legacy code.
- Update Toradex Colibri VF50/VF61 serial support with driver model.
- Update Freescale vf610twr serial support with driver model.
- Update Freescale ls1021atwr serial support with driver model.
- Update Phytec pcm052 serial support with driver model.
- Tested the driver on Toradex Colibri VF50/VF61 hardware.
- Compile checked board files for vf610twr, ls1021atwr and pcm052 since I don't have access to such hardware at my end. Reviewers and testers welcome!
Bhuvanchandra DV (8):
dm: lpuart: Add driver model support for the serial driver
colibri_vf: Update enabling lpuart support with driver model
arm: vf610twr: Add driver model support
vf610twr: Update enabling lpuart with driver model
arm: ls102xa: Add driver model support
ls1021x: Update enabling lpuart with driver model
arm: pcm052: Enable driver model support
pcm052: Update enabling lpuart support with driver model
   arch/arm/include/asm/arch-ls102xa/serial.h |  16 ++++
   arch/arm/include/asm/arch-vf610/serial.h   |  16 ++++
   board/freescale/ls1021atwr/ls1021atwr.c    |  15 ++-
   board/freescale/vf610twr/vf610twr.c        |  13 +++
   board/phytec/pcm052/pcm052.c               |  13 +++
   board/toradex/colibri_vf/colibri_vf.c      |  13 +++
   configs/ls1021atwr_nor_lpuart_defconfig    |   1 +
   configs/pcm052_defconfig                   |   1 +
   configs/vf610twr_defconfig                 |   1 +
   configs/vf610twr_nand_defconfig            |   1 +
   drivers/serial/Kconfig                     |   6 ++
   drivers/serial/serial_lpuart.c             | 148
+++++++++++++++--------------
   include/configs/colibri_vf.h               |   6 +-
   include/configs/ls1021atwr.h               |   1 +
   include/configs/pcm052.h                   |   6 +-
   include/configs/vf610twr.h                 |   6 +-
   16 files changed, 180 insertions(+), 83 deletions(-)
create mode 100644 arch/arm/include/asm/arch-ls102xa/serial.h create mode 100644 arch/arm/include/asm/arch-vf610/serial.h
Quoted 7 lines
Quoted 1 line
--
Please see existing patch series @
http://patchwork.ozlabs.org/patch/561855/. You can drop the ls102xa changes and rebase your patch series on top of that. Thanks!
Quoted 8 lines
We are not aware of this patch set, sorry! about that. You want me to drop
only the ls102xa changes? How about the changes/updates to the lpuart driver? should i update them with your device tree support stuff and rebase
the remaining patch set along with your Signed-off-by tag ? Any suggestions ?
Quoted 3 lines
I believe you can:
- Drop the LPUART DM conversion patch in your series, which was already done
I believe that the patch set[1] is now _only_ supporting device tree enabled boards, there are boards using lpuart which are not yet having device trees, boards like vf610twr and Phytec pcm052. Even with driver model enabled i guess these boards canont use lpuart via platform data with this patch set. I think it would be nice to have the support for both platform data and device tree so that we can use it with platform data via board files and device tree too.
Since only few boards are using lpuart driver we can update the driver completly to driver model, drop the legacy code and update the boards.
Seems the legacy code in lpuart driver is broken:
drivers/serial/serial_lpuart.c:148:9: error: too few arguments to function '_lpuart_serial_tstc'

Quoted 11 lines

I will test the patch set[1] atleast on Toradex Colibri VF50/VF61 h/w and will provide a detailed report of my observations.
[1] http://patchwork.ozlabs.org/patch/561855/
Quoted 5 lines
- Drop the ls1021atwr changes, which was already done
- Do the similar changes to all other boards in your series, by following ls1021atwr changes in my series
- There is no need to add my SOB tag in your series as I was actually not doing anything :)

Please go ahead and post any new patches that are required here now that Bin's series has landed.

Regards,
Simon

Bhuvanchandra DV

author

2016-01-22 07:33 UTC #14 lore raw

cover Convert lpuart serial driver to driver model

Hi Simon,

Quoted 112 lines · Simon Glass

Hi,
Quoted 108 lines · Bhuvanchandra DV
Hi Bin,
Quoted 78 lines · Bin Meng
Hi Bhuvanchandra,
Quoted 64 lines · Bhuvanchandra DV
Hi Bin,
Quoted 49 lines · Bin Meng
Hi Bhuvanchandra,
Quoted 43 lines · Bhuvanchandra DV
- Convert lpuart driver to driver model and remove the legacy code.
- Update Toradex Colibri VF50/VF61 serial support with driver model.
- Update Freescale vf610twr serial support with driver model.
- Update Freescale ls1021atwr serial support with driver model.
- Update Phytec pcm052 serial support with driver model.
- Tested the driver on Toradex Colibri VF50/VF61 hardware.
- Compile checked board files for vf610twr, ls1021atwr and pcm052 since I don't have access to such hardware at my end. Reviewers and testers welcome!
Bhuvanchandra DV (8):
dm: lpuart: Add driver model support for the serial driver
colibri_vf: Update enabling lpuart support with driver model
arm: vf610twr: Add driver model support
vf610twr: Update enabling lpuart with driver model
arm: ls102xa: Add driver model support
ls1021x: Update enabling lpuart with driver model
arm: pcm052: Enable driver model support
pcm052: Update enabling lpuart support with driver model
arch/arm/include/asm/arch-ls102xa/serial.h | 16 ++++
arch/arm/include/asm/arch-vf610/serial.h | 16 ++++
board/freescale/ls1021atwr/ls1021atwr.c | 15 ++-
board/freescale/vf610twr/vf610twr.c | 13 +++
board/phytec/pcm052/pcm052.c | 13 +++
board/toradex/colibri_vf/colibri_vf.c | 13 +++
configs/ls1021atwr_nor_lpuart_defconfig | 1 +
configs/pcm052_defconfig | 1 +
configs/vf610twr_defconfig | 1 +
configs/vf610twr_nand_defconfig | 1 +
drivers/serial/Kconfig | 6 ++
drivers/serial/serial_lpuart.c | 148
+++++++++++++++--------------
    include/configs/colibri_vf.h               |   6 +-
    include/configs/ls1021atwr.h               |   1 +
    include/configs/pcm052.h                   |   6 +-
    include/configs/vf610twr.h                 |   6 +-
    16 files changed, 180 insertions(+), 83 deletions(-)
    create mode 100644 arch/arm/include/asm/arch-ls102xa/serial.h
    create mode 100644 arch/arm/include/asm/arch-vf610/serial.h
Quoted 7 lines
Quoted 1 line
--
Please see existing patch series @
http://patchwork.ozlabs.org/patch/561855/. You can drop the ls102xa changes and rebase your patch series on top of that. Thanks!
Quoted 8 lines
We are not aware of this patch set, sorry! about that. You want me to drop
only the ls102xa changes? How about the changes/updates to the lpuart driver? should i update them with your device tree support stuff and rebase
the remaining patch set along with your Signed-off-by tag ? Any suggestions ?
Quoted 3 lines
I believe you can:
- Drop the LPUART DM conversion patch in your series, which was already done
I believe that the patch set[1] is now _only_ supporting device tree enabled boards, there are boards using lpuart which are not yet having device trees, boards like vf610twr and Phytec pcm052. Even with driver model enabled i guess these boards canont use lpuart via platform data with this patch set. I think it would be nice to have the support for both platform data and device tree so that we can use it with platform data via board files and device tree too.
Since only few boards are using lpuart driver we can update the driver completly to driver model, drop the legacy code and update the boards.
Seems the legacy code in lpuart driver is broken:
drivers/serial/serial_lpuart.c:148:9: error: too few arguments to function '_lpuart_serial_tstc'
I will test the patch set[1] atleast on Toradex Colibri VF50/VF61 h/w and will provide a detailed report of my observations.
[1] http://patchwork.ozlabs.org/patch/561855/

Quoted 8 lines

Quoted 5 lines
Quoted 5 lines
- Drop the ls1021atwr changes, which was already done
- Do the similar changes to all other boards in your series, by following ls1021atwr changes in my series
- There is no need to add my SOB tag in your series as I was actually not doing anything :)
Please go ahead and post any new patches that are required here now that Bin's series has landed.

Will submit the new patchset ASAP.

Quoted 4 lines

Regards,
Simon

Signature · 2 lines

Best regards,
Bhuvan