Skip to contentSkip to conversation

watchdog: tango: rename ARCH_TANGOX to ARCH_TANGO

PATCH In review Mason 3 participants 7 messages Jan 21, 2016 – Jan 22, 2016 Watchdog device drivers

lore
Share & tools
lore

Mason

author
#0 lore raw

PATCH v2 1/1 watchdog: tango: rename ARCH_TANGOX to ARCH_TANGO

From: Marc Gonzalez <[email protected]>

This change was requested by arm-soc maintainer Kevin Hilman because the X in TANGOX is a wildcard.

---
 drivers/watchdog/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/Kconfig +1 -1
index 4f0e7be0da34..e723e0169f88 100644
@@ -145,7 +145,7 @@ config MENF21BMC_WATCHDOG
 config TANGOX_WATCHDOG
 	tristate "Sigma Designs SMP86xx/SMP87xx watchdog"
 	select WATCHDOG_CORE
-	depends on ARCH_TANGOX || COMPILE_TEST
+	depends on ARCH_TANGO || COMPILE_TEST
 	help
 	  Support for the watchdog in Sigma Designs SMP86xx (tango3)
 	  and SMP87xx (tango4) family chips.
Acked-by on v2 1/1
#1 lore raw
Quoted 9 lines · Mason

From: Marc Gonzalez <[email protected]>

This change was requested by arm-soc maintainer Kevin Hilman because the X in TANGOX is a wildcard.

---
 drivers/watchdog/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines
drivers/watchdog/Kconfig +1 -1
index 4f0e7be0da34..e723e0169f88 100644
@@ -145,7 +145,7 @@ config MENF21BMC_WATCHDOG
 config TANGOX_WATCHDOG
 	tristate "Sigma Designs SMP86xx/SMP87xx watchdog"
 	select WATCHDOG_CORE
-	depends on ARCH_TANGOX || COMPILE_TEST
+	depends on ARCH_TANGO || COMPILE_TEST
 	help
 	  Support for the watchdog in Sigma Designs SMP86xx (tango3)
 	  and SMP87xx (tango4) family chips.
Signature · 1 line
Måns Rullgård
maintainer Reviewed-by on v2 1/1
#2 lore raw
In reply to Mason
Quoted 5 lines · Mason

From: Marc Gonzalez <[email protected]>

This change was requested by arm-soc maintainer Kevin Hilman because the X in TANGOX is a wildcard.

Not what I was looking for, but not worth arguing about it, so

Quoted 1 line
Quoted 22 lines
---
 drivers/watchdog/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/Kconfig +1 -2
index 4f0e7be0da34..e723e0169f88 100644
@@ -145,7 +145,7 @@ config MENF21BMC_WATCHDOG
 config TANGOX_WATCHDOG
 	tristate "Sigma Designs SMP86xx/SMP87xx watchdog"
 	select WATCHDOG_CORE
-	depends on ARCH_TANGOX || COMPILE_TEST
+	depends on ARCH_TANGO || COMPILE_TEST
 	help
 	  Support for the watchdog in Sigma Designs SMP86xx (tango3)
 	  and SMP87xx (tango4) family chips.
 
--

To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 7 lines · Guenter Roeck
Quoted 5 lines · Mason

From: Marc Gonzalez <[email protected]>

This change was requested by arm-soc maintainer Kevin Hilman because the X in TANGOX is a wildcard.

Not what I was looking for, but not worth arguing about it, so

It would be better if the commit message simply mentioned the fact that the platform support uses ARCH_TANGO and this has to match. The details of why it got named that way are less important.

Quoted 26 lines
Quoted 1 line
Quoted 22 lines
---
 drivers/watchdog/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/Kconfig +1 -2
index 4f0e7be0da34..e723e0169f88 100644
@@ -145,7 +145,7 @@ config MENF21BMC_WATCHDOG
 config TANGOX_WATCHDOG
 	tristate "Sigma Designs SMP86xx/SMP87xx watchdog"
 	select WATCHDOG_CORE
-	depends on ARCH_TANGOX || COMPILE_TEST
+	depends on ARCH_TANGO || COMPILE_TEST
 	help
 	  Support for the watchdog in Sigma Designs SMP86xx (tango3)
 	  and SMP87xx (tango4) family chips.
 
--

To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 5 lines
Måns Rullgård
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
maintainer
#4 lore raw
Quoted 5 lines · Måns Rullgård
Quoted 3 lines · Guenter Roeck
Quoted 2 lines · Mason

From: Marc Gonzalez <[email protected]>

Quoted 9 lines
Quoted 4 lines
Quoted 3 lines

This change was requested by arm-soc maintainer Kevin Hilman because the X in TANGOX is a wildcard.

Not what I was looking for, but not worth arguing about it, so

It would be better if the commit message simply mentioned the fact that the platform support uses ARCH_TANGO and this has to match. The details of why it got named that way are less important.

Agreed. That is why I had asked to move that information after the "---". But as I said, this is not worth an endless argument.

Guenter

Quoted 22 lines
Quoted 22 lines
Quoted 1 line
Quoted 18 lines
---
  drivers/watchdog/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/Kconfig +1 -1
index 4f0e7be0da34..e723e0169f88 100644
@@ -145,7 +145,7 @@ config MENF21BMC_WATCHDOG
  config TANGOX_WATCHDOG
  	tristate "Sigma Designs SMP86xx/SMP87xx watchdog"
  	select WATCHDOG_CORE
-	depends on ARCH_TANGOX || COMPILE_TEST
+	depends on ARCH_TANGO || COMPILE_TEST
  	help
  	  Support for the watchdog in Sigma Designs SMP86xx (tango3)
  	  and SMP87xx (tango4) family chips.
Quoted 5 lines
Quoted 4 lines
Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#5 lore raw
Quoted 10 lines · Guenter Roeck
Quoted 8 lines · Måns Rullgård
Quoted 6 lines · Guenter Roeck
Quoted 4 lines · Mason

From: Marc Gonzalez <[email protected]>

This change was requested by arm-soc maintainer Kevin Hilman because the X in TANGOX is a wildcard.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

Not what I was looking for, but not worth arguing about it, so

It would be better if the commit message simply mentioned the fact that the platform support uses ARCH_TANGO and this has to match. The details of why it got named that way are less important.

Agreed. That is why I had asked to move that information after the "---". But as I said, this is not worth an endless argument.

As long as the patch makes it into v4.5, I don't mind a different commit message. You can reword as you wish.

Regards.

maintainer
#6 lore raw
Quoted 18 lines · Mason
Quoted 16 lines · Guenter Roeck
Quoted 14 lines · Måns Rullgård
Quoted 7 lines · Guenter Roeck
Quoted 4 lines · Mason

From: Marc Gonzalez <[email protected]>

This change was requested by arm-soc maintainer Kevin Hilman because the X in TANGOX is a wildcard.

Not what I was looking for, but not worth arguing about it, so

It would be better if the commit message simply mentioned the fact that the platform support uses ARCH_TANGO and this has to match. The details of why it got named that way are less important.

Quoted 6 lines
Quoted 2 lines

Agreed. That is why I had asked to move that information after the "---". But as I said, this is not worth an endless argument.

As long as the patch makes it into v4.5, I don't mind a different commit message. You can reword as you wish.

Wim is the maintainer. If anything, he would have to do the rewording.

I would like you to keep one thing in mind, though, for your future patches. Maintainers tend to be busy. It helps to make life easy for them.

Thanks,
Guenter